Re: [PATCH] arm64: dts: rockchip: give some life to the rk3328-roc-cc leds

["Leonidas P. Papadakos" <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Sat, Mar 02, 2019 at 01:31:11AM +0100, Heiko Stuebner wrote:
> Am Freitag, 1. März 2019, 23:58:13 CET schrieb Leonidas P. Papadakos:
> > Assign the LED's to heartbeat and sdcard io, as in other RK boards.
> > 
> > https://github.com/armbian/build/commit/f1affad5c7be62d6e93832af3556c7609edd0858
> > 
> > Signed-off-by: Leonidas P. Papadakos <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> >  .../arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 27 +++++++++++++++++++
> >  1 file changed, 27 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> > index 33c44e857..a881d4c8d 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> > @@ -81,6 +81,33 @@
> >  		regulator-always-on;
> >  		regulator-boot-on;
> >  	};
> > +
> > +	leds {
> > +		compatible = "gpio-leds";
> > +		power {
> > +			label = "firefly:blue:power";
> > +			linux,default-trigger = "heartbeat";
> > +			gpios = <&rk805 1 GPIO_ACTIVE_LOW>;
> > +			default-state = "on";
> > +			mode = <0x23>;
> > +		};
> > +
> > +		user {
> > +			label = "firefly:yellow:user";
> > +			linux,default-trigger = "mmc1";
> > +			gpios = <&rk805 0 GPIO_ACTIVE_LOW>;
> > +			default-state = "off";
> > +			mode = <0x05>;
> > +		};
> > +
> > +		ir {
> > +			status = "disabled";
> 
> please explain that. Is this an IR transmitting LED? And why are you
> adding a disabled property?
> 
> Similar to how the kernel should not contain commented out code
> having a disabled node in the actual board file is strange.
> 
> 
> Heiko
> 

It probably is. See the image of the board on this site:
https://shop.t-firefly.com/goods.php?id=65

Should I make a PATCH v2 without it?

> > +			/* gpios = <&gpio2 GPIO_C2 GPIO_ACTIVE_HIGH>; */
> > +			linux,default-trigger = "ir";
> > +			default-state = "off";
> > +			mode = <0x00>;
> > +		};
> > +	};
> >  };
> >  
> >  &cpu0 {
> > 
> 
> 
> 
>