From: Dafna Hirschfeld <dafna@fastmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org,
Paul Elder <paul.elder@ideasonboard.com>,
Florian Sylvestre <fsylvestre@baylibre.com>
Subject: Re: [PATCH 2/5] media: rkisp1: Store LSC register values in u32 variables
Date: Thu, 18 Aug 2022 05:37:33 +0300 [thread overview]
Message-ID: <20220818023733.yckej5xyfsbc4btb@guri> (raw)
In-Reply-To: <20220817021850.20460-3-laurent.pinchart@ideasonboard.com>
On 17.08.2022 05:18, Laurent Pinchart wrote:
>Use the u32 type instead of unsigned int to store register values in the
>LSC configuration code, to make the variables' size more explicit. No
>functional change intended.
>
>Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dafna Hirschfeld <dafna@fastmail.com>
>---
> drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
>index fbbaf5505291..dbe826fd02d2 100644
>--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
>+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
>@@ -199,7 +199,8 @@ rkisp1_lsc_matrix_config_v10(struct rkisp1_params *params,
> const struct rkisp1_cif_isp_lsc_config *pconfig)
> {
> struct rkisp1_device *rkisp1 = params->rkisp1;
>- unsigned int lsc_status, sram_addr, lsc_table_sel, i, j;
>+ u32 lsc_status, sram_addr, lsc_table_sel;
>+ unsigned int i, j;
>
> lsc_status = rkisp1_read(rkisp1, RKISP1_CIF_ISP_LSC_STATUS);
>
>@@ -258,7 +259,8 @@ rkisp1_lsc_matrix_config_v12(struct rkisp1_params *params,
> const struct rkisp1_cif_isp_lsc_config *pconfig)
> {
> struct rkisp1_device *rkisp1 = params->rkisp1;
>- unsigned int lsc_status, sram_addr, lsc_table_sel, i, j;
>+ u32 lsc_status, sram_addr, lsc_table_sel;
>+ unsigned int i, j;
>
> lsc_status = rkisp1_read(rkisp1, RKISP1_CIF_ISP_LSC_STATUS);
>
>@@ -316,8 +318,8 @@ static void rkisp1_lsc_config(struct rkisp1_params *params,
> const struct rkisp1_cif_isp_lsc_config *arg)
> {
> struct rkisp1_device *rkisp1 = params->rkisp1;
>- unsigned int i, data;
>- u32 lsc_ctrl;
>+ u32 lsc_ctrl, data;
>+ unsigned int i;
>
> /* To config must be off , store the current status firstly */
> lsc_ctrl = rkisp1_read(rkisp1, RKISP1_CIF_ISP_LSC_CTRL);
>--
>Regards,
>
>Laurent Pinchart
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2022-08-18 2:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 2:18 [PATCH 0/5] media: rkisp1: Fix LSC initial configuration on i.MX8MP Laurent Pinchart
2022-08-17 2:18 ` [PATCH 1/5] media: rkisp1: Clean up LSC configuration code Laurent Pinchart
2022-08-18 2:32 ` Dafna Hirschfeld
2022-08-17 2:18 ` [PATCH 2/5] media: rkisp1: Store LSC register values in u32 variables Laurent Pinchart
2022-08-18 2:37 ` Dafna Hirschfeld [this message]
2022-08-17 2:18 ` [PATCH 3/5] media: rkisp1: Simplify LSC x/y size and grad register macros Laurent Pinchart
2022-08-18 2:39 ` Dafna Hirschfeld
2022-08-17 2:18 ` [PATCH 4/5] media: rkisp1: Use RKISP1_CIF_ISP_LSC_GRAD_SIZE() for gradient registers Laurent Pinchart
2022-08-18 2:50 ` Dafna Hirschfeld
2022-08-18 6:17 ` Laurent Pinchart
2022-08-23 17:21 ` [PATCH v1.1 4/5] media: rkisp1: Use correct macro " Laurent Pinchart
2022-08-26 19:06 ` Dafna Hirschfeld
2022-08-17 2:18 ` [PATCH 5/5] media: rkisp1: Configure LSC after enabling the ISP Laurent Pinchart
2022-08-18 3:45 ` Dafna Hirschfeld
2022-08-18 6:25 ` Laurent Pinchart
2022-08-22 17:08 ` Dafna Hirschfeld
2022-08-23 17:21 ` [PATCH v1.1 " Laurent Pinchart
2022-09-03 3:09 ` Dafna Hirschfeld
2022-09-03 20:39 ` Laurent Pinchart
2022-09-03 21:01 ` [PATCH v1.2 " Laurent Pinchart
2022-09-04 13:12 ` Dafna Hirschfeld
2022-09-02 9:07 ` [PATCH 0/5] media: rkisp1: Fix LSC initial configuration on i.MX8MP Dafna Hirschfeld
2022-09-02 10:07 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818023733.yckej5xyfsbc4btb@guri \
--to=dafna@fastmail.com \
--cc=fsylvestre@baylibre.com \
--cc=heiko@sntech.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=paul.elder@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox