public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Dafna Hirschfeld <dafna@fastmail.com>
Cc: linux-media@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
	linux-rockchip@lists.infradead.org,
	Paul Elder <paul.elder@ideasonboard.com>,
	Florian Sylvestre <fsylvestre@baylibre.com>
Subject: Re: [PATCH 4/5] media: rkisp1: Use RKISP1_CIF_ISP_LSC_GRAD_SIZE() for gradient registers
Date: Thu, 18 Aug 2022 09:17:42 +0300	[thread overview]
Message-ID: <Yv3ZhsIqWSu4wT4m@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220818025029.y4jbmpzgnebla4t2@guri>

Hi Dafna,

On Thu, Aug 18, 2022 at 05:50:29AM +0300, Dafna Hirschfeld wrote:
> On 17.08.2022 05:18, Laurent Pinchart wrote:
> > The rkisp1_lsc_config() function incorrectly uses the
> > RKISP1_CIF_ISP_LSC_SECT_SIZE() macro for the gradient registers. Replace
> > it with the correct RKISP1_CIF_ISP_LSC_GRAD_SIZE() macro. This doesn't
> > cause any functional change as the two macros are defined identically
> > (the size and gradient registers store fields in the same number of bits
> > at the same positions).
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> >  drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> > index aa6efa4c6e9e..421ade177b2d 100644
> > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> > @@ -334,7 +334,7 @@ static void rkisp1_lsc_config(struct rkisp1_params *params,
> >  		rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_XSIZE(i), data);
> > 
> >  		/* program x grad tables */
> > -		data = RKISP1_CIF_ISP_LSC_SECT_SIZE(arg->x_grad_tbl[i * 2],
> > +		data = RKISP1_CIF_ISP_LSC_GRAD_SIZE(arg->x_grad_tbl[i * 2],
> >  						    arg->x_grad_tbl[i * 2 + 1]);
> 
> maybe the GRAD macro should change to:
> 
> RKISP1_CIF_ISP_LSC_SECT_GRAD
> 
> ?

Good idea, I'll do that.

> >  		rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_XGRAD(i), data);
> > 
> > @@ -344,7 +344,7 @@ static void rkisp1_lsc_config(struct rkisp1_params *params,
> >  		rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_YSIZE(i), data);
> > 
> >  		/* program y grad tables */
> > -		data = RKISP1_CIF_ISP_LSC_SECT_SIZE(arg->y_grad_tbl[i * 2],
> > +		data = RKISP1_CIF_ISP_LSC_GRAD_SIZE(arg->y_grad_tbl[i * 2],
> >  						    arg->y_grad_tbl[i * 2 + 1]);
> >  		rkisp1_write(rkisp1, RKISP1_CIF_ISP_LSC_YGRAD(i), data);
> >  	}

-- 
Regards,

Laurent Pinchart

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2022-08-18  6:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17  2:18 [PATCH 0/5] media: rkisp1: Fix LSC initial configuration on i.MX8MP Laurent Pinchart
2022-08-17  2:18 ` [PATCH 1/5] media: rkisp1: Clean up LSC configuration code Laurent Pinchart
2022-08-18  2:32   ` Dafna Hirschfeld
2022-08-17  2:18 ` [PATCH 2/5] media: rkisp1: Store LSC register values in u32 variables Laurent Pinchart
2022-08-18  2:37   ` Dafna Hirschfeld
2022-08-17  2:18 ` [PATCH 3/5] media: rkisp1: Simplify LSC x/y size and grad register macros Laurent Pinchart
2022-08-18  2:39   ` Dafna Hirschfeld
2022-08-17  2:18 ` [PATCH 4/5] media: rkisp1: Use RKISP1_CIF_ISP_LSC_GRAD_SIZE() for gradient registers Laurent Pinchart
2022-08-18  2:50   ` Dafna Hirschfeld
2022-08-18  6:17     ` Laurent Pinchart [this message]
2022-08-23 17:21   ` [PATCH v1.1 4/5] media: rkisp1: Use correct macro " Laurent Pinchart
2022-08-26 19:06     ` Dafna Hirschfeld
2022-08-17  2:18 ` [PATCH 5/5] media: rkisp1: Configure LSC after enabling the ISP Laurent Pinchart
2022-08-18  3:45   ` Dafna Hirschfeld
2022-08-18  6:25     ` Laurent Pinchart
2022-08-22 17:08       ` Dafna Hirschfeld
2022-08-23 17:21   ` [PATCH v1.1 " Laurent Pinchart
2022-09-03  3:09     ` Dafna Hirschfeld
2022-09-03 20:39       ` Laurent Pinchart
2022-09-03 21:01     ` [PATCH v1.2 " Laurent Pinchart
2022-09-04 13:12       ` Dafna Hirschfeld
2022-09-02  9:07 ` [PATCH 0/5] media: rkisp1: Fix LSC initial configuration on i.MX8MP Dafna Hirschfeld
2022-09-02 10:07   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv3ZhsIqWSu4wT4m@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dafna@fastmail.com \
    --cc=fsylvestre@baylibre.com \
    --cc=heiko@sntech.de \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=paul.elder@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox