* [PATCH v5 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes [not found] <20220822184701.25246-1-Sergey.Semin@baikalelectronics.ru> @ 2022-08-22 18:46 ` Serge Semin 2022-08-31 21:26 ` Rob Herring 0 siblings, 1 reply; 3+ messages in thread From: Serge Semin @ 2022-08-22 18:46 UTC (permalink / raw) To: Rob Herring, Rob Herring, Krzysztof Kozlowski, Bjorn Helgaas, Lorenzo Pieralisi, Jingoo Han, Gustavo Pimentel, Heiko Stuebner, Shawn Lin, Simon Xue Cc: Serge Semin, Serge Semin, Alexey Malahov, Pavel Parkhomenko, Krzysztof Wilczyński, Frank Li, Manivannan Sadhasivam, linux-pci, devicetree, linux-kernel, linux-arm-kernel, linux-rockchip As the DT-bindings description states the Rockchip PCIe controller is based on the DW PCIe RP IP-core thus its DT-nodes are supposed to be compatible with the common DW PCIe controller schema. Let's make sure they are evaluated against it by referring to the snps,dw-pcie.yaml schema in the allOf sub-schemas composition. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> --- Changelog v3: - This is a new patch created on v3 lap of the series. Changelog v5: - Apply snps,dw-pcie.yaml instead of the snps,dw-pcie-common.yaml schema. --- Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml index bc0a9d1db750..2be72ae1169f 100644 --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml @@ -14,10 +14,10 @@ maintainers: description: |+ RK3568 SoC PCIe host controller is based on the Synopsys DesignWare PCIe IP and thus inherits all the common properties defined in - designware-pcie.txt. + snps,dw-pcie.yaml. allOf: - - $ref: /schemas/pci/pci-bus.yaml# + - $ref: /schemas/pci/snps,dw-pcie.yaml# properties: compatible: -- 2.35.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v5 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes 2022-08-22 18:46 ` [PATCH v5 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes Serge Semin @ 2022-08-31 21:26 ` Rob Herring 2022-09-11 19:09 ` Serge Semin 0 siblings, 1 reply; 3+ messages in thread From: Rob Herring @ 2022-08-31 21:26 UTC (permalink / raw) To: Serge Semin Cc: Krzysztof Kozlowski, Bjorn Helgaas, Lorenzo Pieralisi, Jingoo Han, Gustavo Pimentel, Heiko Stuebner, Shawn Lin, Simon Xue, Serge Semin, Alexey Malahov, Pavel Parkhomenko, Krzysztof Wilczyński, Frank Li, Manivannan Sadhasivam, linux-pci, devicetree, linux-kernel, linux-arm-kernel, linux-rockchip On Mon, Aug 22, 2022 at 09:46:54PM +0300, Serge Semin wrote: > As the DT-bindings description states the Rockchip PCIe controller is > based on the DW PCIe RP IP-core thus its DT-nodes are supposed to be > compatible with the common DW PCIe controller schema. Let's make sure they > are evaluated against it by referring to the snps,dw-pcie.yaml schema in > the allOf sub-schemas composition. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > --- > > Changelog v3: > - This is a new patch created on v3 lap of the series. > > Changelog v5: > - Apply snps,dw-pcie.yaml instead of the snps,dw-pcie-common.yaml schema. > --- > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Shouldn't this come before/after patch 7? Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes 2022-08-31 21:26 ` Rob Herring @ 2022-09-11 19:09 ` Serge Semin 0 siblings, 0 replies; 3+ messages in thread From: Serge Semin @ 2022-09-11 19:09 UTC (permalink / raw) To: Rob Herring Cc: Serge Semin, Krzysztof Kozlowski, Bjorn Helgaas, Lorenzo Pieralisi, Jingoo Han, Gustavo Pimentel, Heiko Stuebner, Shawn Lin, Simon Xue, Alexey Malahov, Pavel Parkhomenko, Krzysztof Wilczyński, Frank Li, Manivannan Sadhasivam, linux-pci, devicetree, linux-kernel, linux-arm-kernel, linux-rockchip On Wed, Aug 31, 2022 at 04:26:31PM -0500, Rob Herring wrote: > On Mon, Aug 22, 2022 at 09:46:54PM +0300, Serge Semin wrote: > > As the DT-bindings description states the Rockchip PCIe controller is > > based on the DW PCIe RP IP-core thus its DT-nodes are supposed to be > > compatible with the common DW PCIe controller schema. Let's make sure they > > are evaluated against it by referring to the snps,dw-pcie.yaml schema in > > the allOf sub-schemas composition. > > > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > > > --- > > > > Changelog v3: > > - This is a new patch created on v3 lap of the series. > > > > Changelog v5: > > - Apply snps,dw-pcie.yaml instead of the snps,dw-pcie-common.yaml schema. > > --- > > Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Shouldn't this come before/after patch 7? It must be applied after the patch [PATCH v5 11/20] dt-bindings: PCI: dwc: Add clocks/resets common properties and after the rest of the resource-related patches submitted before that one. -Sergey > > Reviewed-by: Rob Herring <robh@kernel.org> _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-11 19:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220822184701.25246-1-Sergey.Semin@baikalelectronics.ru>
2022-08-22 18:46 ` [PATCH v5 13/20] dt-bindings: PCI: dwc: Apply common schema to Rockchip DW PCIe nodes Serge Semin
2022-08-31 21:26 ` Rob Herring
2022-09-11 19:09 ` Serge Semin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox