From: Conor Dooley <conor.dooley@microchip.com>
To: zhangqing <zhangqing@rock-chips.com>
Cc: Conor Dooley <conor@kernel.org>, <mturquette@baylibre.com>,
<sboyd@kernel.org>, <kever.yang@rock-chips.com>,
<heiko@sntech.de>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-clk@vger.kernel.org>, <linux-rockchip@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <huangtao@rock-chips.com>,
<andy.yan@rock-chips.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH v5 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id
Date: Thu, 9 Nov 2023 07:29:13 +0000 [thread overview]
Message-ID: <20231109-send-pushchair-45b37551102a@wendy> (raw)
In-Reply-To: <2e520a06-0ff1-76ef-2a72-ab6663738b45@rock-chips.com>
[-- Attachment #1.1: Type: text/plain, Size: 1433 bytes --]
On Thu, Nov 09, 2023 at 02:27:38PM +0800, zhangqing wrote:
> Hi:
>
> 在 2023/11/8 20:01, Conor Dooley 写道:
> > On Wed, Nov 08, 2023 at 02:18:21PM +0800, Elaine Zhang wrote:
> > > export PCLK_VO1GRF for DT.
> > >
> > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> > > ---
> > > include/dt-bindings/clock/rockchip,rk3588-cru.h | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > > index 5790b1391201..50ba72980190 100644
> > > --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > > +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> > > @@ -733,8 +733,9 @@
> > > #define ACLK_AV1_PRE 718
> > > #define PCLK_AV1_PRE 719
> > > #define HCLK_SDIO_PRE 720
> > > +#define PCLK_VO1GRF 721
> > > -#define CLK_NR_CLKS (HCLK_SDIO_PRE + 1)
> > > +#define CLK_NR_CLKS (PCLK_VO1GRF + 1)
> > This definition is part of the ABI, if it is safe to change it, then it
> > is safe to delete it.
> The new ID is to solve the niu clock dependency problem(Used in PATCH V5
> 4/4).This new ID will also be used in DTS in the future.
>
> CLK_NR_CLKS represents the number of clocks used by the
> drivers/clk/rockchip/clk-rkxxx.c. It is safe to modify it, but cannot delete
> it.
Then delete it from the header and move it to clk-rkxxx.c
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-11-09 7:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 6:18 [PATCH v5 0/4] rockchip: add GATE_LINK Elaine Zhang
2023-11-08 6:18 ` [PATCH v5 1/4] clk: gate: export clk_gate_endisable Elaine Zhang
2023-11-08 6:18 ` [PATCH v5 2/4] clk: rockchip: add support for gate link Elaine Zhang
2023-11-08 6:18 ` [PATCH v5 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk id Elaine Zhang
2023-11-08 12:01 ` Conor Dooley
2023-11-08 12:12 ` Krzysztof Kozlowski
2023-11-09 6:27 ` zhangqing
2023-11-09 7:29 ` Conor Dooley [this message]
2023-11-09 8:06 ` zhangqing
2023-11-09 9:21 ` Krzysztof Kozlowski
2023-11-09 10:05 ` zhangqing
2023-11-09 10:24 ` Krzysztof Kozlowski
2023-11-10 1:23 ` zhangqing
2023-11-10 18:07 ` Conor Dooley
2023-11-08 6:18 ` [PATCH v5 4/4] clk: rockchip: rk3588: Adjust the GATE_LINK parameter Elaine Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231109-send-pushchair-45b37551102a@wendy \
--to=conor.dooley@microchip.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=kever.yang@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox