[PATCH 1/2] arm64: dts: rockchip: support poweroff on rock-5b

[PATCH 1/2] arm64: dts: rockchip: support poweroff on rock-5b

[John Clark]

Allow the rock-5b to poweroff its pmic.

related: c699fbfdfd54630fc51b96da577f02e7b772eb37

Signed-off-by: John Clark <inindev@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 74719aaf697c..dc7b88f29172 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -426,6 +426,8 @@ pmic@0 {
 		pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
 			    <&rk806_dvs2_null>, <&rk806_dvs3_null>;
 
+		system-power-controller;
+
 		vcc1-supply = <&vcc5v0_sys>;
 		vcc2-supply = <&vcc5v0_sys>;
 		vcc3-supply = <&vcc5v0_sys>;
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

[PATCH 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo

[John Clark]

Signed-off-by: John Clark <inindev@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index dc7b88f29172..a0e303c3a1dc 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -448,7 +448,7 @@ pmic@0 {
 		#gpio-cells = <2>;
 
 		rk806_dvs1_null: dvs1-null-pins {
-			pins = "gpio_pwrctrl2";
+			pins = "gpio_pwrctrl1";
 			function = "pin_fun0";
 		};
 
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo

[Krzysztof Kozlowski]

On 25/12/2023 10:08, John Clark wrote:
> Signed-off-by: John Clark <inindev@gmail.com>
> ---

Same problems.

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH 1/2] arm64: dts: rockchip: support poweroff on rock-5b

[Krzysztof Kozlowski]

On 25/12/2023 10:08, John Clark wrote:
> Allow the rock-5b to poweroff its pmic.
> 
> related: c699fbfdfd54630fc51b96da577f02e7b772eb37

Reference commits how checkpatch and submitting-patches ask - commit foo
("bar") and explain what is "related".

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH 1/2] arm64: dts: rockchip: support poweroff on rock-5b

[John Clark]

On 12/25/23 4:19 AM, Krzysztof Kozlowski wrote:
> On 25/12/2023 10:08, John Clark wrote:
>> Allow the rock-5b to poweroff its pmic.
>>
>> related: c699fbfdfd54630fc51b96da577f02e7b772eb37
> Reference commits how checkpatch and submitting-patches ask - commit foo
> ("bar") and explain what is "related".
>
> Best regards,
> Krzysztof
>
When issuing a "shutdown -h now" on the rock-5b it reboots instead.  
Using the 'system-power-controller' allows the rk806 to power down instead.


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH 1/2] arm64: dts: rockchip: support poweroff on rock-5b

[Krzysztof Kozlowski]

On 25/12/2023 10:26, John Clark wrote:
> On 12/25/23 4:19 AM, Krzysztof Kozlowski wrote:
>> On 25/12/2023 10:08, John Clark wrote:
>>> Allow the rock-5b to poweroff its pmic.
>>>
>>> related: c699fbfdfd54630fc51b96da577f02e7b772eb37
>> Reference commits how checkpatch and submitting-patches ask - commit foo
>> ("bar") and explain what is "related".
>>
>> Best regards,
>> Krzysztof
>>
> When issuing a "shutdown -h now" on the rock-5b it reboots instead.  
> Using the 'system-power-controller' allows the rk806 to power down instead.

I meant, explain in the commit msg.

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

[PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b

[John Clark]

Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on
the rock-5b it reboots instead.  Using the 'system-power-controller' allows
the rk806 to power down instead.

Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this
issue for the nanopc-t6.

Signed-off-by: John Clark <inindev@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 74719aaf697c..dc7b88f29172 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -426,6 +426,8 @@ pmic@0 {
 		pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
 			    <&rk806_dvs2_null>, <&rk806_dvs3_null>;
 
+		system-power-controller;
+
 		vcc1-supply = <&vcc5v0_sys>;
 		vcc2-supply = <&vcc5v0_sys>;
 		vcc3-supply = <&vcc5v0_sys>;
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

[PATCH 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo

[John Clark]

gpio_pwrctrl2 is duplicated twice and gpio_pwrctrl1 is not set.
Set gpio_pwrctrl1.

Signed-off-by: John Clark <inindev@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index dc7b88f29172..a0e303c3a1dc 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -448,7 +448,7 @@ pmic@0 {
 		#gpio-cells = <2>;
 
 		rk806_dvs1_null: dvs1-null-pins {
-			pins = "gpio_pwrctrl2";
+			pins = "gpio_pwrctrl1";
 			function = "pin_fun0";
 		};
 
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b

[Krzysztof Kozlowski]

On 25/12/2023 11:20, John Clark wrote:
> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on
> the rock-5b it reboots instead.  Using the 'system-power-controller' allows
> the rk806 to power down instead.
> 
> Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this
> issue for the nanopc-t6.

That's not the syntax I asked for. Where is its subject? Syntax is:
commit foo ("subject"), respecting the length of SHA, as checked by
checkpatch.

You still miss v2 and changelog. I also wrote about this. b4 does it for
you, but if you decide to use git manually, then you have to add it.

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b

[John Clark]

On 12/25/23 5:43 AM, Krzysztof Kozlowski wrote:
> On 25/12/2023 11:20, John Clark wrote:
>> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on
>> the rock-5b it reboots instead.  Using the 'system-power-controller' allows
>> the rk806 to power down instead.
>>
>> Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this
>> issue for the nanopc-t6.
> That's not the syntax I asked for. Where is its subject? Syntax is:
> commit foo ("subject"), respecting the length of SHA, as checked by
> checkpatch.
>
> You still miss v2 and changelog. I also wrote about this. b4 does it for
> you, but if you decide to use git manually, then you have to add it.
>
> Best regards,
> Krzysztof
>
The documentation for  --in-reply-to=<identifier> clearly states that it 
will generate the v2 semantics for the subject, yet it did not.  I used 
the message-id from the first message since it was a two email patch to 
begin with.  It is not clear to me why this did not happen.  I will see 
if I can find a sandbox to practice my get-send-email skills in.



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH 1/2] arm64: dts: rockchip: support poweroff on the rock-5b

[Krzysztof Kozlowski]

On 25/12/2023 11:51, John Clark wrote:
> On 12/25/23 5:43 AM, Krzysztof Kozlowski wrote:
>> On 25/12/2023 11:20, John Clark wrote:
>>> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now" on
>>> the rock-5b it reboots instead.  Using the 'system-power-controller' allows
>>> the rk806 to power down instead.
>>>
>>> Commit c699fbfdfd54630fc51b96da577f02e7b772eb37 similarly resolves this
>>> issue for the nanopc-t6.
>> That's not the syntax I asked for. Where is its subject? Syntax is:
>> commit foo ("subject"), respecting the length of SHA, as checked by
>> checkpatch.
>>
>> You still miss v2 and changelog. I also wrote about this. b4 does it for
>> you, but if you decide to use git manually, then you have to add it.
>>
>> Best regards,
>> Krzysztof
>>
> The documentation for  --in-reply-to=<identifier> clearly states that it 

No, it does not state that.

> will generate the v2 semantics for the subject, yet it did not.  I used 

Because it doesn't...

> the message-id from the first message since it was a two email patch to 

Which you should not. Each submission is its own thread, which is
already expressed:

https://elixir.bootlin.com/linux/v6.7-rc7/source/Documentation/process/submitting-patches.rst#L782

> begin with.  It is not clear to me why this did not happen.  I will see 
> if I can find a sandbox to practice my get-send-email skills in.


Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip