* [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b
@ 2023-12-25 22:28 John Clark
2023-12-25 22:28 ` [PATCH v2 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo John Clark
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: John Clark @ 2023-12-25 22:28 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
linux-rockchip
Cc: Thomas McKahan, devicetree, linux-arm-kernel, linux-kernel,
John Clark
Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now"
on the rock-5b it reboots instead. Defining 'system-power-controller'
allows the rk806 to power down.
Commit c699fbfdfd54 ("arm64: dts: rockchip: Support poweroff on
NanoPC-T6") similarly resolves this issue for the nanopc-t6.
Signed-off-by: John Clark <inindev@gmail.com>
---
Changes since v1:
- added commit message with additional patch detail
- expressed the related commit using checkpatch
---
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 74719aaf697c..dc7b88f29172 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -426,6 +426,8 @@ pmic@0 {
pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
<&rk806_dvs2_null>, <&rk806_dvs3_null>;
+ system-power-controller;
+
vcc1-supply = <&vcc5v0_sys>;
vcc2-supply = <&vcc5v0_sys>;
vcc3-supply = <&vcc5v0_sys>;
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo
2023-12-25 22:28 [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b John Clark
@ 2023-12-25 22:28 ` John Clark
2023-12-27 0:16 ` Sebastian Reichel
2023-12-27 0:16 ` [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b Sebastian Reichel
2023-12-29 22:55 ` Heiko Stuebner
2 siblings, 1 reply; 5+ messages in thread
From: John Clark @ 2023-12-25 22:28 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
linux-rockchip
Cc: Thomas McKahan, devicetree, linux-arm-kernel, linux-kernel,
John Clark
Both rk806_dvs1_null and rk806_dvs2_null duplicate gpio_pwrctrl2 and
gpio_pwrctrl1 is not set. This patch sets gpio_pwrctrl1.
Signed-off-by: John Clark <inindev@gmail.com>
---
Changes since v1:
- added commit message with additional patch detail
---
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index dc7b88f29172..a0e303c3a1dc 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -448,7 +448,7 @@ pmic@0 {
#gpio-cells = <2>;
rk806_dvs1_null: dvs1-null-pins {
- pins = "gpio_pwrctrl2";
+ pins = "gpio_pwrctrl1";
function = "pin_fun0";
};
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo
2023-12-25 22:28 ` [PATCH v2 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo John Clark
@ 2023-12-27 0:16 ` Sebastian Reichel
0 siblings, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2023-12-27 0:16 UTC (permalink / raw)
To: John Clark
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
linux-rockchip, Thomas McKahan, devicetree, linux-arm-kernel,
linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1051 bytes --]
Hi,
On Mon, Dec 25, 2023 at 10:28:20PM +0000, John Clark wrote:
> Both rk806_dvs1_null and rk806_dvs2_null duplicate gpio_pwrctrl2 and
> gpio_pwrctrl1 is not set. This patch sets gpio_pwrctrl1.
>
> Signed-off-by: John Clark <inindev@gmail.com>
> ---
> Changes since v1:
> - added commit message with additional patch detail
>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index dc7b88f29172..a0e303c3a1dc 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -448,7 +448,7 @@ pmic@0 {
> #gpio-cells = <2>;
>
> rk806_dvs1_null: dvs1-null-pins {
> - pins = "gpio_pwrctrl2";
> + pins = "gpio_pwrctrl1";
> function = "pin_fun0";
> };
>
> --
> 2.43.0
>
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b
2023-12-25 22:28 [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b John Clark
2023-12-25 22:28 ` [PATCH v2 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo John Clark
@ 2023-12-27 0:16 ` Sebastian Reichel
2023-12-29 22:55 ` Heiko Stuebner
2 siblings, 0 replies; 5+ messages in thread
From: Sebastian Reichel @ 2023-12-27 0:16 UTC (permalink / raw)
To: John Clark
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
linux-rockchip, Thomas McKahan, devicetree, linux-arm-kernel,
linux-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1349 bytes --]
Hi,
On Mon, Dec 25, 2023 at 10:28:19PM +0000, John Clark wrote:
> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now"
> on the rock-5b it reboots instead. Defining 'system-power-controller'
> allows the rk806 to power down.
>
> Commit c699fbfdfd54 ("arm64: dts: rockchip: Support poweroff on
> NanoPC-T6") similarly resolves this issue for the nanopc-t6.
>
> Signed-off-by: John Clark <inindev@gmail.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> Changes since v1:
> - added commit message with additional patch detail
> - expressed the related commit using checkpatch
>
> ---
> arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 74719aaf697c..dc7b88f29172 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -426,6 +426,8 @@ pmic@0 {
> pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
> <&rk806_dvs2_null>, <&rk806_dvs3_null>;
>
> + system-power-controller;
> +
> vcc1-supply = <&vcc5v0_sys>;
> vcc2-supply = <&vcc5v0_sys>;
> vcc3-supply = <&vcc5v0_sys>;
> --
> 2.43.0
>
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b
2023-12-25 22:28 [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b John Clark
2023-12-25 22:28 ` [PATCH v2 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo John Clark
2023-12-27 0:16 ` [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b Sebastian Reichel
@ 2023-12-29 22:55 ` Heiko Stuebner
2 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2023-12-29 22:55 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, John Clark, Conor Dooley,
linux-rockchip
Cc: Heiko Stuebner, linux-arm-kernel, Thomas McKahan, linux-kernel,
devicetree
On Mon, 25 Dec 2023 22:28:19 +0000, John Clark wrote:
> Allow the rock-5b to poweroff its pmic. When issuing a "shutdown -h now"
> on the rock-5b it reboots instead. Defining 'system-power-controller'
> allows the rk806 to power down.
>
> Commit c699fbfdfd54 ("arm64: dts: rockchip: Support poweroff on
> NanoPC-T6") similarly resolves this issue for the nanopc-t6.
>
> [...]
Applied, thanks!
[1/2] arm64: dts: rockchip: support poweroff on the rock-5b
commit: 7738f551173540b3daa63a91b384b167eacd24fd
[2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo
commit: aed6514c4e3aee843385ded4c5ee0921b51c30fa
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-29 22:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-25 22:28 [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b John Clark
2023-12-25 22:28 ` [PATCH v2 2/2] arm64: dts: rockchip: correct gpio_pwrctrl1 typo John Clark
2023-12-27 0:16 ` Sebastian Reichel
2023-12-27 0:16 ` [PATCH v2 1/2] arm64: dts: rockchip: support poweroff on the rock-5b Sebastian Reichel
2023-12-29 22:55 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox