* [PATCH] arm64: dts: rockchip: make USB gadget functions usable on Radxa ROCK 3C
@ 2024-08-02 4:25 FUKAUMI Naoki
2024-08-02 23:14 ` FUKAUMI Naoki
0 siblings, 1 reply; 2+ messages in thread
From: FUKAUMI Naoki @ 2024-08-02 4:25 UTC (permalink / raw)
To: heiko; +Cc: amadeus, linux-rockchip, FUKAUMI Naoki
Radxa ROCK 3A and 3B use a USB 3.0 Type-A OTG port as "otg" mode for
USB gadget functions.
Radxa ROCK 3C also has a USB 2.0 Type-A OTG port, it should be "otg"
mode for USB gadget functions.
Fixes: ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
index f2cc086e5001..a9535eaa5235 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
@@ -664,7 +664,6 @@ &usb_host0_ohci {
};
&usb_host0_xhci {
- dr_mode = "host";
status = "okay";
};
--
2.43.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm64: dts: rockchip: make USB gadget functions usable on Radxa ROCK 3C
2024-08-02 4:25 [PATCH] arm64: dts: rockchip: make USB gadget functions usable on Radxa ROCK 3C FUKAUMI Naoki
@ 2024-08-02 23:14 ` FUKAUMI Naoki
0 siblings, 0 replies; 2+ messages in thread
From: FUKAUMI Naoki @ 2024-08-02 23:14 UTC (permalink / raw)
To: heiko; +Cc: amadeus, linux-rockchip
hi,
please don't merge this for a while.
I'm thinking opposite change may be better to align with ROCK 4/5
series. (OTG port is "host")
any comment?
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
On 8/2/24 13:25, FUKAUMI Naoki wrote:
> Radxa ROCK 3A and 3B use a USB 3.0 Type-A OTG port as "otg" mode for
> USB gadget functions.
>
> Radxa ROCK 3C also has a USB 2.0 Type-A OTG port, it should be "otg"
> mode for USB gadget functions.
>
> Fixes: ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
> index f2cc086e5001..a9535eaa5235 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
> @@ -664,7 +664,6 @@ &usb_host0_ohci {
> };
>
> &usb_host0_xhci {
> - dr_mode = "host";
> status = "okay";
> };
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-02 23:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-02 4:25 [PATCH] arm64: dts: rockchip: make USB gadget functions usable on Radxa ROCK 3C FUKAUMI Naoki
2024-08-02 23:14 ` FUKAUMI Naoki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox