* [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s
@ 2024-10-22 19:35 Tianling Shen
2024-10-22 19:35 ` [PATCH 1/5] arm64: dts: rockchip: fix model name for FriendlyElec NanoPi R3S Tianling Shen
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Tianling Shen @ 2024-10-22 19:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jonas Karlman, Andy Yan, Jagan Teki, Tianling Shen
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
* Enable eMMC HS200 mode to allow it boot from eMMC
* Sort properties in pmu_io_domains node
* Reorder mmc aliases
* Replace deprecated snps,reset properties
* Use the marketing name for the model name
* Update the website url in copyright
Thanks Jonas Karlman for the review and suggestions :)
Tianling Shen (5):
arm64: dts: rockchip: fix model name for FriendlyElec NanoPi R3S
arm64: dts: rockchip: replace deprecated snps,reset props for NanoPi
R3S
arm64: dts: rockchip: sort props in pmu_io_domains node for NanoPi R3S
arm64: dts: rockchip: enable eMMC HS200 mode for NanoPi R3S
arm64: dts: rockchip: reorder mmc aliases for NanoPi R3S
.../boot/dts/rockchip/rk3566-nanopi-r3s.dts | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
--
2.47.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/5] arm64: dts: rockchip: fix model name for FriendlyElec NanoPi R3S
2024-10-22 19:35 [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s Tianling Shen
@ 2024-10-22 19:35 ` Tianling Shen
2024-10-22 19:35 ` [PATCH 2/5] arm64: dts: rockchip: replace deprecated snps,reset props for " Tianling Shen
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Tianling Shen @ 2024-10-22 19:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jonas Karlman, Andy Yan, Jagan Teki, Tianling Shen
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Use the marketing name for model name, this matches the dt-binding.
Also update the website url in copyright.
Fixes: 50decd493c83 ("arm64: dts: rockchip: Add FriendlyARM NanoPi R3S board")
Suggested-by: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
index a7a55d68dbb6..6bc17f755b79 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
@@ -3,7 +3,7 @@
* Copyright (c) 2020 Rockchip Electronics Co., Ltd.
*
* Copyright (c) 2024 FriendlyElec Computer Tech. Co., Ltd.
- * (http://www.friendlyarm.com)
+ * (http://www.friendlyelec.com)
*
* Copyright (c) 2024 Tianling Shen <cnsztl@gmail.com>
*/
@@ -17,7 +17,7 @@
#include "rk3566.dtsi"
/ {
- model = "FriendlyARM NanoPi R3S";
+ model = "FriendlyElec NanoPi R3S";
compatible = "friendlyarm,nanopi-r3s", "rockchip,rk3566";
aliases {
--
2.47.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/5] arm64: dts: rockchip: replace deprecated snps,reset props for NanoPi R3S
2024-10-22 19:35 [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s Tianling Shen
2024-10-22 19:35 ` [PATCH 1/5] arm64: dts: rockchip: fix model name for FriendlyElec NanoPi R3S Tianling Shen
@ 2024-10-22 19:35 ` Tianling Shen
2024-10-22 19:35 ` [PATCH 3/5] arm64: dts: rockchip: sort props in pmu_io_domains node " Tianling Shen
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Tianling Shen @ 2024-10-22 19:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jonas Karlman, Andy Yan, Jagan Teki, Tianling Shen
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Replace deprecated snps,reset props and move them to the PHY node.
Fixes: 50decd493c83 ("arm64: dts: rockchip: Add FriendlyARM NanoPi R3S board")
Suggested-by: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
index 6bc17f755b79..66a00cddda0c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
@@ -149,10 +149,6 @@ &gmac1m0_tx_bus2_level3
&gmac1m0_rx_bus2
&gmac1m0_rgmii_clk_level2
&gmac1m0_rgmii_bus_level3>;
- snps,reset-gpio = <&gpio4 RK_PC2 GPIO_ACTIVE_LOW>;
- snps,reset-active-low;
- /* Reset time is 20ms, 100ms for rtl8211f */
- snps,reset-delays-us = <0 20000 100000>;
status = "okay";
};
@@ -414,6 +410,9 @@ rgmii_phy1: ethernet-phy@1 {
interrupts = <RK_PC3 IRQ_TYPE_LEVEL_LOW>;
pinctrl-names = "default";
pinctrl-0 = <ð_phy_reset_pin>;
+ reset-assert-us = <20000>;
+ reset-deassert-us = <100000>;
+ reset-gpios = <&gpio4 RK_PC2 GPIO_ACTIVE_LOW>;
};
};
--
2.47.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/5] arm64: dts: rockchip: sort props in pmu_io_domains node for NanoPi R3S
2024-10-22 19:35 [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s Tianling Shen
2024-10-22 19:35 ` [PATCH 1/5] arm64: dts: rockchip: fix model name for FriendlyElec NanoPi R3S Tianling Shen
2024-10-22 19:35 ` [PATCH 2/5] arm64: dts: rockchip: replace deprecated snps,reset props for " Tianling Shen
@ 2024-10-22 19:35 ` Tianling Shen
2024-10-22 19:35 ` [PATCH 4/5] arm64: dts: rockchip: enable eMMC HS200 mode " Tianling Shen
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Tianling Shen @ 2024-10-22 19:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jonas Karlman, Andy Yan, Jagan Teki, Tianling Shen
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
The status prop is typically the last prop.
Fixes: 50decd493c83 ("arm64: dts: rockchip: Add FriendlyARM NanoPi R3S board")
Suggested-by: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
index 66a00cddda0c..243574f8da78 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
@@ -476,7 +476,6 @@ vcc5v0_usb_host_en: vcc5v0-usb-host-en {
};
&pmu_io_domains {
- status = "okay";
pmuio1-supply = <&vcc3v3_pmu>;
pmuio2-supply = <&vcc3v3_pmu>;
vccio1-supply = <&vccio_acodec>;
@@ -486,6 +485,7 @@ &pmu_io_domains {
vccio5-supply = <&vcc_1v8>;
vccio6-supply = <&vcc_3v3>;
vccio7-supply = <&vcc_3v3>;
+ status = "okay";
};
&sdhci {
--
2.47.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 4/5] arm64: dts: rockchip: enable eMMC HS200 mode for NanoPi R3S
2024-10-22 19:35 [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s Tianling Shen
` (2 preceding siblings ...)
2024-10-22 19:35 ` [PATCH 3/5] arm64: dts: rockchip: sort props in pmu_io_domains node " Tianling Shen
@ 2024-10-22 19:35 ` Tianling Shen
2024-10-22 19:35 ` [PATCH 5/5] arm64: dts: rockchip: reorder mmc aliases " Tianling Shen
2024-10-24 8:30 ` [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s Heiko Stuebner
5 siblings, 0 replies; 7+ messages in thread
From: Tianling Shen @ 2024-10-22 19:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jonas Karlman, Andy Yan, Jagan Teki, Tianling Shen
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
It is required to boot from eMMC without additional patch in u-boot.
Fixes: 50decd493c83 ("arm64: dts: rockchip: Add FriendlyARM NanoPi R3S board")
Suggested-by: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
index 243574f8da78..03a2f90f6217 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
@@ -491,6 +491,7 @@ &pmu_io_domains {
&sdhci {
bus-width = <8>;
max-frequency = <200000000>;
+ mmc-hs200-1_8v;
non-removable;
pinctrl-names = "default";
pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>;
--
2.47.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 5/5] arm64: dts: rockchip: reorder mmc aliases for NanoPi R3S
2024-10-22 19:35 [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s Tianling Shen
` (3 preceding siblings ...)
2024-10-22 19:35 ` [PATCH 4/5] arm64: dts: rockchip: enable eMMC HS200 mode " Tianling Shen
@ 2024-10-22 19:35 ` Tianling Shen
2024-10-24 8:30 ` [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s Heiko Stuebner
5 siblings, 0 replies; 7+ messages in thread
From: Tianling Shen @ 2024-10-22 19:35 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jonas Karlman, Andy Yan, Jagan Teki, Tianling Shen
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Typically any non-removable storage (emmc) is listed before removable
storage (sd-card) options. Also U-Boot will try to override and use
mmc0=sdhci and mmc1=sdmmc0 for all rk356x boards.
Fixes: 50decd493c83 ("arm64: dts: rockchip: Add FriendlyARM NanoPi R3S board")
Suggested-by: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
index 03a2f90f6217..fb1f65c86883 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts
@@ -22,8 +22,8 @@ / {
aliases {
ethernet0 = &gmac1;
- mmc0 = &sdmmc0;
- mmc1 = &sdhci;
+ mmc0 = &sdhci;
+ mmc1 = &sdmmc0;
};
chosen: chosen {
--
2.47.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s
2024-10-22 19:35 [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s Tianling Shen
` (4 preceding siblings ...)
2024-10-22 19:35 ` [PATCH 5/5] arm64: dts: rockchip: reorder mmc aliases " Tianling Shen
@ 2024-10-24 8:30 ` Heiko Stuebner
5 siblings, 0 replies; 7+ messages in thread
From: Heiko Stuebner @ 2024-10-24 8:30 UTC (permalink / raw)
To: Tianling Shen, Andy Yan, Rob Herring, Jagan Teki,
Krzysztof Kozlowski, Jonas Karlman, Conor Dooley, Chris Morgan
Cc: Heiko Stuebner, devicetree, linux-rockchip, linux-arm-kernel,
linux-kernel
On Wed, 23 Oct 2024 03:35:25 +0800, Tianling Shen wrote:
> * Enable eMMC HS200 mode to allow it boot from eMMC
> * Sort properties in pmu_io_domains node
> * Reorder mmc aliases
> * Replace deprecated snps,reset properties
> * Use the marketing name for the model name
> * Update the website url in copyright
>
> [...]
Applied, thanks!
[1/5] arm64: dts: rockchip: fix model name for FriendlyElec NanoPi R3S
commit: b5bf84206a5c77528f9dd4cbca4e72caa063c102
[2/5] arm64: dts: rockchip: replace deprecated snps,reset props for NanoPi R3S
commit: 82b2868937883b65732da498b26366d34db61510
[3/5] arm64: dts: rockchip: sort props in pmu_io_domains node for NanoPi R3S
commit: 17e150fdd983c7e59b9240e34a166285f3c3fb39
[4/5] arm64: dts: rockchip: enable eMMC HS200 mode for NanoPi R3S
commit: 1b5365034410f1ca21adadadd492b99bdf4f2c55
[5/5] arm64: dts: rockchip: reorder mmc aliases for NanoPi R3S
commit: b7cd1115456d312f8c5e60c80fdc35fd35ea6eab
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-10-24 8:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-22 19:35 [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s Tianling Shen
2024-10-22 19:35 ` [PATCH 1/5] arm64: dts: rockchip: fix model name for FriendlyElec NanoPi R3S Tianling Shen
2024-10-22 19:35 ` [PATCH 2/5] arm64: dts: rockchip: replace deprecated snps,reset props for " Tianling Shen
2024-10-22 19:35 ` [PATCH 3/5] arm64: dts: rockchip: sort props in pmu_io_domains node " Tianling Shen
2024-10-22 19:35 ` [PATCH 4/5] arm64: dts: rockchip: enable eMMC HS200 mode " Tianling Shen
2024-10-22 19:35 ` [PATCH 5/5] arm64: dts: rockchip: reorder mmc aliases " Tianling Shen
2024-10-24 8:30 ` [PATCH 0/5] arm64: dts: rockchip: several fixes for the nanopi r3s Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox