From: Ye Zhang <ye.zhang@rock-chips.com>
To: Ye Zhang <ye.zhang@rock-chips.com>,
linus.walleij@linaro.org, brgl@bgdev.pl, heiko@sntech.de,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, tao.huang@rock-chips.com,
finley.xiao@rock-chips.com, tim.chen@rock-chips.com,
elaine.zhang@rock-chips.com,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: [PATCH v5 1/4] gpio: rockchip: explan the format of the GPIO version ID
Date: Tue, 12 Nov 2024 09:54:05 +0800 [thread overview]
Message-ID: <20241112015408.3139996-2-ye.zhang@rock-chips.com> (raw)
In-Reply-To: <20241112015408.3139996-1-ye.zhang@rock-chips.com>
Remove redundant comments and provide a detailed explanation of the
GPIO version ID.
Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
drivers/gpio/gpio-rockchip.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index 365ab947983c..702e711f9c23 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -26,9 +26,15 @@
#include "../pinctrl/core.h"
#include "../pinctrl/pinctrl-rockchip.h"
+/*
+ * Version ID Register
+ * Bits [31:24] - Major Version
+ * Bits [23:16] - Minor Version
+ * Bits [15:0] - Revision Number
+ */
#define GPIO_TYPE_V1 (0) /* GPIO Version ID reserved */
-#define GPIO_TYPE_V2 (0x01000C2B) /* GPIO Version ID 0x01000C2B */
-#define GPIO_TYPE_V2_1 (0x0101157C) /* GPIO Version ID 0x0101157C */
+#define GPIO_TYPE_V2 (0x01000C2B)
+#define GPIO_TYPE_V2_1 (0x0101157C)
static const struct rockchip_gpio_regs gpio_regs_v1 = {
.port_dr = 0x00,
--
2.34.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-11-12 1:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 1:54 [PATCH v5 0/4] gpio: rockchip: Update the GPIO driver Ye Zhang
2024-11-12 1:54 ` Ye Zhang [this message]
2024-11-12 1:54 ` [PATCH v5 2/4] gpio: rockchip: change the GPIO version judgment logic Ye Zhang
2024-11-12 10:37 ` Andy Shevchenko
2024-11-12 1:54 ` [PATCH v5 3/4] gpio: rockchip: support new version GPIO Ye Zhang
2024-11-12 1:54 ` [PATCH v5 4/4] gpio: rockchip: Set input direction when request irq Ye Zhang
2024-11-12 8:48 ` Bartosz Golaszewski
2024-11-12 10:40 ` Andy Shevchenko
2024-11-12 12:50 ` Bartosz Golaszewski
2024-11-12 12:53 ` Bartosz Golaszewski
2024-11-12 13:22 ` Sebastian Reichel
2024-11-12 13:49 ` Bartosz Golaszewski
2024-11-12 12:52 ` (subset) [PATCH v5 0/4] gpio: rockchip: Update the GPIO driver Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241112015408.3139996-2-ye.zhang@rock-chips.com \
--to=ye.zhang@rock-chips.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=elaine.zhang@rock-chips.com \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sebastian.reichel@collabora.com \
--cc=tao.huang@rock-chips.com \
--cc=tim.chen@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox