From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Ye Zhang <ye.zhang@rock-chips.com>,
linus.walleij@linaro.org, heiko@sntech.de,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
mika.westerberg@linux.intel.com, tao.huang@rock-chips.com,
finley.xiao@rock-chips.com, tim.chen@rock-chips.com,
elaine.zhang@rock-chips.com,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH v5 4/4] gpio: rockchip: Set input direction when request irq
Date: Tue, 12 Nov 2024 12:40:07 +0200 [thread overview]
Message-ID: <ZzMwh2GMP-bE7aLO@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=MfTmpLSEUVTXSu8jf9tyTfQc=iG9NpovFem-qSDOCnagQ@mail.gmail.com>
On Tue, Nov 12, 2024 at 09:48:06AM +0100, Bartosz Golaszewski wrote:
> On Tue, Nov 12, 2024 at 2:54 AM Ye Zhang <ye.zhang@rock-chips.com> wrote:
> >
> > Since the GPIO can only generate interrupts when its direction is set to
> > input, it is set to input before requesting the interrupt resources.
...
> This looks like a fix to me, do you want it sent for stable? If so,
> please add the Fixes tag and put it first in the series.
Independently on the resolution on this, can the first three be applied to
for-next? I think they are valuable from the documentation perspective as
it adds the explanation of the version register bit fields.
The last one seems to me independent (code wise, meaning no potential
conflicts) to the rest and may be applied to for-current later on.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-11-12 11:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 1:54 [PATCH v5 0/4] gpio: rockchip: Update the GPIO driver Ye Zhang
2024-11-12 1:54 ` [PATCH v5 1/4] gpio: rockchip: explan the format of the GPIO version ID Ye Zhang
2024-11-12 1:54 ` [PATCH v5 2/4] gpio: rockchip: change the GPIO version judgment logic Ye Zhang
2024-11-12 10:37 ` Andy Shevchenko
2024-11-12 1:54 ` [PATCH v5 3/4] gpio: rockchip: support new version GPIO Ye Zhang
2024-11-12 1:54 ` [PATCH v5 4/4] gpio: rockchip: Set input direction when request irq Ye Zhang
2024-11-12 8:48 ` Bartosz Golaszewski
2024-11-12 10:40 ` Andy Shevchenko [this message]
2024-11-12 12:50 ` Bartosz Golaszewski
2024-11-12 12:53 ` Bartosz Golaszewski
2024-11-12 13:22 ` Sebastian Reichel
2024-11-12 13:49 ` Bartosz Golaszewski
2024-11-12 12:52 ` (subset) [PATCH v5 0/4] gpio: rockchip: Update the GPIO driver Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzMwh2GMP-bE7aLO@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=elaine.zhang@rock-chips.com \
--cc=finley.xiao@rock-chips.com \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mika.westerberg@linux.intel.com \
--cc=sebastian.reichel@collabora.com \
--cc=tao.huang@rock-chips.com \
--cc=tim.chen@rock-chips.com \
--cc=ye.zhang@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox