* [RFC PATCH v6 0/2] Add rk3576 pcie dts nodes @ 2025-02-21 10:43 Kever Yang 2025-02-21 10:43 ` [RFC PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support Kever Yang 2025-02-21 10:43 ` [RFC PATCH v6 2/2] arm64: dts: rockchip: Add rk3576 pcie nodes Kever Yang 0 siblings, 2 replies; 5+ messages in thread From: Kever Yang @ 2025-02-21 10:43 UTC (permalink / raw) To: heiko Cc: linux-rockchip, Kever Yang, Simon Xue, Conor Dooley, Detlev Casanova, Finley Xiao, Frank Wang, Rob Herring, Bjorn Helgaas, linux-pci, Liang Chen, Krzysztof Wilczyński, linux-kernel, Krzysztof Kozlowski, devicetree, Lorenzo Pieralisi, Shawn Lin, Manivannan Sadhasivam, Elaine Zhang, linux-arm-kernel The make dt_binding_check test has pass. But I got error for make CHECK_DTBS=y as below DTC [C] arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dtb DTC [C] arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb /home/kever/src/kernel-mainline/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pcie@2a200000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'msi'] is too long from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml# /home/kever/src/kernel-mainline/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pcie@2a210000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'msi'] is too long from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml# DTC [C] arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb /home/kever/src/kernel-mainline/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb: pcie@2a200000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'msi'] is too long from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml# /home/kever/src/kernel-mainline/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb: pcie@2a210000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'msi'] is too long from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie.yaml# DTC [C] arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb /home/kever/src/kernel-mainline/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: pcie-ep@fe150000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'dma0', 'dma1', 'dma2', 'dma3'] is too long from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml# Could anyone told me why, the rk3568 has pass the test, but the rk3572 and rk3588 failed. How can I debug the yaml check failure? Why the check rule does not go to the if branch I defined for rk3572 and rk3588? Changes in v6: - Fix make dt_binding_check and make CHECK_DTBS=y Changes in v5: - Add constraints per device for interrupt-names due to the interrupt is different from rk3588. Changes in v4: - Fix wrong indentation in dt_binding_check report by Rob Changes in v3: - Fix dtb check broken on rk3588 - Update commit message - Update the subject Changes in v2: - remove required 'msi-map' - add interrupt name 'msi' - Update clock and reset names and sequence to pass DTB check Kever Yang (2): dt-bindings: PCI: dw: rockchip: Add rk3576 support arm64: dts: rockchip: Add rk3576 pcie nodes .../bindings/pci/rockchip-dw-pcie-common.yaml | 59 ++++++++-- .../bindings/pci/rockchip-dw-pcie.yaml | 4 +- arch/arm64/boot/dts/rockchip/rk3576.dtsi | 109 ++++++++++++++++++ 3 files changed, 159 insertions(+), 13 deletions(-) -- 2.25.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support 2025-02-21 10:43 [RFC PATCH v6 0/2] Add rk3576 pcie dts nodes Kever Yang @ 2025-02-21 10:43 ` Kever Yang 2025-02-21 12:29 ` Rob Herring (Arm) 2025-02-21 18:09 ` Rob Herring 2025-02-21 10:43 ` [RFC PATCH v6 2/2] arm64: dts: rockchip: Add rk3576 pcie nodes Kever Yang 1 sibling, 2 replies; 5+ messages in thread From: Kever Yang @ 2025-02-21 10:43 UTC (permalink / raw) To: heiko Cc: linux-rockchip, Kever Yang, Simon Xue, Conor Dooley, Rob Herring, Bjorn Helgaas, linux-pci, Krzysztof Wilczyński, linux-kernel, Krzysztof Kozlowski, devicetree, Lorenzo Pieralisi, Shawn Lin, Manivannan Sadhasivam, linux-arm-kernel rk3576 is using dwc controller, with msi interrupt directly to gic instead of to gic its, so - no its support is required and the 'msi-map' is not need anymore, - a new 'msi' interrupt is needed. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- Changes in v6: - Fix make dt_binding_check and make CHECK_DTBS=y Changes in v5: - Add constraints per device for interrupt-names due to the interrupt is different from rk3588. Changes in v4: - Fix wrong indentation in dt_binding_check report by Rob Changes in v3: - Fix dtb check broken on rk3588 - Update commit message Changes in v2: - remove required 'msi-map' - add interrupt name 'msi' .../bindings/pci/rockchip-dw-pcie-common.yaml | 59 +++++++++++++++---- .../bindings/pci/rockchip-dw-pcie.yaml | 4 +- 2 files changed, 50 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml index cc9adfc7611c..069eb267c0bb 100644 --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml @@ -64,6 +64,10 @@ properties: interrupts - aer_rc_err, aer_rc_err_msi, rx_cpl_timeout, tx_cpl_timeout, cor_err_sent, nf_err_sent, f_err_sent, cor_err_rx, nf_err_rx, f_err_rx, radm_qoverflow + - description: + Combinded MSI line interrupt, which is to support MSI interrupts + output to GIC controller via GIC SPI interrupt instead of GIC its + interrupt. - description: eDMA write channel 0 interrupt - description: @@ -75,16 +79,6 @@ properties: interrupt-names: minItems: 5 - items: - - const: sys - - const: pmc - - const: msg - - const: legacy - - const: err - - const: dma0 - - const: dma1 - - const: dma2 - - const: dma3 num-lanes: true @@ -123,4 +117,49 @@ required: additionalProperties: true +anyOf: + - if: + properties: + compatible: + contains: + enum: + - rockchip,rk3568-pcie + - rockchip,rk3588-pcie + - rockchip,rk3588-pcie-ep + then: + properties: + interrupt-names: + minItems: 5 + type: array + items: + - const: sys + - const: pmc + - const: msg + - const: legacy + - const: err + - const: dma0 + - const: dma1 + - const: dma2 + - const: dma3 + + - if: + properties: + compatible: + contains: + enum: + - rockchip,rk3576-pcie + then: + properties: + interrupt-names: + type: array + items: + - const: sys + - const: pmc + - const: msg + - const: legacy + - const: err + - const: msi + minItems: 6 + maxItems: 6 + ... diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml index 550d8a684af3..9a464731fa4a 100644 --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml @@ -26,6 +26,7 @@ properties: - const: rockchip,rk3568-pcie - items: - enum: + - rockchip,rk3576-pcie - rockchip,rk3588-pcie - const: rockchip,rk3568-pcie @@ -71,9 +72,6 @@ properties: vpcie3v3-supply: true -required: - - msi-map - unevaluatedProperties: false examples: -- 2.25.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support 2025-02-21 10:43 ` [RFC PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support Kever Yang @ 2025-02-21 12:29 ` Rob Herring (Arm) 2025-02-21 18:09 ` Rob Herring 1 sibling, 0 replies; 5+ messages in thread From: Rob Herring (Arm) @ 2025-02-21 12:29 UTC (permalink / raw) To: Kever Yang Cc: Conor Dooley, Bjorn Helgaas, devicetree, Lorenzo Pieralisi, linux-arm-kernel, linux-kernel, heiko, linux-rockchip, Shawn Lin, linux-pci, Manivannan Sadhasivam, Krzysztof Wilczyński, Krzysztof Kozlowski, Simon Xue On Fri, 21 Feb 2025 18:43:56 +0800, Kever Yang wrote: > rk3576 is using dwc controller, with msi interrupt directly to gic instead > of to gic its, so > - no its support is required and the 'msi-map' is not need anymore, > - a new 'msi' interrupt is needed. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Changes in v6: > - Fix make dt_binding_check and make CHECK_DTBS=y > > Changes in v5: > - Add constraints per device for interrupt-names due to the interrupt is > different from rk3588. > > Changes in v4: > - Fix wrong indentation in dt_binding_check report by Rob > > Changes in v3: > - Fix dtb check broken on rk3588 > - Update commit message > > Changes in v2: > - remove required 'msi-map' > - add interrupt name 'msi' > > .../bindings/pci/rockchip-dw-pcie-common.yaml | 59 +++++++++++++++---- > .../bindings/pci/rockchip-dw-pcie.yaml | 4 +- > 2 files changed, 50 insertions(+), 13 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml: anyOf:1:then:properties:interrupt-names: {'type': 'array', 'items': [{'const': 'sys'}, {'const': 'pmc'}, {'const': 'msg'}, {'const': 'legacy'}, {'const': 'err'}, {'const': 'msi'}], 'minItems': 6, 'maxItems': 6} should not be valid under {'required': ['maxItems']} hint: "maxItems" is not needed with an "items" list from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml: anyOf:1:then:properties:interrupt-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'sys'}, {'const': 'pmc'}, {'const': 'msg'}, {'const': 'legacy'}, {'const': 'err'}, {'const': 'msi'}] is too long [{'const': 'sys'}, {'const': 'pmc'}, {'const': 'msg'}, {'const': 'legacy'}, {'const': 'err'}, {'const': 'msi'}] is too short False schema does not allow 6 1 was expected 6 is greater than the maximum of 2 6 is greater than the maximum of 3 6 is greater than the maximum of 4 6 is greater than the maximum of 5 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: interrupt-names: ['sys', 'pmc', 'msg', 'legacy', 'err', 'dma0', 'dma1', 'dma2', 'dma3'] is too long from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-ep.example.dtb: pcie-ep@fe150000: Unevaluated properties are not allowed ('power-domains' was unexpected) from schema $id: http://devicetree.org/schemas/pci/rockchip-dw-pcie-ep.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250221104357.1514128-2-kever.yang@rock-chips.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support 2025-02-21 10:43 ` [RFC PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support Kever Yang 2025-02-21 12:29 ` Rob Herring (Arm) @ 2025-02-21 18:09 ` Rob Herring 1 sibling, 0 replies; 5+ messages in thread From: Rob Herring @ 2025-02-21 18:09 UTC (permalink / raw) To: Kever Yang Cc: heiko, linux-rockchip, Simon Xue, Conor Dooley, Bjorn Helgaas, linux-pci, Krzysztof Wilczyński, linux-kernel, Krzysztof Kozlowski, devicetree, Lorenzo Pieralisi, Shawn Lin, Manivannan Sadhasivam, linux-arm-kernel On Fri, Feb 21, 2025 at 06:43:56PM +0800, Kever Yang wrote: > rk3576 is using dwc controller, with msi interrupt directly to gic instead > of to gic its, so > - no its support is required and the 'msi-map' is not need anymore, > - a new 'msi' interrupt is needed. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Changes in v6: > - Fix make dt_binding_check and make CHECK_DTBS=y > > Changes in v5: > - Add constraints per device for interrupt-names due to the interrupt is > different from rk3588. > > Changes in v4: > - Fix wrong indentation in dt_binding_check report by Rob > > Changes in v3: > - Fix dtb check broken on rk3588 > - Update commit message > > Changes in v2: > - remove required 'msi-map' > - add interrupt name 'msi' > > .../bindings/pci/rockchip-dw-pcie-common.yaml | 59 +++++++++++++++---- > .../bindings/pci/rockchip-dw-pcie.yaml | 4 +- > 2 files changed, 50 insertions(+), 13 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml > index cc9adfc7611c..069eb267c0bb 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie-common.yaml > @@ -64,6 +64,10 @@ properties: > interrupts - aer_rc_err, aer_rc_err_msi, rx_cpl_timeout, > tx_cpl_timeout, cor_err_sent, nf_err_sent, f_err_sent, cor_err_rx, > nf_err_rx, f_err_rx, radm_qoverflow > + - description: > + Combinded MSI line interrupt, which is to support MSI interrupts > + output to GIC controller via GIC SPI interrupt instead of GIC its > + interrupt. > - description: > eDMA write channel 0 interrupt > - description: > @@ -75,16 +79,6 @@ properties: > > interrupt-names: > minItems: 5 > - items: You just made the max 5 by dropping this. > - - const: sys > - - const: pmc > - - const: msg > - - const: legacy > - - const: err > - - const: dma0 Make this 'enum: [ dma0, msi ]' Yeah, that would allow the wrong one to be used, but I prefer that over duplicating the names. > - - const: dma1 > - - const: dma2 > - - const: dma3 > > num-lanes: true > > @@ -123,4 +117,49 @@ required: > > additionalProperties: true > > +anyOf: allOf > + - if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,rk3568-pcie > + - rockchip,rk3588-pcie > + - rockchip,rk3588-pcie-ep > + then: > + properties: > + interrupt-names: > + minItems: 5 That's already the min. > + type: array Don't need type. Do you see any schema use 'type: array' outside of the core? > + items: > + - const: sys > + - const: pmc > + - const: msg > + - const: legacy > + - const: err > + - const: dma0 > + - const: dma1 > + - const: dma2 > + - const: dma3 The whole if/then can be dropped. > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,rk3576-pcie > + then: > + properties: > + interrupt-names: > + type: array > + items: > + - const: sys > + - const: pmc > + - const: msg > + - const: legacy > + - const: err > + - const: msi Don't need type or items. Just this is enough to ensure 'msi' is used: contains: const: msi > + minItems: 6 > + maxItems: 6 This part is correct. > + > ... > diff --git a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > index 550d8a684af3..9a464731fa4a 100644 > --- a/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/rockchip-dw-pcie.yaml > @@ -26,6 +26,7 @@ properties: > - const: rockchip,rk3568-pcie > - items: > - enum: > + - rockchip,rk3576-pcie > - rockchip,rk3588-pcie > - const: rockchip,rk3568-pcie > > @@ -71,9 +72,6 @@ properties: > > vpcie3v3-supply: true > > -required: > - - msi-map This should be moved to an if/then schema, not just dropped. Unless it was wrong for the existing users. If so, then that's a separate patch. > - > unevaluatedProperties: false > > examples: > -- > 2.25.1 > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC PATCH v6 2/2] arm64: dts: rockchip: Add rk3576 pcie nodes 2025-02-21 10:43 [RFC PATCH v6 0/2] Add rk3576 pcie dts nodes Kever Yang 2025-02-21 10:43 ` [RFC PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support Kever Yang @ 2025-02-21 10:43 ` Kever Yang 1 sibling, 0 replies; 5+ messages in thread From: Kever Yang @ 2025-02-21 10:43 UTC (permalink / raw) To: heiko Cc: linux-rockchip, Kever Yang, devicetree, Conor Dooley, Finley Xiao, Frank Wang, Rob Herring, Liang Chen, Detlev Casanova, linux-kernel, Krzysztof Kozlowski, Elaine Zhang, linux-arm-kernel rk3576 has two pcie controllers, both are pcie2x1 work with naneng-combphy. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Update the subject Changes in v2: - Update clock and reset names and sequence to pass DTB check arch/arm64/boot/dts/rockchip/rk3576.dtsi | 109 +++++++++++++++++++++++ 1 file changed, 109 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi index 4dde954043ef..b4f396421686 100644 --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi @@ -1127,6 +1127,115 @@ qos_npu_m1ro: qos@27f22100 { reg = <0x0 0x27f22100 0x0 0x20>; }; + pcie0: pcie@2a200000 { + compatible = "rockchip,rk3576-pcie", "rockchip,rk3568-pcie"; + #address-cells = <3>; + #size-cells = <2>; + bus-range = <0x0 0xf>; + clocks = <&cru ACLK_PCIE0_MST>, <&cru ACLK_PCIE0_SLV>, + <&cru ACLK_PCIE0_DBI>, <&cru PCLK_PCIE0>, + <&cru CLK_PCIE0_AUX>; + + clock-names = "aclk_mst", "aclk_slv", + "aclk_dbi", "pclk", + "aux"; + device_type = "pci"; + interrupts = <GIC_SPI 281 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 282 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 283 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "sys", "pmc", "msg", "legacy", "err", "msi"; + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 7>; + interrupt-map = <0 0 0 1 &pcie0_intc 0>, + <0 0 0 2 &pcie0_intc 1>, + <0 0 0 3 &pcie0_intc 2>, + <0 0 0 4 &pcie0_intc 3>; + linux,pci-domain = <0>; + num-ib-windows = <8>; + num-viewport = <8>; + num-ob-windows = <2>; + max-link-speed = <2>; + num-lanes = <1>; + phys = <&combphy0_ps PHY_TYPE_PCIE>; + phy-names = "pcie-phy"; + power-domains = <&power RK3576_PD_PHP>; + ranges = <0x01000000 0x0 0x20100000 0x0 0x20100000 0x0 0x00100000 + 0x02000000 0x0 0x20200000 0x0 0x20200000 0x0 0x00e00000 + 0x03000000 0x9 0x00000000 0x9 0x00000000 0x0 0x80000000>; + reg = <0x0 0x22000000 0x0 0x00400000>, + <0x0 0x2a200000 0x0 0x00010000>, + <0x0 0x20000000 0x0 0x00100000>; + reg-names = "dbi", "apb", "config"; + resets = <&cru SRST_PCIE0_POWER_UP>, <&cru SRST_P_PCIE0>; + reset-names = "pwr", "pipe"; + status = "disabled"; + + pcie0_intc: legacy-interrupt-controller { + interrupt-controller; + #address-cells = <0>; + #interrupt-cells = <1>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 280 IRQ_TYPE_EDGE_RISING>; + }; + }; + + pcie1: pcie@2a210000 { + compatible = "rockchip,rk3576-pcie", "rockchip,rk3568-pcie"; + #address-cells = <3>; + #size-cells = <2>; + bus-range = <0x20 0x2f>; + clocks = <&cru ACLK_PCIE1_MST>, <&cru ACLK_PCIE1_SLV>, + <&cru ACLK_PCIE1_DBI>, <&cru PCLK_PCIE1>, + <&cru CLK_PCIE1_AUX>; + clock-names = "aclk_mst", "aclk_slv", + "aclk_dbi", "pclk", + "aux"; + device_type = "pci"; + interrupts = <GIC_SPI 267 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 268 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 265 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 264 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 269 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "sys", "pmc", "msg", "legacy", "err", "msi"; + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 7>; + interrupt-map = <0 0 0 1 &pcie1_intc 0>, + <0 0 0 2 &pcie1_intc 1>, + <0 0 0 3 &pcie1_intc 2>, + <0 0 0 4 &pcie1_intc 3>; + linux,pci-domain = <0>; + num-ib-windows = <8>; + num-viewport = <8>; + num-ob-windows = <2>; + max-link-speed = <2>; + num-lanes = <1>; + phys = <&combphy1_psu PHY_TYPE_PCIE>; + phy-names = "pcie-phy"; + power-domains = <&power RK3576_PD_SUBPHP>; + ranges = <0x01000000 0x0 0x21100000 0x0 0x21100000 0x0 0x00100000 + 0x02000000 0x0 0x21200000 0x0 0x21200000 0x0 0x00e00000 + 0x03000000 0x9 0x80000000 0x9 0x80000000 0x0 0x80000000>; + reg = <0x0 0x22400000 0x0 0x00400000>, + <0x0 0x2a210000 0x0 0x00010000>, + <0x0 0x21000000 0x0 0x00100000>; + reg-names = "dbi", "apb", "config"; + resets = <&cru SRST_PCIE1_POWER_UP>, <&cru SRST_P_PCIE1>; + reset-names = "pwr", "pipe"; + status = "disabled"; + + pcie1_intc: legacy-interrupt-controller { + interrupt-controller; + #address-cells = <0>; + #interrupt-cells = <1>; + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 266 IRQ_TYPE_EDGE_RISING>; + }; + }; + gmac0: ethernet@2a220000 { compatible = "rockchip,rk3576-gmac", "snps,dwmac-4.20a"; reg = <0x0 0x2a220000 0x0 0x10000>; -- 2.25.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-02-21 18:22 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-02-21 10:43 [RFC PATCH v6 0/2] Add rk3576 pcie dts nodes Kever Yang 2025-02-21 10:43 ` [RFC PATCH v6 1/2] dt-bindings: PCI: dw: rockchip: Add rk3576 support Kever Yang 2025-02-21 12:29 ` Rob Herring (Arm) 2025-02-21 18:09 ` Rob Herring 2025-02-21 10:43 ` [RFC PATCH v6 2/2] arm64: dts: rockchip: Add rk3576 pcie nodes Kever Yang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox