public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Add phy+vcc supply to NanoPi R5S and Q64-B
@ 2025-05-03 15:22 Diederik de Haas
  2025-05-03 15:22 ` [PATCH 1/2] arm64: dts: rockchip: Add phy-supply to gmac0 on NanoPi R5S Diederik de Haas
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Diederik de Haas @ 2025-05-03 15:22 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	Dragan Simic, Vasily Khoruzhick, Tianling Shen, Diederik de Haas

Testing on my NanoPi R5S and Quartz64 Model B brought some more issues
with power supplies to light, so fix them as well.

Diederik de Haas (2):
  arm64: dts: rockchip: Add phy-supply to gmac0 on NanoPi R5S
  arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3566-quartz64-b

 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 1 +
 arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts | 1 +
 2 files changed, 2 insertions(+)

-- 
2.49.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] arm64: dts: rockchip: Add phy-supply to gmac0 on NanoPi R5S
  2025-05-03 15:22 [PATCH 0/2] Add phy+vcc supply to NanoPi R5S and Q64-B Diederik de Haas
@ 2025-05-03 15:22 ` Diederik de Haas
  2025-05-03 15:22 ` [PATCH 2/2] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3566-quartz64-b Diederik de Haas
  2025-05-05  8:26 ` [PATCH 0/2] Add phy+vcc supply to NanoPi R5S and Q64-B Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Diederik de Haas @ 2025-05-03 15:22 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	Dragan Simic, Vasily Khoruzhick, Tianling Shen, Diederik de Haas

According to paragraph "7.16. Power" of the RTL8211F-CG datasheet, gmac0
needs to have a 3.3V power supply.
On page 22 of the NanoPi R5S version 2204, that is identified as
VCC_GEPHY_3V3 which is connected to the VCC_3V3 power source.

This fixes the following warning:

  rk_gmac-dwmac fe2a0000.ethernet: supply phy not found, using dummy regulator

Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts
index e50f1585244a..805cb23493e8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-nanopi-r5s.dts
@@ -61,6 +61,7 @@ &gmac0 {
 	clock_in_out = "output";
 	phy-handle = <&rgmii_phy0>;
 	phy-mode = "rgmii";
+	phy-supply = <&vcc_3v3>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac0_miim
 		     &gmac0_tx_bus2
-- 
2.49.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3566-quartz64-b
  2025-05-03 15:22 [PATCH 0/2] Add phy+vcc supply to NanoPi R5S and Q64-B Diederik de Haas
  2025-05-03 15:22 ` [PATCH 1/2] arm64: dts: rockchip: Add phy-supply to gmac0 on NanoPi R5S Diederik de Haas
@ 2025-05-03 15:22 ` Diederik de Haas
  2025-05-05  8:26 ` [PATCH 0/2] Add phy+vcc supply to NanoPi R5S and Q64-B Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Diederik de Haas @ 2025-05-03 15:22 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner
  Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
	Dragan Simic, Vasily Khoruzhick, Tianling Shen, Diederik de Haas

The Quartz64 Model B has a Winbound 25Q64DWZPIG SPI flash chip,
identified as 'U13' on the component placement schematic.
In the Quartz 64 Model-B Schematic from 20220124 on page 17, we can see
that the VCC connector is connected to VCCIO_FLASH and page 4 shows that
that in turn is connected to the VCCIO2 domain.
That domain uses vcc_1v8 as its power source.

This fixes the following warning:

  spi-nor spi4.0: supply vcc not found, using dummy regulator

Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
---
 arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
index 5707321a1144..f8cf03380636 100644
--- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
@@ -648,6 +648,7 @@ flash@0 {
 		spi-max-frequency = <24000000>;
 		spi-rx-bus-width = <4>;
 		spi-tx-bus-width = <1>;
+		vcc-supply = <&vcc_1v8>;
 	};
 };
 
-- 
2.49.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] Add phy+vcc supply to NanoPi R5S and Q64-B
  2025-05-03 15:22 [PATCH 0/2] Add phy+vcc supply to NanoPi R5S and Q64-B Diederik de Haas
  2025-05-03 15:22 ` [PATCH 1/2] arm64: dts: rockchip: Add phy-supply to gmac0 on NanoPi R5S Diederik de Haas
  2025-05-03 15:22 ` [PATCH 2/2] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3566-quartz64-b Diederik de Haas
@ 2025-05-05  8:26 ` Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2025-05-05  8:26 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Diederik de Haas
  Cc: Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
	linux-kernel, Dragan Simic, Vasily Khoruzhick, Tianling Shen


On Sat, 03 May 2025 17:22:17 +0200, Diederik de Haas wrote:
> Testing on my NanoPi R5S and Quartz64 Model B brought some more issues
> with power supplies to light, so fix them as well.
> 
> Diederik de Haas (2):
>   arm64: dts: rockchip: Add phy-supply to gmac0 on NanoPi R5S
>   arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3566-quartz64-b
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: rockchip: Add phy-supply to gmac0 on NanoPi R5S
      commit: fdc68be8a8acbea9630c3bca560b7a1cf3a952e2
[2/2] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3566-quartz64-b
      commit: ec79aee752c6b5c7695cd82a57a8a9249d09316d

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-05-05  8:42 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-03 15:22 [PATCH 0/2] Add phy+vcc supply to NanoPi R5S and Q64-B Diederik de Haas
2025-05-03 15:22 ` [PATCH 1/2] arm64: dts: rockchip: Add phy-supply to gmac0 on NanoPi R5S Diederik de Haas
2025-05-03 15:22 ` [PATCH 2/2] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3566-quartz64-b Diederik de Haas
2025-05-05  8:26 ` [PATCH 0/2] Add phy+vcc supply to NanoPi R5S and Q64-B Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox