* [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
@ 2025-05-15 22:00 Joseph Kogut
2025-05-15 22:00 ` [PATCH v2 2/2] arm64: dts: rockchip: add Radxa CM5 and " Joseph Kogut
2025-05-15 23:22 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Radxa CM5 " Rob Herring (Arm)
0 siblings, 2 replies; 19+ messages in thread
From: Joseph Kogut @ 2025-05-15 22:00 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-rockchip, linux-kernel, Steve deRosier, Joseph Kogut
Add device tree binding for the Radxa CM5 IO board.
This board is based on the rk3588s.
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 650fb833d96e..d9ca282c0b4f 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -840,6 +840,13 @@ properties:
- const: radxa,cm3
- const: rockchip,rk3566
+ - description: Radxa Compute Module 5 (CM5)
+ items:
+ - enum:
+ - radxa,cm5-io
+ - const: radxa,cm5
+ - const: rockchip,rk3588s
+
- description: Radxa CM3 Industrial
items:
- enum:
base-commit: c94d59a126cb9a8d1f71e3e044363d654dcd7af8
--
2.49.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v2 2/2] arm64: dts: rockchip: add Radxa CM5 and IO board
2025-05-15 22:00 [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Radxa CM5 IO board Joseph Kogut
@ 2025-05-15 22:00 ` Joseph Kogut
2025-05-15 23:22 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Radxa CM5 " Rob Herring (Arm)
1 sibling, 0 replies; 19+ messages in thread
From: Joseph Kogut @ 2025-05-15 22:00 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-rockchip, linux-kernel, Steve deRosier, Joseph Kogut
Add initial support for the Radxa CM5 and the accompanying IO board,
including ethernet, USB 2.0/3.0, PCIe 2.1 x1, HDMI output, UART2 console,
SD/eMMC, PMIC.
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
V1 -> V2:
- Added copyright header and data sheet links
- Removed non-existent property
- Sorted alphabetically
- Removed errant whitespace
- Moved status to the end of each node
- Removed pinctrl-names property from leds (indicated by CHECK_DTBS)
- Removed delays from gmac with internal delay
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../dts/rockchip/rk3588s-radxa-cm5-io.dts | 454 ++++++++++++++++++
.../boot/dts/rockchip/rk3588s-radxa-cm5.dtsi | 156 ++++++
3 files changed, 611 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 3e8771ef69ba..bc09420cacde 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -177,6 +177,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-radxa-cm5-io.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5c.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
new file mode 100644
index 000000000000..28d74e390a3c
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
@@ -0,0 +1,454 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2025 Joseph Kogut <joseph.kogut@gmail.com>
+ */
+
+/*
+ * CM5 IO board data sheet
+ * https://dl.radxa.com/cm5/v2200/radxa_cm5_io_v2200_schematic.pdf
+ */
+
+/dts-v1/;
+#include "rk3588s.dtsi"
+#include "rk3588s-radxa-cm5.dtsi"
+
+/ {
+ model = "Radxa Compute Module 5 (CM5) IO Board";
+ compatible = "radxa,cm5-io", "radxa,cm5", "rockchip,rk3588s";
+
+ chosen {
+ stdout-path = "serial2:1500000n8";
+ };
+
+ hdmi-con {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi0_out_con>;
+ };
+ };
+ };
+
+ vcc12v_dcin: regulator-12v0-vcc-dcin {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc12v_dcin";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <12000000>;
+ regulator-max-microvolt = <12000000>;
+ };
+
+ vcc5v0_host: vcc5v0-host-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc5v0_host";
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ enable-active-high;
+ gpio = <&gpio1 RK_PA0 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&vcc5v0_host_en>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+
+ vcc5v0_sys: regulator-5v0-sys {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc5v0_sys";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ vin-supply = <&vcc12v_dcin>;
+ };
+
+ vbus5v0_typec: vbus5v0-typec {
+ compatible = "regulator-fixed";
+ regulator-name = "vbus5v0_typec";
+ gpio = <&gpio0 RK_PD5 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&vbus5v0_typec_en>;
+ enable-active-high;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+
+ vcc3v3_pcie: regulator-3v3-vcc-pcie {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc3v3_pcie2x1l0";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ enable-active-high;
+ regulator-boot-on;
+ regulator-always-on;
+ gpios = <&gpio1 RK_PD3 GPIO_ACTIVE_HIGH>;
+ startup-delay-us = <50000>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+
+ vcc_3v3_s0: pldo-reg4 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_3v3_s0";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-ramp-delay = <12500>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+};
+
+&combphy0_ps {
+ status = "okay";
+};
+
+&combphy2_psu {
+ status = "okay";
+};
+
+&hdmi0_in {
+ hdmi0_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi0>;
+ };
+};
+
+&hdmi0_out {
+ hdmi0_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
+&hdptxphy0 {
+ status = "okay";
+};
+
+&i2c6 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c6m3_xfer>;
+ status = "okay";
+
+ fusb302: usb-typec@22 {
+ compatible = "fcs,fusb302";
+ reg = <0x22>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PC4 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usbc0_int>;
+ vbus-supply = <&vbus5v0_typec>;
+
+ connector {
+ compatible = "usb-c-connector";
+ data-role = "dual";
+ label = "USB-C";
+ power-role = "dual";
+ try-power-role = "source";
+ source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
+ sink-pdos = <PDO_FIXED(5000, 1000, PDO_FIXED_USB_COMM)>;
+ op-sink-microwatt = <1000000>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ usbc0_orientation_switch: endpoint {
+ remote-endpoint = <&usbdp_phy0_orientation_switch>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ usbc0_role_switch: endpoint {
+ remote-endpoint = <&usb_host0_xhci_role_switch>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+ usbc0_dp_altmode_mux: endpoint {
+ remote-endpoint = <&usbdp_phy0_dp_altmode_mux>;
+ };
+ };
+ };
+ };
+ };
+};
+
+&pcie2x1l2 {
+ reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>;
+ vpcie3v3-supply = <&vcc3v3_pcie>;
+ status = "okay";
+};
+
+&pinctrl {
+ fusb302 {
+ vbus5v0_typec_en: vbus5v0-typec-en {
+ rockchip,pins = <0 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+
+ usbc0_int: usbc0-int {
+ rockchip,pins = <0 RK_PC4 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
+ usb {
+ vcc5v0_host_en: vcc5v0-host-en {
+ rockchip,pins = <1 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+};
+
+&sdhci {
+ status = "okay";
+};
+
+&sdmmc {
+ bus-width = <4>;
+ cap-mmc-highspeed;
+ cap-sd-highspeed;
+ disable-wp;
+ max-frequency = <200000000>;
+ no-sdio;
+ no-mmc;
+ sd-uhs-sdr104;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_det>;
+ vmmc-supply = <&vcc_3v3_s3>;
+ vqmmc-supply = <&vccio_sd_s0>;
+ status = "okay";
+};
+
+&spi2 {
+ assigned-clocks = <&cru CLK_SPI2>;
+ assigned-clock-rates = <200000000>;
+ num-cs = <1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&spi2m2_cs0 &spi2m2_pins>;
+ status = "okay";
+
+ pmic@0 {
+ compatible = "rockchip,rk806";
+ reg = <0x0>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
+ <&rk806_dvs2_null>, <&rk806_dvs3_null>;
+ spi-max-frequency = <1000000>;
+ system-power-controller;
+
+ vcc1-supply = <&vcc5v0_sys>;
+ vcc2-supply = <&vcc5v0_sys>;
+ vcc3-supply = <&vcc5v0_sys>;
+ vcc4-supply = <&vcc5v0_sys>;
+ vcc5-supply = <&vcc5v0_sys>;
+ vcc6-supply = <&vcc5v0_sys>;
+ vcc7-supply = <&vcc5v0_sys>;
+ vcc8-supply = <&vcc5v0_sys>;
+ vcc9-supply = <&vcc5v0_sys>;
+ vcc10-supply = <&vcc5v0_sys>;
+ vcc11-supply = <&vcc_2v0_pldo_s3>;
+ vcc12-supply = <&vcc5v0_sys>;
+ vcc13-supply = <&vdd2_ddr_s3>;
+ vcc14-supply = <&vdd2_ddr_s3>;
+ vcca-supply = <&vcc5v0_sys>;
+
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ rk806_dvs1_null: dvs1-null-pins {
+ pins = "gpio_pwrctrl1";
+ function = "pin_fun0";
+ };
+
+ rk806_dvs2_null: dvs2-null-pins {
+ pins = "gpio_pwrctrl2";
+ function = "pin_fun0";
+ };
+
+ rk806_dvs3_null: dvs3-null-pins {
+ pins = "gpio_pwrctrl3";
+ function = "pin_fun0";
+ };
+
+ regulators {
+ vdd_gpu_s0: dcdc-reg1 {
+ regulator-name = "vdd_gpu_s0";
+ regulator-boot-on;
+ regulator-enable-ramp-delay = <400>;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <12500>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_cpu_lit_s0: dcdc-reg2 {
+ regulator-name = "vdd_cpu_lit_s0";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <12500>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vccio_sd_s0: pldo-reg5 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vccio_sd_s0";
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd2_ddr_s3: dcdc-reg6 {
+ regulator-name = "vdd2_ddr_s3";
+ regulator-always-on;
+ regulator-boot-on;
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+
+ vcc_2v0_pldo_s3: dcdc-reg7 {
+ regulator-name = "vdd_2v0_pldo_s3";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <2000000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-ramp-delay = <12500>;
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <2000000>;
+ };
+ };
+
+ vcc_3v3_s3: dcdc-reg8 {
+ regulator-name = "vcc_3v3_s3";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
+ };
+ };
+ };
+ };
+};
+
+&u2phy0 {
+ status = "okay";
+};
+
+&u2phy0_otg {
+ status = "okay";
+};
+
+&u2phy2 {
+ status = "okay";
+};
+
+&u2phy2_host {
+ status = "okay";
+};
+
+&u2phy3 {
+ status = "okay";
+};
+
+&u2phy3_host {
+ status = "okay";
+};
+
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart2m0_xfer>;
+ status = "okay";
+};
+
+&usb_host0_ehci {
+ status = "okay";
+};
+
+&usb_host0_ohci {
+ status = "okay";
+};
+
+&usb_host0_xhci {
+ dr_mode = "otg";
+ usb-role-switch;
+ status = "okay";
+
+ port {
+ usb_host0_xhci_role_switch: endpoint {
+ remote-endpoint = <&usbc0_role_switch>;
+ };
+ };
+};
+
+&usb_host1_ehci {
+ status = "okay";
+};
+
+&usb_host1_ohci {
+ status = "okay";
+};
+
+&usbdp_phy0 {
+ mode-switch;
+ orientation-switch;
+ sbu1-dc-gpios = <&gpio3 RK_PC4 GPIO_ACTIVE_HIGH>;
+ sbu2-dc-gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_HIGH>;
+ status = "okay";
+
+ port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ usbdp_phy0_orientation_switch: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&usbc0_orientation_switch>;
+ };
+
+ usbdp_phy0_dp_altmode_mux: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&usbc0_dp_altmode_mux>;
+ };
+ };
+};
+
+&vop {
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi0_in_vp0>;
+ };
+};
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
new file mode 100644
index 000000000000..c966da4626b7
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
@@ -0,0 +1,156 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2025 Joseph Kogut <joseph.kogut@gmail.com>
+ */
+
+/*
+ * CM5 data sheet
+ * https://dl.radxa.com/cm5/v2210/radxa_cm5_v2210_schematic.pdf
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
+#include <dt-bindings/usb/pd.h>
+
+/ {
+ compatible = "radxa,cm5", "rockchip,rk3588s";
+
+ aliases {
+ mmc0 = &sdmmc;
+ mmc1 = &sdhci;
+ mmc2 = &sdio;
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ led_sys: led-0 {
+ color = <LED_COLOR_ID_BLUE>;
+ default-state = "on";
+ function = LED_FUNCTION_HEARTBEAT;
+ gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+};
+
+&cpu_b0 {
+ cpu-supply = <&vdd_cpu_big0_s0>;
+};
+
+&cpu_b1 {
+ cpu-supply = <&vdd_cpu_big0_s0>;
+};
+
+&cpu_b2 {
+ cpu-supply = <&vdd_cpu_big1_s0>;
+};
+
+&cpu_b3 {
+ cpu-supply = <&vdd_cpu_big1_s0>;
+};
+
+&cpu_l0 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l1 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l2 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l3 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&gmac1 {
+ clock_in_out = "output";
+ phy-handle = <&rgmii_phy1>;
+ phy-mode = "rgmii-id";
+ phy-supply = <&vcc_3v3_s0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&gmac1_miim
+ &gmac1_tx_bus2
+ &gmac1_rx_bus2
+ &gmac1_rgmii_clk
+ &gmac1_rgmii_bus
+ &gmac1_clkinout>;
+ status = "okay";
+};
+
+&gpu {
+ mali-supply = <&vdd_gpu_s0>;
+ status = "okay";
+};
+
+&hdmi0 {
+ status = "okay";
+};
+
+&i2c0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c0m2_xfer>;
+ status = "okay";
+
+ vdd_cpu_big0_s0: regulator@42 {
+ compatible = "rockchip,rk8602";
+ reg = <0x42>;
+ fcs,suspend-voltage-selector = <1>;
+ regulator-name = "vdd_cpu_big0_s0";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <1050000>;
+ regulator-ramp-delay = <2300>;
+ vin-supply = <&vcc5v0_sys>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_cpu_big1_s0: regulator@43 {
+ compatible = "rockchip,rk8602";
+ reg = <0x43>;
+ fcs,suspend-voltage-selector = <1>;
+ regulator-name = "vdd_cpu_big1_s0";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <1050000>;
+ regulator-ramp-delay = <2300>;
+ vin-supply = <&vcc5v0_sys>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+};
+
+&mdio1 {
+ rgmii_phy1: phy@1 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0x1>;
+ };
+};
+
+&pd_gpu {
+ domain-supply = <&vdd_gpu_s0>;
+};
+
+&sdhci {
+ bus-width = <8>;
+ no-sdio;
+ no-sd;
+ non-removable;
+ max-frequency = <200000000>;
+ mmc-hs400-1_8v;
+ mmc-hs400-enhanced-strobe;
+ mmc-hs200-1_8v;
+ status = "okay";
+};
+
--
2.49.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-05-15 22:00 [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Radxa CM5 IO board Joseph Kogut
2025-05-15 22:00 ` [PATCH v2 2/2] arm64: dts: rockchip: add Radxa CM5 and " Joseph Kogut
@ 2025-05-15 23:22 ` Rob Herring (Arm)
2025-05-28 22:18 ` [PATCH v3 0/3] Add Radxa CM5 module and IO board dts Joseph Kogut
1 sibling, 1 reply; 19+ messages in thread
From: Rob Herring (Arm) @ 2025-05-15 23:22 UTC (permalink / raw)
To: Joseph Kogut
Cc: devicetree, Steve deRosier, Krzysztof Kozlowski, Heiko Stuebner,
linux-rockchip, linux-kernel, Conor Dooley
On Thu, 15 May 2025 15:00:33 -0700, Joseph Kogut wrote:
> Add device tree binding for the Radxa CM5 IO board.
>
> This board is based on the rk3588s.
>
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/rockchip.yaml:846:13: [warning] wrong indentation: expected 14 but found 12 (indentation)
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250515220034.393303-1-joseph.kogut@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 0/3] Add Radxa CM5 module and IO board dts
2025-05-15 23:22 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Radxa CM5 " Rob Herring (Arm)
@ 2025-05-28 22:18 ` Joseph Kogut
2025-05-28 22:18 ` [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board Joseph Kogut
` (2 more replies)
0 siblings, 3 replies; 19+ messages in thread
From: Joseph Kogut @ 2025-05-28 22:18 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley, devicetree, linux-rockchip,
linux-kernel, Steve deRosier, Joseph Kogut
This patch series adds initial device tree support for the Radxa CM5 SoM
and accompanying IO board.
V2 -> V3:
- Addressed YAML syntax error in dt binding (per Rob)
- Fixed whitespace issue in dts reported by checkpatch.pl
- Split base SoM and carrier board into separate patches
- Added further details about the SoM and carrier to the commit
messages
V1 -> V2:
- Added copyright header and data sheet links
- Removed non-existent property
- Sorted alphabetically
- Removed errant whitespace
- Moved status to the end of each node
- Removed pinctrl-names property from leds (indicated by CHECK_DTBS)
- Removed delays from gmac with internal delay
Joseph Kogut (3):
dt-bindings: arm: rockchip: Add Radxa CM5 IO board
arm64: dts: rockchip: Add rk3588 based Radxa CM5
arm64: dts: rockchip: Add support for CM5 IO carrier
.../devicetree/bindings/arm/rockchip.yaml | 7 +
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../dts/rockchip/rk3588s-radxa-cm5-io.dts | 454 ++++++++++++++++++
.../boot/dts/rockchip/rk3588s-radxa-cm5.dtsi | 156 ++++++
4 files changed, 618 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
--
2.49.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-05-28 22:18 ` [PATCH v3 0/3] Add Radxa CM5 module and IO board dts Joseph Kogut
@ 2025-05-28 22:18 ` Joseph Kogut
2025-05-29 9:19 ` Krzysztof Kozlowski
2025-05-28 22:18 ` [PATCH v3 2/3] arm64: dts: rockchip: Add rk3588 based Radxa CM5 Joseph Kogut
2025-05-28 22:18 ` [PATCH v3 3/3] arm64: dts: rockchip: Add support for CM5 IO carrier Joseph Kogut
2 siblings, 1 reply; 19+ messages in thread
From: Joseph Kogut @ 2025-05-28 22:18 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley, devicetree, linux-rockchip,
linux-kernel, Steve deRosier, Joseph Kogut
Add device tree binding for the Radxa CM5 IO board.
This board is based on the rk3588s.
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 650fb833d96e..64b0a0dfcf12 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -840,6 +840,13 @@ properties:
- const: radxa,cm3
- const: rockchip,rk3566
+ - description: Radxa Compute Module 5 (CM5)
+ items:
+ - enum:
+ - radxa,cm5-io
+ - const: radxa,cm5
+ - const: rockchip,rk3588s
+
- description: Radxa CM3 Industrial
items:
- enum:
--
2.49.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 2/3] arm64: dts: rockchip: Add rk3588 based Radxa CM5
2025-05-28 22:18 ` [PATCH v3 0/3] Add Radxa CM5 module and IO board dts Joseph Kogut
2025-05-28 22:18 ` [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board Joseph Kogut
@ 2025-05-28 22:18 ` Joseph Kogut
2025-05-28 22:18 ` [PATCH v3 3/3] arm64: dts: rockchip: Add support for CM5 IO carrier Joseph Kogut
2 siblings, 0 replies; 19+ messages in thread
From: Joseph Kogut @ 2025-05-28 22:18 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley, devicetree, linux-rockchip,
linux-kernel, Steve deRosier, Joseph Kogut
Add initial support for the Radxa Compute Module 5 (CM5).
Specification:
- Rockchip RK3588
- Up to 32 GB LPDDR4X
- Up to 128 GB eMMC
- 1x HDMI TX up to 8k@60 hz
- 1x eDP TX up to 4k@60 hz
- Gigabit Ethernet PHY
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
.../boot/dts/rockchip/rk3588s-radxa-cm5.dtsi | 156 ++++++++++++++++++
1 file changed, 156 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
new file mode 100644
index 000000000000..d7946fe2bb4e
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5.dtsi
@@ -0,0 +1,156 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2025 Joseph Kogut <joseph.kogut@gmail.com>
+ */
+
+/*
+ * CM5 data sheet
+ * https://dl.radxa.com/cm5/v2210/radxa_cm5_v2210_schematic.pdf
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
+#include <dt-bindings/usb/pd.h>
+
+/ {
+ compatible = "radxa,cm5", "rockchip,rk3588s";
+
+ aliases {
+ mmc0 = &sdmmc;
+ mmc1 = &sdhci;
+ mmc2 = &sdio;
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ led_sys: led-0 {
+ color = <LED_COLOR_ID_BLUE>;
+ default-state = "on";
+ function = LED_FUNCTION_HEARTBEAT;
+ gpios = <&gpio4 RK_PB4 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+};
+
+&cpu_b0 {
+ cpu-supply = <&vdd_cpu_big0_s0>;
+};
+
+&cpu_b1 {
+ cpu-supply = <&vdd_cpu_big0_s0>;
+};
+
+&cpu_b2 {
+ cpu-supply = <&vdd_cpu_big1_s0>;
+};
+
+&cpu_b3 {
+ cpu-supply = <&vdd_cpu_big1_s0>;
+};
+
+&cpu_l0 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l1 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l2 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l3 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&gmac1 {
+ clock_in_out = "output";
+ phy-handle = <&rgmii_phy1>;
+ phy-mode = "rgmii-id";
+ phy-supply = <&vcc_3v3_s0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&gmac1_miim
+ &gmac1_tx_bus2
+ &gmac1_rx_bus2
+ &gmac1_rgmii_clk
+ &gmac1_rgmii_bus
+ &gmac1_clkinout>;
+ status = "okay";
+};
+
+&gpu {
+ mali-supply = <&vdd_gpu_s0>;
+ status = "okay";
+};
+
+&hdmi0 {
+ status = "okay";
+};
+
+&i2c0 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c0m2_xfer>;
+ status = "okay";
+
+ vdd_cpu_big0_s0: regulator@42 {
+ compatible = "rockchip,rk8602";
+ reg = <0x42>;
+ fcs,suspend-voltage-selector = <1>;
+ regulator-name = "vdd_cpu_big0_s0";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <1050000>;
+ regulator-ramp-delay = <2300>;
+ vin-supply = <&vcc5v0_sys>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_cpu_big1_s0: regulator@43 {
+ compatible = "rockchip,rk8602";
+ reg = <0x43>;
+ fcs,suspend-voltage-selector = <1>;
+ regulator-name = "vdd_cpu_big1_s0";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <1050000>;
+ regulator-ramp-delay = <2300>;
+ vin-supply = <&vcc5v0_sys>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+};
+
+&mdio1 {
+ rgmii_phy1: phy@1 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0x1>;
+ };
+};
+
+&pd_gpu {
+ domain-supply = <&vdd_gpu_s0>;
+};
+
+&sdhci {
+ bus-width = <8>;
+ no-sdio;
+ no-sd;
+ non-removable;
+ max-frequency = <200000000>;
+ mmc-hs400-1_8v;
+ mmc-hs400-enhanced-strobe;
+ mmc-hs200-1_8v;
+ status = "okay";
+};
+
--
2.49.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v3 3/3] arm64: dts: rockchip: Add support for CM5 IO carrier
2025-05-28 22:18 ` [PATCH v3 0/3] Add Radxa CM5 module and IO board dts Joseph Kogut
2025-05-28 22:18 ` [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board Joseph Kogut
2025-05-28 22:18 ` [PATCH v3 2/3] arm64: dts: rockchip: Add rk3588 based Radxa CM5 Joseph Kogut
@ 2025-05-28 22:18 ` Joseph Kogut
2 siblings, 0 replies; 19+ messages in thread
From: Joseph Kogut @ 2025-05-28 22:18 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley, devicetree, linux-rockchip,
linux-kernel, Steve deRosier, Joseph Kogut
Specification:
- 1x HDMI
- 2x MIPI DSI
- 2x MIPI CSI
- 1x eDP
- 1x M.2 E key
- 1x USB 3.0 Host
- 1x USB 3.0 OTG
- 2x USB 2.0 Host
- Headphone jack w/ microphone
- Gigabit Ethernet w/ PoE
- microSD slot
- 40-pin expansion header
- 12V DC
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../dts/rockchip/rk3588s-radxa-cm5-io.dts | 454 ++++++++++++++++++
2 files changed, 455 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 3e8771ef69ba..bc09420cacde 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -177,6 +177,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-nanopi-r6c.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-odroid-m2.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-orangepi-5b.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-radxa-cm5-io.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5a.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588s-rock-5c.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
new file mode 100644
index 000000000000..28d74e390a3c
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3588s-radxa-cm5-io.dts
@@ -0,0 +1,454 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2025 Joseph Kogut <joseph.kogut@gmail.com>
+ */
+
+/*
+ * CM5 IO board data sheet
+ * https://dl.radxa.com/cm5/v2200/radxa_cm5_io_v2200_schematic.pdf
+ */
+
+/dts-v1/;
+#include "rk3588s.dtsi"
+#include "rk3588s-radxa-cm5.dtsi"
+
+/ {
+ model = "Radxa Compute Module 5 (CM5) IO Board";
+ compatible = "radxa,cm5-io", "radxa,cm5", "rockchip,rk3588s";
+
+ chosen {
+ stdout-path = "serial2:1500000n8";
+ };
+
+ hdmi-con {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi0_out_con>;
+ };
+ };
+ };
+
+ vcc12v_dcin: regulator-12v0-vcc-dcin {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc12v_dcin";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <12000000>;
+ regulator-max-microvolt = <12000000>;
+ };
+
+ vcc5v0_host: vcc5v0-host-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc5v0_host";
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ enable-active-high;
+ gpio = <&gpio1 RK_PA0 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&vcc5v0_host_en>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+
+ vcc5v0_sys: regulator-5v0-sys {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc5v0_sys";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ vin-supply = <&vcc12v_dcin>;
+ };
+
+ vbus5v0_typec: vbus5v0-typec {
+ compatible = "regulator-fixed";
+ regulator-name = "vbus5v0_typec";
+ gpio = <&gpio0 RK_PD5 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&vbus5v0_typec_en>;
+ enable-active-high;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+
+ vcc3v3_pcie: regulator-3v3-vcc-pcie {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc3v3_pcie2x1l0";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ enable-active-high;
+ regulator-boot-on;
+ regulator-always-on;
+ gpios = <&gpio1 RK_PD3 GPIO_ACTIVE_HIGH>;
+ startup-delay-us = <50000>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+
+ vcc_3v3_s0: pldo-reg4 {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc_3v3_s0";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-ramp-delay = <12500>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+};
+
+&combphy0_ps {
+ status = "okay";
+};
+
+&combphy2_psu {
+ status = "okay";
+};
+
+&hdmi0_in {
+ hdmi0_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi0>;
+ };
+};
+
+&hdmi0_out {
+ hdmi0_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
+&hdptxphy0 {
+ status = "okay";
+};
+
+&i2c6 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c6m3_xfer>;
+ status = "okay";
+
+ fusb302: usb-typec@22 {
+ compatible = "fcs,fusb302";
+ reg = <0x22>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PC4 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&usbc0_int>;
+ vbus-supply = <&vbus5v0_typec>;
+
+ connector {
+ compatible = "usb-c-connector";
+ data-role = "dual";
+ label = "USB-C";
+ power-role = "dual";
+ try-power-role = "source";
+ source-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)>;
+ sink-pdos = <PDO_FIXED(5000, 1000, PDO_FIXED_USB_COMM)>;
+ op-sink-microwatt = <1000000>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ usbc0_orientation_switch: endpoint {
+ remote-endpoint = <&usbdp_phy0_orientation_switch>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ usbc0_role_switch: endpoint {
+ remote-endpoint = <&usb_host0_xhci_role_switch>;
+ };
+ };
+
+ port@2 {
+ reg = <2>;
+ usbc0_dp_altmode_mux: endpoint {
+ remote-endpoint = <&usbdp_phy0_dp_altmode_mux>;
+ };
+ };
+ };
+ };
+ };
+};
+
+&pcie2x1l2 {
+ reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>;
+ vpcie3v3-supply = <&vcc3v3_pcie>;
+ status = "okay";
+};
+
+&pinctrl {
+ fusb302 {
+ vbus5v0_typec_en: vbus5v0-typec-en {
+ rockchip,pins = <0 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+
+ usbc0_int: usbc0-int {
+ rockchip,pins = <0 RK_PC4 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
+ usb {
+ vcc5v0_host_en: vcc5v0-host-en {
+ rockchip,pins = <1 RK_PA0 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+};
+
+&sdhci {
+ status = "okay";
+};
+
+&sdmmc {
+ bus-width = <4>;
+ cap-mmc-highspeed;
+ cap-sd-highspeed;
+ disable-wp;
+ max-frequency = <200000000>;
+ no-sdio;
+ no-mmc;
+ sd-uhs-sdr104;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_det>;
+ vmmc-supply = <&vcc_3v3_s3>;
+ vqmmc-supply = <&vccio_sd_s0>;
+ status = "okay";
+};
+
+&spi2 {
+ assigned-clocks = <&cru CLK_SPI2>;
+ assigned-clock-rates = <200000000>;
+ num-cs = <1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&spi2m2_cs0 &spi2m2_pins>;
+ status = "okay";
+
+ pmic@0 {
+ compatible = "rockchip,rk806";
+ reg = <0x0>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pmic_pins>, <&rk806_dvs1_null>,
+ <&rk806_dvs2_null>, <&rk806_dvs3_null>;
+ spi-max-frequency = <1000000>;
+ system-power-controller;
+
+ vcc1-supply = <&vcc5v0_sys>;
+ vcc2-supply = <&vcc5v0_sys>;
+ vcc3-supply = <&vcc5v0_sys>;
+ vcc4-supply = <&vcc5v0_sys>;
+ vcc5-supply = <&vcc5v0_sys>;
+ vcc6-supply = <&vcc5v0_sys>;
+ vcc7-supply = <&vcc5v0_sys>;
+ vcc8-supply = <&vcc5v0_sys>;
+ vcc9-supply = <&vcc5v0_sys>;
+ vcc10-supply = <&vcc5v0_sys>;
+ vcc11-supply = <&vcc_2v0_pldo_s3>;
+ vcc12-supply = <&vcc5v0_sys>;
+ vcc13-supply = <&vdd2_ddr_s3>;
+ vcc14-supply = <&vdd2_ddr_s3>;
+ vcca-supply = <&vcc5v0_sys>;
+
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ rk806_dvs1_null: dvs1-null-pins {
+ pins = "gpio_pwrctrl1";
+ function = "pin_fun0";
+ };
+
+ rk806_dvs2_null: dvs2-null-pins {
+ pins = "gpio_pwrctrl2";
+ function = "pin_fun0";
+ };
+
+ rk806_dvs3_null: dvs3-null-pins {
+ pins = "gpio_pwrctrl3";
+ function = "pin_fun0";
+ };
+
+ regulators {
+ vdd_gpu_s0: dcdc-reg1 {
+ regulator-name = "vdd_gpu_s0";
+ regulator-boot-on;
+ regulator-enable-ramp-delay = <400>;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <12500>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_cpu_lit_s0: dcdc-reg2 {
+ regulator-name = "vdd_cpu_lit_s0";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <550000>;
+ regulator-max-microvolt = <950000>;
+ regulator-ramp-delay = <12500>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vccio_sd_s0: pldo-reg5 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vccio_sd_s0";
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd2_ddr_s3: dcdc-reg6 {
+ regulator-name = "vdd2_ddr_s3";
+ regulator-always-on;
+ regulator-boot-on;
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+
+ vcc_2v0_pldo_s3: dcdc-reg7 {
+ regulator-name = "vdd_2v0_pldo_s3";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <2000000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-ramp-delay = <12500>;
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <2000000>;
+ };
+ };
+
+ vcc_3v3_s3: dcdc-reg8 {
+ regulator-name = "vcc_3v3_s3";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
+ };
+ };
+ };
+ };
+};
+
+&u2phy0 {
+ status = "okay";
+};
+
+&u2phy0_otg {
+ status = "okay";
+};
+
+&u2phy2 {
+ status = "okay";
+};
+
+&u2phy2_host {
+ status = "okay";
+};
+
+&u2phy3 {
+ status = "okay";
+};
+
+&u2phy3_host {
+ status = "okay";
+};
+
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&uart2m0_xfer>;
+ status = "okay";
+};
+
+&usb_host0_ehci {
+ status = "okay";
+};
+
+&usb_host0_ohci {
+ status = "okay";
+};
+
+&usb_host0_xhci {
+ dr_mode = "otg";
+ usb-role-switch;
+ status = "okay";
+
+ port {
+ usb_host0_xhci_role_switch: endpoint {
+ remote-endpoint = <&usbc0_role_switch>;
+ };
+ };
+};
+
+&usb_host1_ehci {
+ status = "okay";
+};
+
+&usb_host1_ohci {
+ status = "okay";
+};
+
+&usbdp_phy0 {
+ mode-switch;
+ orientation-switch;
+ sbu1-dc-gpios = <&gpio3 RK_PC4 GPIO_ACTIVE_HIGH>;
+ sbu2-dc-gpios = <&gpio3 RK_PD4 GPIO_ACTIVE_HIGH>;
+ status = "okay";
+
+ port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ usbdp_phy0_orientation_switch: endpoint@0 {
+ reg = <0>;
+ remote-endpoint = <&usbc0_orientation_switch>;
+ };
+
+ usbdp_phy0_dp_altmode_mux: endpoint@1 {
+ reg = <1>;
+ remote-endpoint = <&usbc0_dp_altmode_mux>;
+ };
+ };
+};
+
+&vop {
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi0: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi0_in_vp0>;
+ };
+};
--
2.49.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-05-28 22:18 ` [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board Joseph Kogut
@ 2025-05-29 9:19 ` Krzysztof Kozlowski
2025-05-29 17:00 ` Joseph Kogut
2025-10-28 9:33 ` FUKAUMI Naoki
0 siblings, 2 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-29 9:19 UTC (permalink / raw)
To: Joseph Kogut
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote:
> Add device tree binding for the Radxa CM5 IO board.
>
> This board is based on the rk3588s.
Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
<form letter>
This is an automated instruction, just in case, because many review
tags are being ignored. If you know the process, just skip it entirely
(please do not feel offended by me posting it here - no bad intentions
intended, no patronizing, I just want to avoid wasted efforts). If you
do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you
on the mailing list. Tools like b4 can help here ().
However, there's no need to repost patches *only* to add the tags. The
upstream maintainer will do that for tags received on the version they
apply.
https://elixir.bootlin.com/linux/v6.15/source/Documentation/process/submitting-patches.rst#L591
</form letter>
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-05-29 9:19 ` Krzysztof Kozlowski
@ 2025-05-29 17:00 ` Joseph Kogut
2025-05-29 17:07 ` Krzysztof Kozlowski
2025-10-28 9:33 ` FUKAUMI Naoki
1 sibling, 1 reply; 19+ messages in thread
From: Joseph Kogut @ 2025-05-29 17:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
I've reviewed the man page for git-send-email. If I'm understanding
correctly, I should only thread the *cover letter* of the patch series
when submitting a new version. That didn't work for me here because I
didn't initially include a cover letter, then tried to thread the
first patch in the series. I see now how that would be disruptive.
Thanks for the review, and the help with threading, Krzysztof. Parts
of the mailing list etiquette are still new to me.
Best,
Joseph
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-05-29 17:00 ` Joseph Kogut
@ 2025-05-29 17:07 ` Krzysztof Kozlowski
2025-05-29 17:26 ` Joseph Kogut
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-05-29 17:07 UTC (permalink / raw)
To: Joseph Kogut
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
On 29/05/2025 19:00, Joseph Kogut wrote:
> I've reviewed the man page for git-send-email. If I'm understanding
> correctly, I should only thread the *cover letter* of the patch series
> when submitting a new version. That didn't work for me here because I
> didn't initially include a cover letter, then tried to thread the
> first patch in the series. I see now how that would be disruptive.
You should not thread manually anything. b4 does it for you. If you want
to use git-send-email, then you also don't care:
git format-patch -v3 -3 HEAD
git send-email <whatever-to-and-cc-arguments> v3*
That's it. No manual threading.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-05-29 17:07 ` Krzysztof Kozlowski
@ 2025-05-29 17:26 ` Joseph Kogut
0 siblings, 0 replies; 19+ messages in thread
From: Joseph Kogut @ 2025-05-29 17:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
On Thu, May 29, 2025 at 10:07 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 29/05/2025 19:00, Joseph Kogut wrote:
> > I've reviewed the man page for git-send-email. If I'm understanding
> > correctly, I should only thread the *cover letter* of the patch series
> > when submitting a new version. That didn't work for me here because I
> > didn't initially include a cover letter, then tried to thread the
> > first patch in the series. I see now how that would be disruptive.
> You should not thread manually anything. b4 does it for you. If you want
> to use git-send-email, then you also don't care:
>
> git format-patch -v3 -3 HEAD
> git send-email <whatever-to-and-cc-arguments> v3*
>
> That's it. No manual threading.
>
I wasn't aware of b4, it looks like a great tool for this workflow.
Thanks again for your help, I'll give it a try.
Best,
Joseph
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-05-29 9:19 ` Krzysztof Kozlowski
2025-05-29 17:00 ` Joseph Kogut
@ 2025-10-28 9:33 ` FUKAUMI Naoki
2025-10-28 9:37 ` Krzysztof Kozlowski
1 sibling, 1 reply; 19+ messages in thread
From: FUKAUMI Naoki @ 2025-10-28 9:33 UTC (permalink / raw)
To: Krzysztof Kozlowski, Joseph Kogut
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
Hi Krzysztof,
https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/
On 5/29/25 18:19, Krzysztof Kozlowski wrote:
> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote:
>> Add device tree binding for the Radxa CM5 IO board.
>>
>> This board is based on the rk3588s.
>
> Do not attach (thread) your patchsets to some other threads (unrelated
> or older versions). This buries them deep in the mailbox and might
> interfere with applying entire sets.
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Please explain the sorting rule used for this file. You must have known
the sorting rule; otherwise, how can you be sure this patch is correct?
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-10-28 9:33 ` FUKAUMI Naoki
@ 2025-10-28 9:37 ` Krzysztof Kozlowski
2025-10-28 9:44 ` FUKAUMI Naoki
2025-10-28 10:42 ` Krzysztof Kozlowski
0 siblings, 2 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-28 9:37 UTC (permalink / raw)
To: FUKAUMI Naoki, Joseph Kogut
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
On 28/10/2025 10:33, FUKAUMI Naoki wrote:
> Hi Krzysztof,
>
> https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/
>
> On 5/29/25 18:19, Krzysztof Kozlowski wrote:
>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote:
>>> Add device tree binding for the Radxa CM5 IO board.
>>>
>>> This board is based on the rk3588s.
>>
>> Do not attach (thread) your patchsets to some other threads (unrelated
>> or older versions). This buries them deep in the mailbox and might
>> interfere with applying entire sets.
>>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Please explain the sorting rule used for this file. You must have known
> the sorting rule; otherwise, how can you be sure this patch is correct?
Huh? I don't have a clue about sorting rule but if you mock my review
let's make it different:
NAK
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-10-28 9:37 ` Krzysztof Kozlowski
@ 2025-10-28 9:44 ` FUKAUMI Naoki
2025-10-28 10:41 ` Krzysztof Kozlowski
2025-10-28 10:42 ` Krzysztof Kozlowski
1 sibling, 1 reply; 19+ messages in thread
From: FUKAUMI Naoki @ 2025-10-28 9:44 UTC (permalink / raw)
To: Krzysztof Kozlowski, Joseph Kogut
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
Hi Joseph
Your patch seems to be NAKed.
I will submit new patch soon.
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
On 10/28/25 18:37, Krzysztof Kozlowski wrote:
> On 28/10/2025 10:33, FUKAUMI Naoki wrote:
>> Hi Krzysztof,
>>
>> https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/
>>
>> On 5/29/25 18:19, Krzysztof Kozlowski wrote:
>>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote:
>>>> Add device tree binding for the Radxa CM5 IO board.
>>>>
>>>> This board is based on the rk3588s.
>>>
>>> Do not attach (thread) your patchsets to some other threads (unrelated
>>> or older versions). This buries them deep in the mailbox and might
>>> interfere with applying entire sets.
>>>
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Please explain the sorting rule used for this file. You must have known
>> the sorting rule; otherwise, how can you be sure this patch is correct?
>
> Huh? I don't have a clue about sorting rule but if you mock my review
> let's make it different:
>
> NAK
>
> Best regards,
> Krzysztof
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-10-28 9:44 ` FUKAUMI Naoki
@ 2025-10-28 10:41 ` Krzysztof Kozlowski
2025-11-05 1:37 ` FUKAUMI Naoki
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-28 10:41 UTC (permalink / raw)
To: FUKAUMI Naoki, Joseph Kogut
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
On 28/10/2025 10:44, FUKAUMI Naoki wrote:
> Hi Joseph
>
> Your patch seems to be NAKed.
> I will submit new patch soon.
Sorry, what? Don't hijack other people's work.
>
> Best regards,
>
> --
> FUKAUMI Naoki
> Radxa Computer (Shenzhen) Co., Ltd.
>
> On 10/28/25 18:37, Krzysztof Kozlowski wrote:
>> On 28/10/2025 10:33, FUKAUMI Naoki wrote:
>>> Hi Krzysztof,
>>>
>>> https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/
>>>
>>> On 5/29/25 18:19, Krzysztof Kozlowski wrote:
>>>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote:
>>>>> Add device tree binding for the Radxa CM5 IO board.
>>>>>
>>>>> This board is based on the rk3588s.
>>>>
>>>> Do not attach (thread) your patchsets to some other threads (unrelated
>>>> or older versions). This buries them deep in the mailbox and might
>>>> interfere with applying entire sets.
>>>>
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> Please explain the sorting rule used for this file. You must have known
>>> the sorting rule; otherwise, how can you be sure this patch is correct?
>>
>> Huh? I don't have a clue about sorting rule but if you mock my review
>> let's make it different:
>>
>> NAK
Ah, you were poking around other patch? I should have ignored that :/
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-10-28 9:37 ` Krzysztof Kozlowski
2025-10-28 9:44 ` FUKAUMI Naoki
@ 2025-10-28 10:42 ` Krzysztof Kozlowski
1 sibling, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-10-28 10:42 UTC (permalink / raw)
To: FUKAUMI Naoki, Joseph Kogut
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
On 28/10/2025 10:37, Krzysztof Kozlowski wrote:
> On 28/10/2025 10:33, FUKAUMI Naoki wrote:
>> Hi Krzysztof,
>>
>> https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/
>>
>> On 5/29/25 18:19, Krzysztof Kozlowski wrote:
>>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote:
>>>> Add device tree binding for the Radxa CM5 IO board.
>>>>
>>>> This board is based on the rk3588s.
>>>
>>> Do not attach (thread) your patchsets to some other threads (unrelated
>>> or older versions). This buries them deep in the mailbox and might
>>> interfere with applying entire sets.
>>>
>>>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Please explain the sorting rule used for this file. You must have known
>> the sorting rule; otherwise, how can you be sure this patch is correct?
>
> Huh? I don't have a clue about sorting rule but if you mock my review
> let's make it different:
>
> NAK
Please ignore, I thought that's patch from FUKAUMI Naoki which code and
then pokes about that.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-10-28 10:41 ` Krzysztof Kozlowski
@ 2025-11-05 1:37 ` FUKAUMI Naoki
2025-11-05 6:42 ` Krzysztof Kozlowski
2025-11-14 8:18 ` FUKAUMI Naoki
0 siblings, 2 replies; 19+ messages in thread
From: FUKAUMI Naoki @ 2025-11-05 1:37 UTC (permalink / raw)
To: Krzysztof Kozlowski, Joseph Kogut
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
Hi Krzysztof
On 10/28/25 19:41, Krzysztof Kozlowski wrote:
> On 28/10/2025 10:44, FUKAUMI Naoki wrote:
>> Hi Joseph
>>
>> Your patch seems to be NAKed.
>> I will submit new patch soon.
>
> Sorry, what? Don't hijack other people's work.
I have Joseph's permission to post my patch.
Furthermore, this is not the first time, to my knowledge, that someone
else has posted another patch for the same board. (See below)
https://lore.kernel.org/linux-rockchip/20241226005845.46473-1-naoki@radxa.com/T/#u
https://lore.kernel.org/linux-rockchip/20250324-rock5bp-for-upstream-v1-0-6217edf15b19@kernel.org/T/#u
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
>>
>> Best regards,
>>
>> --
>> FUKAUMI Naoki
>> Radxa Computer (Shenzhen) Co., Ltd.
>>
>> On 10/28/25 18:37, Krzysztof Kozlowski wrote:
>>> On 28/10/2025 10:33, FUKAUMI Naoki wrote:
>>>> Hi Krzysztof,
>>>>
>>>> https://patchwork.kernel.org/project/linux-rockchip/patch/20250528221823.2974653-2-joseph.kogut@gmail.com/
>>>>
>>>> On 5/29/25 18:19, Krzysztof Kozlowski wrote:
>>>>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote:
>>>>>> Add device tree binding for the Radxa CM5 IO board.
>>>>>>
>>>>>> This board is based on the rk3588s.
>>>>>
>>>>> Do not attach (thread) your patchsets to some other threads (unrelated
>>>>> or older versions). This buries them deep in the mailbox and might
>>>>> interfere with applying entire sets.
>>>>>
>>>>>
>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Please explain the sorting rule used for this file. You must have known
>>>> the sorting rule; otherwise, how can you be sure this patch is correct?
>>>
>>> Huh? I don't have a clue about sorting rule but if you mock my review
>>> let's make it different:
>>>
>>> NAK
>
>
> Ah, you were poking around other patch? I should have ignored that :/
>
>
> Best regards,
> Krzysztof
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-11-05 1:37 ` FUKAUMI Naoki
@ 2025-11-05 6:42 ` Krzysztof Kozlowski
2025-11-14 8:18 ` FUKAUMI Naoki
1 sibling, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2025-11-05 6:42 UTC (permalink / raw)
To: FUKAUMI Naoki, Joseph Kogut
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
On 05/11/2025 02:37, FUKAUMI Naoki wrote:
> Hi Krzysztof
>
> On 10/28/25 19:41, Krzysztof Kozlowski wrote:
>> On 28/10/2025 10:44, FUKAUMI Naoki wrote:
>>> Hi Joseph
>>>
>>> Your patch seems to be NAKed.
>>> I will submit new patch soon.
>>
>> Sorry, what? Don't hijack other people's work.
>
> I have Joseph's permission to post my patch.
This patch is correct, so you taking and hijacking it is not acceptable.
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board
2025-11-05 1:37 ` FUKAUMI Naoki
2025-11-05 6:42 ` Krzysztof Kozlowski
@ 2025-11-14 8:18 ` FUKAUMI Naoki
1 sibling, 0 replies; 19+ messages in thread
From: FUKAUMI Naoki @ 2025-11-14 8:18 UTC (permalink / raw)
To: Krzysztof Kozlowski, Joseph Kogut
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
devicetree, linux-rockchip, linux-kernel, Steve deRosier
On 11/5/25 10:37, FUKAUMI Naoki wrote:
> Hi Krzysztof
>
> On 10/28/25 19:41, Krzysztof Kozlowski wrote:
>> On 28/10/2025 10:44, FUKAUMI Naoki wrote:
>>> Hi Joseph
>>>
>>> Your patch seems to be NAKed.
>>> I will submit new patch soon.
>>
>> Sorry, what? Don't hijack other people's work.
>
> I have Joseph's permission to post my patch.
>
> Furthermore, this is not the first time, to my knowledge, that someone
> else has posted another patch for the same board. (See below)
>
> https://lore.kernel.org/linux-rockchip/20241226005845.46473-1-
> naoki@radxa.com/T/#u
> https://lore.kernel.org/linux-rockchip/20250324-rock5bp-for-upstream-
> v1-0-6217edf15b19@kernel.org/T/#u
Could you please write concise and precise answers/comments for the part
you previously snipped[1]?
[1]
https://lore.kernel.org/linux-rockchip/86939056-7617-4730-9464-f7ecbd0e4537@kernel.org/
Best regards,
--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.
> Best regards,
>
> --
> FUKAUMI Naoki
> Radxa Computer (Shenzhen) Co., Ltd.
>
>>>
>>> Best regards,
>>>
>>> --
>>> FUKAUMI Naoki
>>> Radxa Computer (Shenzhen) Co., Ltd.
>>>
>>> On 10/28/25 18:37, Krzysztof Kozlowski wrote:
>>>> On 28/10/2025 10:33, FUKAUMI Naoki wrote:
>>>>> Hi Krzysztof,
>>>>>
>>>>> https://patchwork.kernel.org/project/linux-rockchip/
>>>>> patch/20250528221823.2974653-2-joseph.kogut@gmail.com/
>>>>>
>>>>> On 5/29/25 18:19, Krzysztof Kozlowski wrote:
>>>>>> On Wed, May 28, 2025 at 03:18:21PM GMT, Joseph Kogut wrote:
>>>>>>> Add device tree binding for the Radxa CM5 IO board.
>>>>>>>
>>>>>>> This board is based on the rk3588s.
>>>>>>
>>>>>> Do not attach (thread) your patchsets to some other threads
>>>>>> (unrelated
>>>>>> or older versions). This buries them deep in the mailbox and might
>>>>>> interfere with applying entire sets.
>>>>>>
>>>>>>
>>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>> Please explain the sorting rule used for this file. You must have
>>>>> known
>>>>> the sorting rule; otherwise, how can you be sure this patch is
>>>>> correct?
>>>>
>>>> Huh? I don't have a clue about sorting rule but if you mock my review
>>>> let's make it different:
>>>>
>>>> NAK
>>
>>
>> Ah, you were poking around other patch? I should have ignored that :/
>>
>>
>> Best regards,
>> Krzysztof
>>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2025-11-14 8:19 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-15 22:00 [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Radxa CM5 IO board Joseph Kogut
2025-05-15 22:00 ` [PATCH v2 2/2] arm64: dts: rockchip: add Radxa CM5 and " Joseph Kogut
2025-05-15 23:22 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add Radxa CM5 " Rob Herring (Arm)
2025-05-28 22:18 ` [PATCH v3 0/3] Add Radxa CM5 module and IO board dts Joseph Kogut
2025-05-28 22:18 ` [PATCH v3 1/3] dt-bindings: arm: rockchip: Add Radxa CM5 IO board Joseph Kogut
2025-05-29 9:19 ` Krzysztof Kozlowski
2025-05-29 17:00 ` Joseph Kogut
2025-05-29 17:07 ` Krzysztof Kozlowski
2025-05-29 17:26 ` Joseph Kogut
2025-10-28 9:33 ` FUKAUMI Naoki
2025-10-28 9:37 ` Krzysztof Kozlowski
2025-10-28 9:44 ` FUKAUMI Naoki
2025-10-28 10:41 ` Krzysztof Kozlowski
2025-11-05 1:37 ` FUKAUMI Naoki
2025-11-05 6:42 ` Krzysztof Kozlowski
2025-11-14 8:18 ` FUKAUMI Naoki
2025-10-28 10:42 ` Krzysztof Kozlowski
2025-05-28 22:18 ` [PATCH v3 2/3] arm64: dts: rockchip: Add rk3588 based Radxa CM5 Joseph Kogut
2025-05-28 22:18 ` [PATCH v3 3/3] arm64: dts: rockchip: Add support for CM5 IO carrier Joseph Kogut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox