Re: [PATCH v8 10/10] arm64: dts: rockchip: rk3399-evb-ind: Add support for DisplayPort

From: "Peter Chen (CIX)" <peter.chen@kernel.org>
To: Chaoyi Chen <chaoyi.chen@rock-chips.com>
Cc: Peter Chen <hzpeterchen@gmail.com>,
	Chaoyi Chen <kernel@airkyi.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Sandy Huang <hjc@rock-chips.com>,
	Andy Yan <andy.yan@rock-chips.com>,
	Yubing Zhang <yubing.zhang@rock-chips.com>,
	Frank Wang <frank.wang@rock-chips.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Amit Sunil Dhamne <amitsd@google.com>,
	Dragan Simic <dsimic@manjaro.org>,
	Johan Jonker <jbx6244@gmail.com>,
	Diederik de Haas <didi.debian@cknow.org>,
	Peter Robinson <pbrobinson@gmail.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v8 10/10] arm64: dts: rockchip: rk3399-evb-ind: Add support for DisplayPort
Date: Fri, 31 Oct 2025 10:57:12 +0800	[thread overview]
Message-ID: <20251031025712.GA1284354@nchen-desktop> (raw)
In-Reply-To: <e2fcc437-0650-4fdf-bb75-3463a80299fe@rock-chips.com>

On 25-10-30 14:50:33, Chaoyi Chen wrote:
> > Hi Chaoyi,
> > 
> > There are two questions I have still not seen the answer to:
> > - Why USB2 PHY is related to your Type-C patch?
> 
> I was just following other people's approach. Sorry, this should be removed from the dts.
> 
> 
> > - How does the USB role switch event notify the USB controller driver, eg dwc3?
> 
> Sorry, I misunderstood what you said before. There is indeed a missing usb-role-switch now. I referred to the approach in rk3588-evb1-v10.dts. Is the following way of writing correct?
> 
> &usbc_connector {
>     ports {
>         #address-cells = <1>;
>         #size-cells = <0>;
> 
>         port@0 {
>             reg = <0>;
> 
>             usbc_orien_sw: endpoint {
>                 remote-endpoint = <&tcphy0_typec_orien_sw>;
>             };
>         };
> 
>         port@1 {
>             reg = <1>;
> 
>             usbc_role_sw: endpoint {
>                 remote-endpoint = <&dwc3_0_role_switch>;
>             };
>         };
> 
> 
>         port@2 {
>             reg = <2>;
> 
>             usbc_dp: endpoint {
>                 remote-endpoint = <&tcphy0_typec_dp>;
>             };
>         };
>     };
> };
> 
> &usbdrd_dwc3_0 {
>     status = "okay";
>     usb-role-switch;
> 
>     port {
>         #address-cells = <1>;
>         #size-cells = <0>;
>         dwc3_0_role_switch: endpoint@0 {
>             reg = <0>;
>             remote-endpoint = <&usbc_role_sw>;
>         };
>     };
> };
> 
> &tcphy0_usb3 {
>     orientation-switch;
> 
>     port {
>         tcphy0_typec_orien_sw: endpoint {
>             remote-endpoint = <&usbc_orien_sw>;
>         };
>     };
> };
> 
> &tcphy0_dp {
>     mode-switch;
> 
>     port {
>         #address-cells = <1>;
>         #size-cells = <0>;
> 
>         tcphy0_typec_dp: endpoint@0 {
>             reg = <0>;
>             remote-endpoint = <&usbc_dp>;
>         };
>     };
> };
> 

The general hierarchy is okay, just need to fix some dts coding
style issue.

-- 

Best regards,
Peter

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip