Re: [PATCH v8 10/10] arm64: dts: rockchip: rk3399-evb-ind: Add support for DisplayPort

From: Chaoyi Chen <chaoyi.chen@rock-chips.com>
To: Peter Chen <hzpeterchen@gmail.com>, Chaoyi Chen <kernel@airkyi.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Sandy Huang <hjc@rock-chips.com>,
	Andy Yan <andy.yan@rock-chips.com>,
	Yubing Zhang <yubing.zhang@rock-chips.com>,
	Frank Wang <frank.wang@rock-chips.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Amit Sunil Dhamne <amitsd@google.com>,
	Dragan Simic <dsimic@manjaro.org>,
	Johan Jonker <jbx6244@gmail.com>,
	Diederik de Haas <didi.debian@cknow.org>,
	Peter Robinson <pbrobinson@gmail.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v8 10/10] arm64: dts: rockchip: rk3399-evb-ind: Add support for DisplayPort
Date: Wed, 29 Oct 2025 18:21:08 +0800	[thread overview]
Message-ID: <cc8b583a-77ec-4a7f-97cc-2d148f7fee9f@rock-chips.com> (raw)
In-Reply-To: <CAL411-o6mF71oBeRsJ-OPZNbLegn4iJ_ELN9xVdppTM3ssUPOw@mail.gmail.com>

Hi Peter,

On 10/29/2025 5:45 PM, Peter Chen wrote:
>> +&i2c4 {
>> +       i2c-scl-rising-time-ns = <475>;
>> +       i2c-scl-falling-time-ns = <26>;
>> +       status = "okay";
>> +
>> +       usbc0: typec-portc@22 {
>> +               compatible = "fcs,fusb302";
>> +               reg = <0x22>;
>> +               interrupt-parent = <&gpio1>;
>> +               interrupts = <RK_PA2 IRQ_TYPE_LEVEL_LOW>;
>> +               pinctrl-names = "default";
>> +               pinctrl-0 = <&usbc0_int>;
>> +               vbus-supply = <&vbus_typec>;
>> +
>> +               usb_con: connector {
>> +                       compatible = "usb-c-connector";
>> +                       label = "USB-C";
>> +                       data-role = "dual";
>> +                       power-role = "dual";
>> +                       try-power-role = "sink";
>> +                       op-sink-microwatt = <1000000>;
>> +                       sink-pdos =
>> +                               <PDO_FIXED(5000, 2500, PDO_FIXED_USB_COMM)>;
>> +                       source-pdos =
>> +                               <PDO_FIXED(5000, 1500, PDO_FIXED_USB_COMM)>;
>> +
>> +                       altmodes {
>> +                               displayport {
>> +                                       svid = /bits/ 16 <0xff01>;
>> +                                       vdo = <0x00001c46>;
>> +                               };
>> +                       };
>> +
>> +                       ports {
>> +                               #address-cells = <1>;
>> +                               #size-cells = <0>;
>> +
>> +                               port@0 {
>> +                                       reg = <0>;
>> +
>> +                                       usbc_hs: endpoint {
>> +                                               remote-endpoint = <&u2phy0_typec_hs>;
>> +                                       };
>> +                               };
>> +
> Why USB2 PHY needs to be notified for Type-C connection?

I think the USB-connector binding require a port@0 for High Speed.  So I filled in USB2 PHY here. And I have looked up boards with the same usage, and some of the results are as follows:

- rk3399-firefly.dts

- rk3399-pinebook-pro.dts

- rk3399-eaidk-610.dts

>
>> +                               port@1 {
>> +                                       reg = <1>;
>> +
>> +                                       usbc_ss: endpoint {
>> +                                               remote-endpoint = <&tcphy0_typec_ss>;
>> +                                       };
>> +                               };
>> +
>> +                               port@2 {
>> +                                       reg = <2>;
>> +
>> +                                       usbc_dp: endpoint {
>> +                                               remote-endpoint = <&tcphy0_typec_dp>;
>> +                                       };
>> +                               };
>> +                       };
>> +               };
>> +       };
>> +};
>> +
> .....
>>   &u2phy0 {
>>          status = "okay";
>> +
>> +       port {
>> +               u2phy0_typec_hs: endpoint {
>> +                       remote-endpoint = <&usbc_hs>;
>> +               };
>> +       };
>>   };
>>
> There is no switch and mux, how to co-work with Type-C?

I checked the phy-rockchip-inno-usb2.c but did not find any switch or mux. Does this mean that we need to implement them? Thank you.

>
> Best regards,
> Peter
>
>
-- 
Best,
Chaoyi

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip