* [PATCH] media: uapi: rkisp: Correct name version enum
@ 2026-05-01 19:03 Niklas Söderlund
2026-05-02 17:39 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Niklas Söderlund @ 2026-05-01 19:03 UTC (permalink / raw)
To: Dafna Hirschfeld, Laurent Pinchart, Paul Elder, Sakari Ailus,
Jacopo Mondi, linux-media, linux-rockchip
Cc: Niklas Söderlund
The name of the enum to hold the mapping of parameter buffer versions
have a typo in the name, correct it. While this is a uAPI header the
impact should be minimal as the enum is only used as a collection for
the one version number supported.
Fixes: e9d05e9d5db1 ("media: uapi: rkisp1-config: Add extensible params format")
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
include/uapi/linux/rkisp1-config.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h
index b2d2a71f7baf..7638b2220600 100644
--- a/include/uapi/linux/rkisp1-config.h
+++ b/include/uapi/linux/rkisp1-config.h
@@ -1535,11 +1535,11 @@ struct rkisp1_ext_params_wdr_config {
sizeof(struct rkisp1_ext_params_wdr_config))
/**
- * enum rksip1_ext_param_buffer_version - RkISP1 extensible parameters version
+ * enum rkisp1_ext_param_buffer_version - RkISP1 extensible parameters version
*
* @RKISP1_EXT_PARAM_BUFFER_V1: First version of RkISP1 extensible parameters
*/
-enum rksip1_ext_param_buffer_version {
+enum rkisp1_ext_param_buffer_version {
RKISP1_EXT_PARAM_BUFFER_V1 = V4L2_ISP_PARAMS_VERSION_V1,
};
@@ -1601,7 +1601,7 @@ enum rksip1_ext_param_buffer_version {
* +---------------------------------------------------------------------+
*
* @version: The RkISP1 extensible parameters buffer version, see
- * :c:type:`rksip1_ext_param_buffer_version`
+ * :c:type:`rkisp1_ext_param_buffer_version`
* @data_size: The RkISP1 configuration data effective size, excluding this
* header
* @data: The RkISP1 extensible configuration data blocks
--
2.54.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: uapi: rkisp: Correct name version enum
2026-05-01 19:03 [PATCH] media: uapi: rkisp: Correct name version enum Niklas Söderlund
@ 2026-05-02 17:39 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2026-05-02 17:39 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Dafna Hirschfeld, Paul Elder, Sakari Ailus, Jacopo Mondi,
linux-media, linux-rockchip
Hi Niklas,
Thank you for the patch.
On Fri, May 01, 2026 at 09:03:39PM +0200, Niklas Söderlund wrote:
> The name of the enum to hold the mapping of parameter buffer versions
> have a typo in the name, correct it. While this is a uAPI header the
> impact should be minimal as the enum is only used as a collection for
> the one version number supported.
>
> Fixes: e9d05e9d5db1 ("media: uapi: rkisp1-config: Add extensible params format")
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> include/uapi/linux/rkisp1-config.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/linux/rkisp1-config.h b/include/uapi/linux/rkisp1-config.h
> index b2d2a71f7baf..7638b2220600 100644
> --- a/include/uapi/linux/rkisp1-config.h
> +++ b/include/uapi/linux/rkisp1-config.h
> @@ -1535,11 +1535,11 @@ struct rkisp1_ext_params_wdr_config {
> sizeof(struct rkisp1_ext_params_wdr_config))
>
> /**
> - * enum rksip1_ext_param_buffer_version - RkISP1 extensible parameters version
> + * enum rkisp1_ext_param_buffer_version - RkISP1 extensible parameters version
> *
> * @RKISP1_EXT_PARAM_BUFFER_V1: First version of RkISP1 extensible parameters
> */
> -enum rksip1_ext_param_buffer_version {
> +enum rkisp1_ext_param_buffer_version {
> RKISP1_EXT_PARAM_BUFFER_V1 = V4L2_ISP_PARAMS_VERSION_V1,
> };
>
> @@ -1601,7 +1601,7 @@ enum rksip1_ext_param_buffer_version {
> * +---------------------------------------------------------------------+
> *
> * @version: The RkISP1 extensible parameters buffer version, see
> - * :c:type:`rksip1_ext_param_buffer_version`
> + * :c:type:`rkisp1_ext_param_buffer_version`
> * @data_size: The RkISP1 configuration data effective size, excluding this
> * header
> * @data: The RkISP1 extensible configuration data blocks
--
Regards,
Laurent Pinchart
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-02 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-01 19:03 [PATCH] media: uapi: rkisp: Correct name version enum Niklas Söderlund
2026-05-02 17:39 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox