From: Conor Dooley <conor@kernel.org>
To: Damon Ding <damon.ding@rock-chips.com>
Cc: heiko@sntech.de, dri-devel@lists.freedesktop.org,
dianders@chromium.org, Laurent.pinchart@ideasonboard.com,
andrzej.hajda@intel.com, airlied@gmail.com,
m.szyprowski@samsung.com, simona@ffwll.ch, robh@kernel.org,
rfoss@kernel.org, sebastian.reichel@collabora.com,
jernej.skrabec@gmail.com, linux-rockchip@lists.infradead.org,
luca.ceresoli@bootlin.com, devicetree@vger.kernel.org,
conor+dt@kernel.org, jonas@kwiboo.se,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
linux-arm-kernel@lists.infradead.org,
dmitry.baryshkov@oss.qualcomm.com, neil.armstrong@linaro.org,
hjc@rock-chips.com, linux-kernel@vger.kernel.org,
tzimmermann@suse.de, andy.yan@rock-chips.com, krzk+dt@kernel.org,
nicolas.frattaroli@collabora.com
Subject: Re: [PATCH v4 01/10] dt-bindings: display: rockchip: analogix-dp: Allow hclk as third clock
Date: Tue, 12 May 2026 18:12:42 +0100 [thread overview]
Message-ID: <20260512-diabetic-ahead-dd36bc2d8be7@spud> (raw)
In-Reply-To: <20260512095644.1946084-2-damon.ding@rock-chips.com>
[-- Attachment #1.1: Type: text/plain, Size: 1863 bytes --]
On Tue, May 12, 2026 at 05:56:35PM +0800, Damon Ding wrote:
> RK3588 eDP controller requires HCLK_VO1 (video output bus clock)
> to access the VO1 GRF registers and enable the video datapath.
>
> Previously, the clock was enabled implicitly via the 'rockchip,vo-grf'
> phandle reference, which allowed the eDP to work without explicitly
> managing the hclk_vo1 clock. However, this is not safe or explicit.
>
> To align with other display controllers (HDMI) on RK3588 and make
> the clock requirement explicit, expand clock-names to support either
> "grf" (for older SoCs) or "hclk" (for RK3588) as the third clock.
>
> This makes the clock dependency clear and removes reliance on implicit
> clock enablement from GRF phandle.
>
> Fixes: f855146263b1 ("dt-bindings: display: rockchip: analogix-dp: Add support for RK3588")
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
>
> ---
>
> Changes in v4:
> - Modify the commit msg.
> ---
> .../bindings/display/rockchip/rockchip,analogix-dp.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> index d99b23b88cc5..d2bc8636b626 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> @@ -26,7 +26,9 @@ properties:
> items:
> - const: dp
> - const: pclk
> - - const: grf
> + - enum:
> + - grf
> + - hclk
Could you also enforce the correct clock name on a per-compatible basis
please?
pw-bot: changes-requested
Cheers,
Conor.
>
> power-domains:
> maxItems: 1
> --
> 2.34.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-05-12 17:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 9:56 [PATCH v4 00/10] Add eDP support for RK3576 Damon Ding
2026-05-12 9:56 ` [PATCH v4 01/10] dt-bindings: display: rockchip: analogix-dp: Allow hclk as third clock Damon Ding
2026-05-12 17:12 ` Conor Dooley [this message]
2026-05-12 9:56 ` [PATCH v4 02/10] dt-bindings: display: rockchip: analogix-dp: Add per-clock descriptions Damon Ding
2026-05-12 17:11 ` Conor Dooley
2026-05-12 9:56 ` [PATCH v4 03/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP0 Damon Ding
2026-05-12 9:56 ` [PATCH v4 04/10] arm64: dts: rockchip: Add missing hclk for RK3588 eDP1 Damon Ding
2026-05-12 9:56 ` [PATCH v4 05/10] drm/rockchip: analogix_dp: Enable hclk for RK3588 Damon Ding
2026-05-12 9:56 ` [PATCH v4 06/10] dt-bindings: display: rockchip: analogix-dp: Add support for RK3576 Damon Ding
2026-05-12 17:13 ` Conor Dooley
2026-05-12 9:56 ` [PATCH v4 07/10] arm64: dts: rockchip: Add eDP node " Damon Ding
2026-05-12 9:56 ` [PATCH v4 08/10] drm/bridge: analogix_dp: Rename and simplify is_rockchip() Damon Ding
2026-05-12 9:56 ` [PATCH v4 09/10] drm/bridge: analogix_dp: Add support for RK3576 Damon Ding
2026-05-12 9:56 ` [PATCH v4 10/10] drm/rockchip: " Damon Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260512-diabetic-ahead-dd36bc2d8be7@spud \
--to=conor@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=damon.ding@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox