[PATCH] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible

[PATCH] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible

[Vladislav Leonov]

rockchip,rv1106-saradc was folded into the fallback enum together
with rockchip,rk3576-saradc, falling back to rockchip,rk3588-saradc.
The two IP blocks are not equivalent, though: per the RV1106 TRM v0.3,
chapter 20 (SAR-ADC), RV1106 only has 2 channels at 10-bit resolution,
versus 8 channels at 12-bit on RK3588. Documenting it as falling back
to rk3588-saradc allows device trees that would bind against the wrong
channel table and report an incorrect voltage scale.

Remove rockchip,rv1106-saradc from the RK3588 fallback enum and give
it its own standalone compatible entry, matching the dedicated match
table entry added by the driver patch.

Fixes: bdba14f6122c ("dt-bindings: iio: adc: rockchip-saradc: Add RV1106 compatible")
Link: https://lore.kernel.org/all/20260810090826.146758-1-vlad@zlab.su
Signed-off-by: Vladislav Leonov <vlad@zlab.su>
---
 .../devicetree/bindings/iio/adc/rockchip-saradc.yaml         | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
index f0551d665916..dc56855527b8 100644
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
@@ -22,9 +22,7 @@ properties:
       - const: rockchip,rk3562-saradc
       - const: rockchip,rk3588-saradc
       - items:
-          - enum:
-              - rockchip,rk3576-saradc
-              - rockchip,rv1106-saradc
+          - const: rockchip,rk3576-saradc
           - const: rockchip,rk3588-saradc
       - items:
           - enum:
@@ -35,6 +33,7 @@ properties:
               - rockchip,rv1108-saradc
               - rockchip,rv1126-saradc
           - const: rockchip,rk3399-saradc
+      - const: rockchip,rv1106-saradc
 
   reg:
     maxItems: 1
-- 
2.47.3


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible

[Joshua Crofts]

On Sun, 16 Aug 2026 14:36:36 +0300
Vladislav Leonov <vlad@zlab.su> wrote:

> rockchip,rv1106-saradc was folded into the fallback enum together
> with rockchip,rk3576-saradc, falling back to rockchip,rk3588-saradc.
> The two IP blocks are not equivalent, though: per the RV1106 TRM v0.3,
> chapter 20 (SAR-ADC), RV1106 only has 2 channels at 10-bit resolution,
> versus 8 channels at 12-bit on RK3588. Documenting it as falling back
> to rk3588-saradc allows device trees that would bind against the wrong
> channel table and report an incorrect voltage scale.
> 
> Remove rockchip,rv1106-saradc from the RK3588 fallback enum and give
> it its own standalone compatible entry, matching the dedicated match
> table entry added by the driver patch.
> 
> Fixes: bdba14f6122c ("dt-bindings: iio: adc: rockchip-saradc: Add RV1106 compatible")
> Link: https://lore.kernel.org/all/20260810090826.146758-1-vlad@zlab.su
> Signed-off-by: Vladislav Leonov <vlad@zlab.su>
> ---

Looking at the link provided, it seems that there should be a Suggested-by
tag for Jonathan?

Otherwise LGTM

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

-- 
Kind regards,
Joshua Crofts

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible

[Vladislav Leonov]

Hi Joshua,

Sorry, I forgot the Suggested-by tag. Should I send a v2, or can the tag be added when applying the patch?

Regards,
Vladislav

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible

[Joshua Crofts]

On Wed, 19 Aug 2026 10:59:21 +0300
Vladislav Leonov <vlad@zlab.su> wrote:

> Hi Joshua,
> 
> Sorry, I forgot the Suggested-by tag. Should I send a v2, or can the tag be added when applying the patch?
> 
> Regards,
> Vladislav

I think that Jonathan can just add it while applying. No need to
send a v2 unless explicitly asked.

-- 
Kind regards,
Joshua Crofts

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible

[Krzysztof Kozlowski]

On Sun, Aug 16, 2026 at 02:36:36PM +0300, Vladislav Leonov wrote:
> rockchip,rv1106-saradc was folded into the fallback enum together
> with rockchip,rk3576-saradc, falling back to rockchip,rk3588-saradc.
> The two IP blocks are not equivalent, though: per the RV1106 TRM v0.3,
> chapter 20 (SAR-ADC), RV1106 only has 2 channels at 10-bit resolution,
> versus 8 channels at 12-bit on RK3588. Documenting it as falling back
> to rk3588-saradc allows device trees that would bind against the wrong
> channel table and report an incorrect voltage scale.
> 
> Remove rockchip,rv1106-saradc from the RK3588 fallback enum and give
> it its own standalone compatible entry, matching the dedicated match
> table entry added by the driver patch.
> 
> Fixes: bdba14f6122c ("dt-bindings: iio: adc: rockchip-saradc: Add RV1106 compatible")
> Link: https://lore.kernel.org/all/20260810090826.146758-1-vlad@zlab.su
> Signed-off-by: Vladislav Leonov <vlad@zlab.su>
> ---
>  .../devicetree/bindings/iio/adc/rockchip-saradc.yaml         | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> index f0551d665916..dc56855527b8 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> @@ -22,9 +22,7 @@ properties:
>        - const: rockchip,rk3562-saradc
>        - const: rockchip,rk3588-saradc
>        - items:
> -          - enum:
> -              - rockchip,rk3576-saradc
> -              - rockchip,rv1106-saradc
> +          - const: rockchip,rk3576-saradc
>            - const: rockchip,rk3588-saradc
>        - items:
>            - enum:
> @@ -35,6 +33,7 @@ properties:
>                - rockchip,rv1108-saradc
>                - rockchip,rv1126-saradc
>            - const: rockchip,rk3399-saradc
> +      - const: rockchip,rv1106-saradc

So this goes to an enum with all the other single-entries.

Anyway, where is a driver binding to above compatible (see DT submitting
patches). git grep on a week old next gave me nothing.

Best regards,
Krzysztof


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible

[Vladislav Leonov]

On Friday, August 21, 2026 10:27 MSK, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Sun, Aug 16, 2026 at 02:36:36PM +0300, Vladislav Leonov wrote:
> > rockchip,rv1106-saradc was folded into the fallback enum together
> > with rockchip,rk3576-saradc, falling back to rockchip,rk3588-saradc.
> > The two IP blocks are not equivalent, though: per the RV1106 TRM v0.3,
> > chapter 20 (SAR-ADC), RV1106 only has 2 channels at 10-bit resolution,
> > versus 8 channels at 12-bit on RK3588. Documenting it as falling back
> > to rk3588-saradc allows device trees that would bind against the wrong
> > channel table and report an incorrect voltage scale.
> > 
> > Remove rockchip,rv1106-saradc from the RK3588 fallback enum and give
> > it its own standalone compatible entry, matching the dedicated match
> > table entry added by the driver patch.
> > 
> > Fixes: bdba14f6122c ("dt-bindings: iio: adc: rockchip-saradc: Add RV1106 compatible")
> > Link: https://lore.kernel.org/all/20260810090826.146758-1-vlad@zlab.su
> > Signed-off-by: Vladislav Leonov <vlad@zlab.su>
> > ---
> >  .../devicetree/bindings/iio/adc/rockchip-saradc.yaml         | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> > index f0551d665916..dc56855527b8 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> > @@ -22,9 +22,7 @@ properties:
> >        - const: rockchip,rk3562-saradc
> >        - const: rockchip,rk3588-saradc
> >        - items:
> > -          - enum:
> > -              - rockchip,rk3576-saradc
> > -              - rockchip,rv1106-saradc
> > +          - const: rockchip,rk3576-saradc
> >            - const: rockchip,rk3588-saradc
> >        - items:
> >            - enum:
> > @@ -35,6 +33,7 @@ properties:
> >                - rockchip,rv1108-saradc
> >                - rockchip,rv1126-saradc
> >            - const: rockchip,rk3399-saradc
> > +      - const: rockchip,rv1106-saradc
> 
> So this goes to an enum with all the other single-entries.
> 
> Anyway, where is a driver binding to above compatible (see DT submitting
> patches). git grep on a week old next gave me nothing.
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof,

I will combine it into a single enum in v2.

The driver patch adding this compatible has been sent but is not merged yet:
Link: https://lore.kernel.org/all/20260810090826.146758-1-vlad@zlab.su

-- 
Regards,
Vladislav


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

Re: [PATCH] dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible

[Jonathan Cameron]

On Fri, 21 Aug 2026 12:30:00 +0300
"Vladislav Leonov" <vlad@zlab.su> wrote:

> On Friday, August 21, 2026 10:27 MSK, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
> > On Sun, Aug 16, 2026 at 02:36:36PM +0300, Vladislav Leonov wrote:  
> > > rockchip,rv1106-saradc was folded into the fallback enum together
> > > with rockchip,rk3576-saradc, falling back to rockchip,rk3588-saradc.
> > > The two IP blocks are not equivalent, though: per the RV1106 TRM v0.3,
> > > chapter 20 (SAR-ADC), RV1106 only has 2 channels at 10-bit resolution,
> > > versus 8 channels at 12-bit on RK3588. Documenting it as falling back
> > > to rk3588-saradc allows device trees that would bind against the wrong
> > > channel table and report an incorrect voltage scale.
> > > 
> > > Remove rockchip,rv1106-saradc from the RK3588 fallback enum and give
> > > it its own standalone compatible entry, matching the dedicated match
> > > table entry added by the driver patch.
> > > 
> > > Fixes: bdba14f6122c ("dt-bindings: iio: adc: rockchip-saradc: Add RV1106 compatible")
> > > Link: https://lore.kernel.org/all/20260810090826.146758-1-vlad@zlab.su
> > > Signed-off-by: Vladislav Leonov <vlad@zlab.su>
> > > ---
> > >  .../devicetree/bindings/iio/adc/rockchip-saradc.yaml         | 5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> > > index f0551d665916..dc56855527b8 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> > > @@ -22,9 +22,7 @@ properties:
> > >        - const: rockchip,rk3562-saradc
> > >        - const: rockchip,rk3588-saradc
> > >        - items:
> > > -          - enum:
> > > -              - rockchip,rk3576-saradc
> > > -              - rockchip,rv1106-saradc
> > > +          - const: rockchip,rk3576-saradc
> > >            - const: rockchip,rk3588-saradc
> > >        - items:
> > >            - enum:
> > > @@ -35,6 +33,7 @@ properties:
> > >                - rockchip,rv1108-saradc
> > >                - rockchip,rv1126-saradc
> > >            - const: rockchip,rk3399-saradc
> > > +      - const: rockchip,rv1106-saradc  
> > 
> > So this goes to an enum with all the other single-entries.
> > 
> > Anyway, where is a driver binding to above compatible (see DT submitting
> > patches). git grep on a week old next gave me nothing.
> > 
> > Best regards,
> > Krzysztof
> >   
> 
> Hi Krzysztof,
> 
> I will combine it into a single enum in v2.
> 
> The driver patch adding this compatible has been sent but is not merged yet:
> Link: https://lore.kernel.org/all/20260810090826.146758-1-vlad@zlab.su
> 

Please combine the 2 patches into a small series as a v2. 

We aren't in a hurry at this point in the cycle and will make it easier
for everyone to see what is going on.

Thanks

Jonathan

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip