From: Chris Morgan <macroalpha82@gmail.com>
To: linux-rockchip@lists.infradead.org
Cc: mfd@lists.linux.dev, linux-pm@vger.kernel.org,
maccraft123mc@gmail.com, heiko@sntech.de, lee@kernel.org,
sre@kernel.org, Chris Morgan <macromorgan@hotmail.com>,
Jacob Cook <jacobmcook1984@gmail.com>
Subject: [PATCH V4 1/7] power: supply: rk817-charger: correct spelling of coulomb
Date: Wed, 11 Nov 2026 14:56:21 -0600 [thread overview]
Message-ID: <20261111205627.56652-2-macroalpha82@gmail.com> (raw)
In-Reply-To: <20261111205627.56652-1-macroalpha82@gmail.com>
From: Chris Morgan <macromorgan@hotmail.com>
Correct the spelling of the word "coulomb" throughout the driver.
Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
Suggested-by: Jacob Cook <jacobmcook1984@gmail.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
drivers/power/supply/rk817_charger.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
index 5558b182a1a6..674622398efa 100644
--- a/drivers/power/supply/rk817_charger.c
+++ b/drivers/power/supply/rk817_charger.c
@@ -83,7 +83,7 @@ struct rk817_charger {
/*
* Calibrate the SOC on a fully charged battery, this way we can use
- * the calibrated SOC value to correct for columb counter drift.
+ * the calibrated SOC value to correct for coulomb counter drift.
*/
bool soc_cal;
@@ -270,9 +270,9 @@ static int rk817_bat_calib_cap(struct rk817_charger *charger)
if (charger->charge_status == CHARGE_FINISH && (!charger->soc_cal)) {
/*
- * soc should be 100000 and columb counter should show the full
+ * soc should be 100000 and coulomb counter should show the full
* charge capacity. Note that if the device is unplugged for a
- * period of several days the columb counter will have a large
+ * period of several days the coulomb counter will have a large
* margin of error, so setting it back to the full charge on
* a completed charge cycle should correct this (my device was
* showing 33% battery after 3 days unplugged when it should
@@ -294,7 +294,7 @@ static int rk817_bat_calib_cap(struct rk817_charger *charger)
}
/*
- * The columb counter can drift up slightly, so we should correct for
+ * The coulomb counter can drift up slightly, so we should correct for
* it. But don't correct it until we're at 100% soc.
*/
if (charger->charge_status == CHARGE_FINISH && charger->soc_cal) {
@@ -307,16 +307,16 @@ static int rk817_bat_calib_cap(struct rk817_charger *charger)
charger->res_div);
/*
- * Re-init columb counter with updated values to correct drift.
+ * Re-init coulomb counter with updated values to correct drift.
*/
if (charge_now / 1000 > charger->fcc_mah) {
dev_dbg(charger->dev,
- "Recalibrating columb counter to %d uah\n",
+ "Recalibrating coulomb counter to %d uah\n",
charge_now);
/*
* Order of operations matters here to ensure we keep
* enough precision until the last step to keep from
- * making needless updates to columb counter.
+ * making needless updates to coulomb counter.
*/
charge_now_adc = CHARGE_TO_ADC(charger->fcc_mah,
charger->res_div);
@@ -757,7 +757,7 @@ rk817_read_or_set_full_charge_on_boot(struct rk817_charger *charger,
bool first_boot;
/*
- * Check if the battery is uninitalized. If it is, the columb counter
+ * Check if the battery is uninitalized. If it is, the coulomb counter
* needs to be set up.
*/
ret = regmap_read(rk808->regmap, RK817_GAS_GAUGE_GG_STS, ®);
@@ -811,7 +811,7 @@ rk817_read_or_set_full_charge_on_boot(struct rk817_charger *charger,
boot_charge_mah = ADC_TO_CHARGE_UAH(tmp,
charger->res_div) / 1000;
/*
- * Check if the columb counter has been off for more than 30
+ * Check if the coulomb counter has been off for more than 30
* minutes as it tends to drift downward. If so, re-init soc
* with the boot voltage instead. Note the unit values for the
* OFF_CNT register appear to be in decaminutes and stops
@@ -840,7 +840,7 @@ rk817_read_or_set_full_charge_on_boot(struct rk817_charger *charger,
}
/*
- * Now we have our full charge capacity and soc, init the columb
+ * Now we have our full charge capacity and soc, init the coulomb
* counter.
*/
boot_charge_mah = charger->soc * charger->fcc_mah / 100 / 1000;
--
2.53.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-11-11 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 20:56 [PATCH V4 0/7] Fix Incorrect State of Charge for RK817 Chris Morgan
2026-11-11 20:56 ` Chris Morgan [this message]
2026-11-11 20:56 ` [PATCH V4 2/7] power: supply: rk817-charger: Fix NVRAM SoC value Chris Morgan
2026-11-11 20:56 ` [PATCH V4 3/7] power: supply: rk817-charger: simplify re-initializing coulomb counter Chris Morgan
2026-11-11 20:56 ` [PATCH V4 4/7] power: supply: rk817-charger: Resolve boot state of charge from " Chris Morgan
2026-11-11 20:56 ` [PATCH V4 5/7] power: supply: rk817-charger: Expose boot voltage and OCV values Chris Morgan
2026-11-11 20:56 ` [PATCH V4 6/7] power: supply: rk817-charger: Clear SYS_CAN_SD reg by default Chris Morgan
2026-11-11 20:56 ` [PATCH V4 7/7] power: supply: rk817-charger: Clear full charge cal on resume Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261111205627.56652-2-macroalpha82@gmail.com \
--to=macroalpha82@gmail.com \
--cc=heiko@sntech.de \
--cc=jacobmcook1984@gmail.com \
--cc=lee@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maccraft123mc@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=mfd@lists.linux.dev \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox