From: Shawn Lin <shawn.lin@rock-chips.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org,
Andrew Powers-Holmes <aholmes@omnom.net>
Subject: Re: [PATCH 1/2] arm64: dts: rockchip: Fix rk356x PCIe range mappings
Date: Tue, 20 Jan 2026 18:14:56 +0800 [thread overview]
Message-ID: <20f4e36b-f1df-43db-b97f-89d4009bef2c@rock-chips.com> (raw)
In-Reply-To: <9350956.lvqk35OSZv@phil>
在 2026/01/20 星期二 17:44, Heiko Stuebner 写道:
> Hi Shawn,
>
> Am Montag, 5. Januar 2026, 09:15:28 Mitteleuropäische Normalzeit schrieb Shawn Lin:
>> The pcie bus address should be mapped 1:1 to the cpu side MMIO address, so
>> that there is no same address allocated from normal system memory. Otherwise
>> it's broken if the same address assigned to the EP for DMA purpose.Fix it to
>> sync with the vendor BSP.
>>
>> Fixes: 568a67e742df ("arm64: dts: rockchip: Fix rk356x PCIe register and range mappings")
>> Fixes: 66b51ea7d70f ("arm64: dts: rockchip: Add rk3568 PCIe2x1 controller")
>> Cc: Andrew Powers-Holmes <aholmes@omnom.net>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> Is there some way to reproduce the issue?
>
Yes. Mount a full NVMe attached to RK3568, and do md5sum for the files
in NVMe in loop, there is a certain probability that the MD5 value of a
file is incorrect.
> Or alternatively, if you're just syncing with the vendor BSP here,
> can you describe where the issue happend or was noticed?
>
>
> Thanks a lot
> Heiko
>
>> ---
>>
>> arch/arm64/boot/dts/rockchip/rk3568.dtsi | 4 ++--
>> arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
>> index e719a3d..658097e 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
>> @@ -185,7 +185,7 @@
>> <0x0 0xf2000000 0x0 0x00100000>;
>> ranges = <0x01000000 0x0 0xf2100000 0x0 0xf2100000 0x0 0x00100000>,
>> <0x02000000 0x0 0xf2200000 0x0 0xf2200000 0x0 0x01e00000>,
>> - <0x03000000 0x0 0x40000000 0x3 0x40000000 0x0 0x40000000>;
>> + <0x03000000 0x3 0x40000000 0x3 0x40000000 0x0 0x40000000>;
>> reg-names = "dbi", "apb", "config";
>> resets = <&cru SRST_PCIE30X1_POWERUP>;
>> reset-names = "pipe";
>> @@ -238,7 +238,7 @@
>> <0x0 0xf0000000 0x0 0x00100000>;
>> ranges = <0x01000000 0x0 0xf0100000 0x0 0xf0100000 0x0 0x00100000>,
>> <0x02000000 0x0 0xf0200000 0x0 0xf0200000 0x0 0x01e00000>,
>> - <0x03000000 0x0 0x40000000 0x3 0x80000000 0x0 0x40000000>;
>> + <0x03000000 0x3 0x80000000 0x3 0x80000000 0x0 0x40000000>;
>> reg-names = "dbi", "apb", "config";
>> resets = <&cru SRST_PCIE30X2_POWERUP>;
>> reset-names = "pipe";
>> diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
>> index 8893b7b..a2c4957 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi
>> @@ -1022,7 +1022,7 @@
>> power-domains = <&power RK3568_PD_PIPE>;
>> ranges = <0x01000000 0x0 0xf4100000 0x0 0xf4100000 0x0 0x00100000>,
>> <0x02000000 0x0 0xf4200000 0x0 0xf4200000 0x0 0x01e00000>,
>> - <0x03000000 0x0 0x40000000 0x3 0x00000000 0x0 0x40000000>;
>> + <0x03000000 0x3 0x00000000 0x3 0x00000000 0x0 0x40000000>;
>> resets = <&cru SRST_PCIE20_POWERUP>;
>> reset-names = "pipe";
>> #address-cells = <3>;
>>
>
>
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-01-20 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 8:15 [PATCH 1/2] arm64: dts: rockchip: Fix rk356x PCIe range mappings Shawn Lin
2026-01-05 8:15 ` [PATCH 2/2] arm64: dts: rockchip: Fix rk3588 " Shawn Lin
2026-01-20 9:44 ` [PATCH 1/2] arm64: dts: rockchip: Fix rk356x " Heiko Stuebner
2026-01-20 10:14 ` Shawn Lin [this message]
2026-02-04 19:11 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20f4e36b-f1df-43db-b97f-89d4009bef2c@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=aholmes@omnom.net \
--cc=heiko@sntech.de \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox