From: "Heiko Stübner" <heiko@sntech.de>
To: Krzysztof Kozlowski <krzk@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
Jacobe Zang <jacobe.zang@wesion.com>
Cc: Nick Xie <nick@khadas.com>,
"efectn@protonmail.com" <efectn@protonmail.com>,
"jagan@edgeble.ai" <jagan@edgeble.ai>,
"dsimic@manjaro.org" <dsimic@manjaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] arm64: dts: rockchip: Add USB-C to Khadas Edge 2
Date: Tue, 25 Jun 2024 10:25:37 +0200 [thread overview]
Message-ID: <2403789.9XhxPE3A7Q@diego> (raw)
In-Reply-To: <TYZPR03MB700141F5448D61A000D588AB80D52@TYZPR03MB7001.apcprd03.prod.outlook.com>
Am Dienstag, 25. Juni 2024, 09:53:45 CEST schrieb Jacobe Zang:
> > Was it disabled anywhere?
>
> This patch aims to enable the DRD function of Type-C port. So need to enable in DTS.
> + usbc0: usb-typec@22 {
> + compatible = "fcs,fusb302";
> + reg = <0x22>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <RK_PB5 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&usbc0_int>;
> + vbus-supply = <&vbus5v0_typec>;
> + status = "okay";
what Krzysztof means, is that the default for status is "okay". So for a
node you just added, you don't need a separate status="okay"
This is only needed if the node is added in a base dtsi (like soc
peripherals) which are then enabled on a per-board basis as needed.
So please just drop the status property from you fusb302 node.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-06-25 8:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 8:32 [PATCH v4 0/2] arm64: dts: Add board support for Khadas Edge2 Jacobe Zang
2024-06-24 8:32 ` [PATCH v4 1/2] arm64: dts: rockchip: Add USB-C to Khadas Edge 2 Jacobe Zang
2024-06-24 11:53 ` Krzysztof Kozlowski
2024-06-25 7:53 ` Jacobe Zang
2024-06-25 8:25 ` Heiko Stübner [this message]
2024-06-25 8:29 ` Jacobe Zang
2024-06-24 8:32 ` [PATCH v4 2/2] arm64: dts: rockchip: Add bluetooth rfkill to Khadas Edge2 Jacobe Zang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2403789.9XhxPE3A7Q@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=efectn@protonmail.com \
--cc=jacobe.zang@wesion.com \
--cc=jagan@edgeble.ai \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nick@khadas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox