Re: [PATCH v4 1/2] arm64: dts: rockchip: Add USB-C to Khadas Edge 2

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacobe Zang <jacobe.zang@wesion.com>,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	heiko@sntech.de
Cc: nick@khadas.com, efectn@protonmail.com, jagan@edgeble.ai,
	dsimic@manjaro.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] arm64: dts: rockchip: Add USB-C to Khadas Edge 2
Date: Mon, 24 Jun 2024 13:53:15 +0200	[thread overview]
Message-ID: <6d8f80a0-d67a-416e-b395-7a33b539682e@kernel.org> (raw)
In-Reply-To: <20240624083236.1401673-2-jacobe.zang@wesion.com>

On 24/06/2024 10:32, Jacobe Zang wrote:
> Khadas Edge 2 has 2x Type-C port. One just supports PD and
> controlled by MCU. The other one supports PD, DP Alt mode and DRD. This
> commit adds support for DRD.
> 
> Co-developed-by: Muhammed Efe Cetin <efectn@protonmail.com>
> Signed-off-by: Muhammed Efe Cetin <efectn@protonmail.com>
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
>  .../dts/rockchip/rk3588s-khadas-edge2.dts     | 118 ++++++++++++++++++
>  1 file changed, 118 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
> index dbddfc3bb4641..8c0bc675690dd 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-khadas-edge2.dts
> @@ -6,6 +6,7 @@
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/pinctrl/rockchip.h>
>  #include <dt-bindings/leds/common.h>
> +#include <dt-bindings/usb/pd.h>
>  #include "rk3588s.dtsi"
>  
>  / {
> @@ -112,6 +113,18 @@ vcc5v0_sys: vcc5v0-sys-regulator {
>  		regulator-max-microvolt = <5000000>;
>  	};
>  
> +	vbus5v0_typec: vbus5v0-typec-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "vbus5v0_typec";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		enable-active-high;
> +		gpio = <&gpio3 RK_PA4 GPIO_ACTIVE_HIGH>;
> +		vin-supply = <&vcc5v0_sys>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&typec5v_pwren>;
> +	};
> +
>  	vcc_1v1_nldo_s3: vcc-1v1-nldo-s3-regulator {
>  		compatible = "regulator-fixed";
>  		regulator-name = "vcc_1v1_nldo_s3";
> @@ -224,6 +237,56 @@ regulator-state-mem {
>  &i2c2 {
>  	status = "okay";
>  
> +	usbc0: usb-typec@22 {
> +		compatible = "fcs,fusb302";
> +		reg = <0x22>;
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <RK_PB5 IRQ_TYPE_LEVEL_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&usbc0_int>;
> +		vbus-supply = <&vbus5v0_typec>;
> +		status = "okay";

Was it disabled anywhere?

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip