From: "Heiko Stübner" <heiko@sntech.de>
To: FUKAUMI Naoki <naoki@radxa.com>
Cc: michael.riesch@wolfvision.net,
linux-rockchip@lists.infradead.org,
FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH] arm64: dts: rockchip: add workaround for microSD card detection on Radxa ROCK 3A
Date: Wed, 04 Sep 2024 20:32:54 +0200 [thread overview]
Message-ID: <2471069.n97fhnxGW3@diego> (raw)
In-Reply-To: <20240903085551.568-1-naoki@radxa.com>
Hi,
Am Dienstag, 3. September 2024, 10:55:50 CEST schrieb FUKAUMI Naoki:
> Radxa ROCK 3A doesn't detect microSD card insertion/removal correctly.
> it happens from Linux v5.19 to v6.11-rc6.
>
> add workaround (broken-cd property) to make CD work.
>
> Fixes: 22a442e6586c ("arm64: dts: rockchip: add basic dts for the radxa rock3 model a")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
before going for such drastic measures as broken-cd, can you describe how
you checked the card insert/removal ?
I.e. in the dts node below we have both cd-gpios as well as the sdmmc0_det
pinctrl which would set the pinfunc 1 ... the hw-based card detect and
possibly override the cd-gpios?
What happens if you just remove the sdmmc0_det and keep the cd-gpios
property?
Also, what does cat /sys/kernel/debug/gpio report after that change
with inserted and removed cards?
Heiko
> ---
> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> index 59f1403b4fa5..89599258ef9c 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
> @@ -722,12 +722,12 @@ &sdhci {
> };
>
> &sdmmc0 {
> + broken-cd;
> bus-width = <4>;
> cap-sd-highspeed;
> - cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
> disable-wp;
> pinctrl-names = "default";
> - pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
> + pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd>;
> sd-uhs-sdr50;
> vmmc-supply = <&vcc3v3_sd>;
> vqmmc-supply = <&vccio_sd>;
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-09-04 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 8:55 [PATCH] arm64: dts: rockchip: add workaround for microSD card detection on Radxa ROCK 3A FUKAUMI Naoki
2024-09-04 18:32 ` Heiko Stübner [this message]
2024-09-05 8:49 ` FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2471069.n97fhnxGW3@diego \
--to=heiko@sntech.de \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=naoki@radxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox