Re: [PATCH v8 4/6] media: platform: synopsys: Add support for HDMI input driver

From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	Shreeya Patel <shreeya.patel@collabora.com>,
	Heiko Stuebner <heiko@sntech.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	jose.abreu@synopsys.com, nelson.costa@synopsys.com,
	shawn.wen@rock-chips.com, nicolas.dufresne@collabora.com,
	Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: kernel@collabora.com, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org, Tim Surber <me@timsurber.de>
Subject: Re: [PATCH v8 4/6] media: platform: synopsys: Add support for HDMI input driver
Date: Tue, 25 Feb 2025 07:33:09 +0300	[thread overview]
Message-ID: <268834ba-f6fe-4f7b-a211-7ee2b8f0bd46@collabora.com> (raw)
In-Reply-To: <29687c3c-d983-4d1f-8cde-fde82df84e0e@wanadoo.fr>

On 2/24/25 22:16, Christophe JAILLET wrote:
> Le 24/02/2025 à 05:19, Dmitry Osipenko a écrit :
>> On 2/24/25 00:11, Christophe JAILLET wrote:
>>>>>
>>>>>> +    ret = cec_register_adapter(cec->adap, cec->dev);
>>>>>> +    if (ret < 0) {
>>>>>> +        dev_err(cec->dev, "cec register adapter failed\n");
>>>>>> +        cec_unregister_adapter(cec->adap);
>>>>>
>>>>> Is it needed to call cec_unregister_adapter() when
>>>>> cec_register_adapter() fails?
>>>>
>>>> Yes, it's confusing, but unregister is needed to free the adapter
>>>> properly, it's prepared to do it. Thanks for the review.
>>>>
>>>
>>> I don't know this API, so you'll get the last word, but
>>> cec_unregister_adapter() does not seem to do that many things in such a
>>> case, unless I miss something. See [1].
>>>
>>> CJ
>>>
>>> [1]: https://elixir.bootlin.com/linux/v6.14-rc3/source/drivers/media/
>>> cec/core/cec-core.c#L370
>>
>> On a second look, apparently you're right and
>> cec_notifier_cec_adap_unregister() should be used there.
>>
> 
> So, maybe in the .remove() function as well?

Nah, cec_unregister_adap shall be used on removal. It itself unregs
notifiers and etc.

-- 
Best regards,
Dmitry

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip