From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Shreeya Patel <shreeya.patel@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
jose.abreu@synopsys.com, nelson.costa@synopsys.com,
shawn.wen@rock-chips.com, nicolas.dufresne@collabora.com,
Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: kernel@collabora.com, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, Tim Surber <me@timsurber.de>
Subject: Re: [PATCH v8 4/6] media: platform: synopsys: Add support for HDMI input driver
Date: Mon, 24 Feb 2025 07:19:01 +0300 [thread overview]
Message-ID: <d13f13ac-1501-4427-b6d3-ee161eeb932a@collabora.com> (raw)
In-Reply-To: <bc1f5334-b0fb-4e81-979d-feb17886ac40@wanadoo.fr>
On 2/24/25 00:11, Christophe JAILLET wrote:
>>>
>>>> + ret = cec_register_adapter(cec->adap, cec->dev);
>>>> + if (ret < 0) {
>>>> + dev_err(cec->dev, "cec register adapter failed\n");
>>>> + cec_unregister_adapter(cec->adap);
>>>
>>> Is it needed to call cec_unregister_adapter() when
>>> cec_register_adapter() fails?
>>
>> Yes, it's confusing, but unregister is needed to free the adapter
>> properly, it's prepared to do it. Thanks for the review.
>>
>
> I don't know this API, so you'll get the last word, but
> cec_unregister_adapter() does not seem to do that many things in such a
> case, unless I miss something. See [1].
>
> CJ
>
> [1]: https://elixir.bootlin.com/linux/v6.14-rc3/source/drivers/media/
> cec/core/cec-core.c#L370
On a second look, apparently you're right and
cec_notifier_cec_adap_unregister() should be used there.
--
Best regards,
Dmitry
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-02-24 4:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-23 17:30 [PATCH v8 0/6] Add Synopsys DesignWare HDMI RX Controller Dmitry Osipenko
2025-02-23 17:30 ` [PATCH v8 1/6] MAINTAINERS: Add entry for Synopsys DesignWare HDMI RX Driver Dmitry Osipenko
2025-02-23 17:30 ` [PATCH v8 2/6] dt-bindings: media: Document bindings for HDMI RX Controller Dmitry Osipenko
2025-02-23 17:30 ` [PATCH v8 3/6] arm64: dts: rockchip: Add device tree support " Dmitry Osipenko
2025-02-23 17:30 ` [PATCH v8 4/6] media: platform: synopsys: Add support for HDMI input driver Dmitry Osipenko
2025-02-23 17:54 ` Christophe JAILLET
2025-02-23 18:08 ` Dmitry Osipenko
2025-02-23 21:11 ` Christophe JAILLET
2025-02-24 4:19 ` Dmitry Osipenko [this message]
2025-02-24 19:16 ` Christophe JAILLET
2025-02-25 4:33 ` Dmitry Osipenko
2025-02-23 17:30 ` [PATCH v8 5/6] arm64: defconfig: Enable Synopsys HDMI receiver Dmitry Osipenko
2025-02-23 17:30 ` [PATCH v8 6/6] arm64: dts: rockchip: Enable HDMI receiver on rock-5b Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d13f13ac-1501-4427-b6d3-ee161eeb932a@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=jose.abreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=me@timsurber.de \
--cc=nelson.costa@synopsys.com \
--cc=nicolas.dufresne@collabora.com \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawn.wen@rock-chips.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox