Re: [PATCH v5 11/12] arm64: dts: rockchip: Fix proparties for pmic regulators for Radxa ROCK 5C

From: Krzysztof Kozlowski <krzk@kernel.org>
To: FUKAUMI Naoki <naoki@radxa.com>, heiko@sntech.de
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	dsimic@manjaro.org, devicetree@vger.kernel.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v5 11/12] arm64: dts: rockchip: Fix proparties for pmic regulators for Radxa ROCK 5C
Date: Tue, 17 Dec 2024 07:24:15 +0100	[thread overview]
Message-ID: <3313fc80-73b9-4063-8076-64e65c5d5921@kernel.org> (raw)
In-Reply-To: <DC42478EC0DFB00A+6e374774-07d8-493c-9f2f-e7106d1f2d61@radxa.com>

On 17/12/2024 01:43, FUKAUMI Naoki wrote:
> On 12/16/24 22:41, Krzysztof Kozlowski wrote:
>> On 16/12/2024 12:30, FUKAUMI Naoki wrote:
>>> Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with
>>
>>
>>
>> You have so many typos in almost each commit msg. Here both in subject
>> and commit msg.
>>
>> Run spell check before you send to the lists. Don't expect the reviewers
>> to be your computer tools.
> 
> Sorry for my poor English. I'll check it next time.

I am not pointing out English. I am pointing out not using standard
tool, spellcheck, to fix issues in effortless way.

> 
>> Explain what is being fixed here. Why would you prefer to match with
>> vendor kernel?
> 
> Not my preference, but the only reference.

Then why the reference is correct? Provide some arguments why this
should be changed to the "reference" and not the "reference" fixed.

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip