From: Dragan Simic <dsimic@manjaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: FUKAUMI Naoki <naoki@radxa.com>,
heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan for Radxa ROCK 5C
Date: Mon, 16 Dec 2024 16:21:35 +0100 [thread overview]
Message-ID: <bfe16f355a4923bea704c90f18975f6a@manjaro.org> (raw)
In-Reply-To: <2a811610-b132-47a2-973b-6a9cb7956c43@kernel.org>
Hello Krzysztof,
On 2024-12-16 14:42, Krzysztof Kozlowski wrote:
> On 16/12/2024 13:43, Dragan Simic wrote:
>> On 2024-12-16 12:30, FUKAUMI Naoki wrote:
>>> Use more common name "pwm-fan" for pwm-fan node. No functinal change.
>>>
>>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
>>
>> Looking good to me, as a preparatory patch. Please, feel free
>> to include:
>>
>> Reviewed-by: Dragan Simic <dsimic@manjaro.org>
>
> That's just incorrect. If you really want to review such trivial
> patches, perform a full review.
Well, I don't see what's wrong with reviewing two fan-related patches
that go together? Moreover, in this case it's about using a generic
name, which you prefer, or using a more common name, which I prefer.
However, as a maintainer, your preference matters more.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-12-16 15:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 11:30 [PATCH v5 00/12] arm64: dts: rockchip: Refine dts for Radxa ROCK 5C FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 01/12] arm64: dts: rockchip: Change function name for blue LED " FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 02/12] arm64: dts: rockchip: Change node name for pwm-fan " FUKAUMI Naoki
2024-12-16 12:43 ` Dragan Simic
2024-12-16 13:42 ` Krzysztof Kozlowski
2024-12-16 15:21 ` Dragan Simic [this message]
2024-12-16 13:37 ` Krzysztof Kozlowski
2024-12-16 13:48 ` FUKAUMI Naoki
2024-12-16 13:56 ` Krzysztof Kozlowski
2024-12-16 14:19 ` FUKAUMI Naoki
2024-12-16 14:27 ` Krzysztof Kozlowski
2024-12-16 14:38 ` FUKAUMI Naoki
2024-12-16 15:26 ` Dragan Simic
2024-12-16 16:11 ` Diederik de Haas
2024-12-16 11:30 ` [PATCH v5 03/12] arm64: dts: rockchip: Use a longer PWM period for the fan on " FUKAUMI Naoki
2024-12-16 12:43 ` Dragan Simic
2024-12-16 11:30 ` [PATCH v5 04/12] arm64: dts: rockchip: Rename regulator for pcie2x1l2 for " FUKAUMI Naoki
2024-12-16 13:38 ` Krzysztof Kozlowski
2024-12-16 13:55 ` FUKAUMI Naoki
2024-12-17 1:11 ` FUKAUMI Naoki
2024-12-20 6:51 ` FUKAUMI Naoki
2024-12-21 20:15 ` Krzysztof Kozlowski
2024-12-22 3:18 ` FUKAUMI Naoki
2024-12-22 6:27 ` Krzysztof Kozlowski
2024-12-22 17:46 ` Dragan Simic
2024-12-16 11:30 ` [PATCH v5 05/12] arm64: dts: rockchip: Add properties " FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 06/12] arm64: dts: rockchip: Remove RTC and related node " FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 07/12] arm64: dts: rockchip: Separate pinctrl for vcc_5v0 " FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 08/12] arm64: dts: rockchip: Add cd-gpios for sdmmc " FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 09/12] arm64: dts: rockchip: Fix pmic dcdc-reg7 regulator-name " FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 10/12] arm64: dts: rockchip: Fix pmic dcdc-reg10 label " FUKAUMI Naoki
2024-12-16 13:40 ` Krzysztof Kozlowski
2024-12-17 0:47 ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 11/12] arm64: dts: rockchip: Fix proparties for pmic regulators " FUKAUMI Naoki
2024-12-16 13:41 ` Krzysztof Kozlowski
2024-12-17 0:43 ` FUKAUMI Naoki
2024-12-17 6:24 ` Krzysztof Kozlowski
2024-12-17 7:16 ` FUKAUMI Naoki
2024-12-16 11:30 ` [PATCH v5 12/12] arm64: dts: rockchip: Sort nodes " FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfe16f355a4923bea704c90f18975f6a@manjaro.org \
--to=dsimic@manjaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox