* Re: [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible string
2022-08-29 6:50 [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible string Anand Moon
@ 2022-08-29 10:20 ` Heiko Stübner
2022-08-30 9:51 ` Krzysztof Kozlowski
2022-08-30 10:00 ` Jagan Teki
2 siblings, 0 replies; 5+ messages in thread
From: Heiko Stübner @ 2022-08-29 10:20 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, David Wu, Anand Moon
Cc: Jagan Teki, netdev, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
Am Montag, 29. August 2022, 08:50:41 CEST schrieb Anand Moon:
> Add compatible string for RV1126 gmac, and constrain it to
> be compatible with Synopsys dwmac 4.20a.
>
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> Signed-off-by: Anand Moon <anand@edgeble.ai>
> ---
> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index 083623c8d718..346e248a6ba5 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -26,6 +26,7 @@ select:
> - rockchip,rk3399-gmac
> - rockchip,rk3568-gmac
> - rockchip,rv1108-gmac
> + - rockchip,rv1126-gmac
> required:
> - compatible
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible string
2022-08-29 6:50 [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible string Anand Moon
2022-08-29 10:20 ` Heiko Stübner
@ 2022-08-30 9:51 ` Krzysztof Kozlowski
2022-09-01 7:06 ` Anand Moon
2022-08-30 10:00 ` Jagan Teki
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-08-30 9:51 UTC (permalink / raw)
To: Anand Moon, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Heiko Stuebner,
David Wu
Cc: Jagan Teki, netdev, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
On 29/08/2022 09:50, Anand Moon wrote:
> Add compatible string for RV1126 gmac, and constrain it to
> be compatible with Synopsys dwmac 4.20a.
>
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> Signed-off-by: Anand Moon <anand@edgeble.ai>
> ---
> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index 083623c8d718..346e248a6ba5 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -26,6 +26,7 @@ select:
> - rockchip,rk3399-gmac
> - rockchip,rk3568-gmac
> - rockchip,rv1108-gmac
> + - rockchip,rv1126-gmac
That's not a complete change. What about the other place listing
compatibles? Did you test the bindings on your DTS?
Best regards,
Krzysztof
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible string
2022-08-30 9:51 ` Krzysztof Kozlowski
@ 2022-09-01 7:06 ` Anand Moon
0 siblings, 0 replies; 5+ messages in thread
From: Anand Moon @ 2022-09-01 7:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, David Wu,
Jagan Teki, netdev, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
Hi Krzysztof,
On Tue, 30 Aug 2022 at 15:21, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 29/08/2022 09:50, Anand Moon wrote:
> > Add compatible string for RV1126 gmac, and constrain it to
> > be compatible with Synopsys dwmac 4.20a.
> >
> > Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> > Signed-off-by: Anand Moon <anand@edgeble.ai>
> > ---
> > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> > index 083623c8d718..346e248a6ba5 100644
> > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> > @@ -26,6 +26,7 @@ select:
> > - rockchip,rk3399-gmac
> > - rockchip,rk3568-gmac
> > - rockchip,rv1108-gmac
> > + - rockchip,rv1126-gmac
>
> That's not a complete change. What about the other place listing
> compatibles? Did you test the bindings on your DTS?
>
Yes, I missed the properties menu, will update it in the next version.
>
> Best regards,
> Krzysztof
Thanks
-Anand
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible string
2022-08-29 6:50 [PATCH 1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible string Anand Moon
2022-08-29 10:20 ` Heiko Stübner
2022-08-30 9:51 ` Krzysztof Kozlowski
@ 2022-08-30 10:00 ` Jagan Teki
2 siblings, 0 replies; 5+ messages in thread
From: Jagan Teki @ 2022-08-30 10:00 UTC (permalink / raw)
To: Anand Moon
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, David Wu,
netdev, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
On Mon, 29 Aug 2022 at 12:23, Anand Moon <anand@edgeble.ai> wrote:
>
> Add compatible string for RV1126 gmac, and constrain it to
> be compatible with Synopsys dwmac 4.20a.
>
> Signed-off-by: Jagan Teki <jagan@edgeble.ai>
> Signed-off-by: Anand Moon <anand@edgeble.ai>
> ---
> Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index 083623c8d718..346e248a6ba5 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -26,6 +26,7 @@ select:
> - rockchip,rk3399-gmac
> - rockchip,rk3568-gmac
> - rockchip,rv1108-gmac
> + - rockchip,rv1126-gmac
it needs to be in the properties menu as well.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread