From: Heiko Stuebner <heiko@sntech.de>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Daniele Castagna <dcastagna@chromium.org>,
dri-devel@lists.freedesktop.org, Tomasz Figa <tfiga@chromium.org>,
linux-rockchip@lists.infradead.org,
Sean Paul <seanpaul@chromium.org>,
"Kristian H . Kristensen" <hoegsberg@chromium.org>,
kernel@collabora.com
Subject: Re: [PATCH 0/3] Support reflect-x/y on RK3328, RK3368, and RK3399
Date: Fri, 11 Jan 2019 00:55:16 +0100 [thread overview]
Message-ID: <4156121.KF0xb9tBSE@phil> (raw)
In-Reply-To: <20190109185639.5093-1-ezequiel@collabora.com>
Am Mittwoch, 9. Januar 2019, 19:56:36 CET schrieb Ezequiel Garcia:
> Here's a small series supporting plane reflection (aka. mirroring)
> properties on RK3328, RK3368, and RK3399 SoCs.
>
> Note that RK3288 specification doesn't seem to document registers
> for plane mirroring, but instead it only seems to support mirroring
> at the display (CRTC) level.
>
> A small typo cleanup patch is included, in patch 1. Not related
> to the rotation stuff.
>
> In order to support this feature, patch 2 separates the register
> set for win0 and win1.
>
> Once that's done, patch 3 creates the properties, if supported
> by each plane/SoC.
>
> The following modetest commands would test this feature,
> where 30 is the plane ID, and 49 = rotate_0 + relect_y + reflect_x.
>
> X mirror:
> modetest -s 43@33:1920x1080@XR24 -w 30:rotation:17
>
> Y mirror:
> modetest -s 43@33:1920x1080@XR24 -w 30:rotation:33
>
> XY mirror:
> modetest -s 43@33:1920x1080@XR24 -w 30:rotation:49
>
> This work has been originally by Daniele. I just cleaned
> up the implementation a it, and ported the code to upstream.
>
> This series is based on drm-misc-next plus https://patchwork.kernel.org/patch/10752893/.
applied all 3 to drm-misc-next
Thanks a lot for also catching that register issue.
Heiko
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-01-10 23:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 18:56 [PATCH 0/3] Support reflect-x/y on RK3328, RK3368, and RK3399 Ezequiel Garcia
2019-01-09 18:56 ` [PATCH 1/3] drm/rockchip: Fix typo in VOP macros argument Ezequiel Garcia
2019-01-09 18:56 ` [PATCH 2/3] drm/rockchip: Separate RK3288 from RK3368 win01 registers Ezequiel Garcia
2019-01-09 18:56 ` [PATCH 3/3] drm/rockchip: Add reflection properties Ezequiel Garcia
2019-01-10 23:55 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4156121.KF0xb9tBSE@phil \
--to=heiko@sntech.de \
--cc=dcastagna@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ezequiel@collabora.com \
--cc=hoegsberg@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=seanpaul@chromium.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox