* [PATCH] arm64: dts: rockchip: move backlight from sapphire to excavator
@ 2018-10-30 15:00 Vicente Bergas
[not found] ` <20181030150049.16064-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Vicente Bergas @ 2018-10-30 15:00 UTC (permalink / raw)
To: Heiko Stuebner, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: Vicente Bergas
The backlight is for the eDP panel and it has the connector on the excavator baseboard.
Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
.../rockchip/rk3399-sapphire-excavator.dts | 46 +++++++++++++++++--
.../boot/dts/rockchip/rk3399-sapphire.dtsi | 39 ----------------
2 files changed, 41 insertions(+), 44 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts b/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
index fef2c0608..0b8f1edbd 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
@@ -42,6 +42,47 @@
};
};
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ brightness-levels = <
+ 0 1 2 3 4 5 6 7
+ 8 9 10 11 12 13 14 15
+ 16 17 18 19 20 21 22 23
+ 24 25 26 27 28 29 30 31
+ 32 33 34 35 36 37 38 39
+ 40 41 42 43 44 45 46 47
+ 48 49 50 51 52 53 54 55
+ 56 57 58 59 60 61 62 63
+ 64 65 66 67 68 69 70 71
+ 72 73 74 75 76 77 78 79
+ 80 81 82 83 84 85 86 87
+ 88 89 90 91 92 93 94 95
+ 96 97 98 99 100 101 102 103
+ 104 105 106 107 108 109 110 111
+ 112 113 114 115 116 117 118 119
+ 120 121 122 123 124 125 126 127
+ 128 129 130 131 132 133 134 135
+ 136 137 138 139 140 141 142 143
+ 144 145 146 147 148 149 150 151
+ 152 153 154 155 156 157 158 159
+ 160 161 162 163 164 165 166 167
+ 168 169 170 171 172 173 174 175
+ 176 177 178 179 180 181 182 183
+ 184 185 186 187 188 189 190 191
+ 192 193 194 195 196 197 198 199
+ 200 201 202 203 204 205 206 207
+ 208 209 210 211 212 213 214 215
+ 216 217 218 219 220 221 222 223
+ 224 225 226 227 228 229 230 231
+ 232 233 234 235 236 237 238 239
+ 240 241 242 243 244 245 246 247
+ 248 249 250 251 252 253 254 255>;
+ default-brightness-level = <200>;
+ enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
+ pwms = <&pwm0 0 25000 0>;
+ status = "okay";
+ };
+
edp_panel: edp-panel {
compatible ="lg,lp079qx1-sp0v", "simple-panel";
backlight = <&backlight>;
@@ -95,11 +136,6 @@
};
};
-&backlight {
- enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
- status = "okay";
-};
-
&edp {
status = "okay";
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
index 2eb6489d4..6ce5a42c9 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
@@ -15,45 +15,6 @@
stdout-path = "serial2:1500000n8";
};
- backlight: backlight {
- compatible = "pwm-backlight";
- brightness-levels = <
- 0 1 2 3 4 5 6 7
- 8 9 10 11 12 13 14 15
- 16 17 18 19 20 21 22 23
- 24 25 26 27 28 29 30 31
- 32 33 34 35 36 37 38 39
- 40 41 42 43 44 45 46 47
- 48 49 50 51 52 53 54 55
- 56 57 58 59 60 61 62 63
- 64 65 66 67 68 69 70 71
- 72 73 74 75 76 77 78 79
- 80 81 82 83 84 85 86 87
- 88 89 90 91 92 93 94 95
- 96 97 98 99 100 101 102 103
- 104 105 106 107 108 109 110 111
- 112 113 114 115 116 117 118 119
- 120 121 122 123 124 125 126 127
- 128 129 130 131 132 133 134 135
- 136 137 138 139 140 141 142 143
- 144 145 146 147 148 149 150 151
- 152 153 154 155 156 157 158 159
- 160 161 162 163 164 165 166 167
- 168 169 170 171 172 173 174 175
- 176 177 178 179 180 181 182 183
- 184 185 186 187 188 189 190 191
- 192 193 194 195 196 197 198 199
- 200 201 202 203 204 205 206 207
- 208 209 210 211 212 213 214 215
- 216 217 218 219 220 221 222 223
- 224 225 226 227 228 229 230 231
- 232 233 234 235 236 237 238 239
- 240 241 242 243 244 245 246 247
- 248 249 250 251 252 253 254 255>;
- default-brightness-level = <200>;
- pwms = <&pwm0 0 25000 0>;
- };
-
clkin_gmac: external-gmac-clock {
compatible = "fixed-clock";
clock-frequency = <125000000>;
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: move backlight from sapphire to excavator
[not found] ` <20181030150049.16064-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2018-10-30 16:58 ` Enric Balletbo Serra
[not found] ` <CAFqH_51Bk4RhS5+866XUL_qXTnofg92yT6Yig9gNVytAt+H=bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-02 12:12 ` Heiko Stuebner
1 sibling, 1 reply; 6+ messages in thread
From: Enric Balletbo Serra @ 2018-10-30 16:58 UTC (permalink / raw)
To: vicencb-Re5JQEeQqe8AvxtiuMwx3w
Cc: open list:ARM/Rockchip SoC..., Heiko Stübner
Hi Vicente,
Missatge de Vicente Bergas <vicencb@gmail.com> del dia dt., 30 d’oct.
2018 a les 16:21:
>
> The backlight is for the eDP panel and it has the connector on the excavator baseboard.
>
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> ---
> .../rockchip/rk3399-sapphire-excavator.dts | 46 +++++++++++++++++--
> .../boot/dts/rockchip/rk3399-sapphire.dtsi | 39 ----------------
> 2 files changed, 41 insertions(+), 44 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts b/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
> index fef2c0608..0b8f1edbd 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
> @@ -42,6 +42,47 @@
> };
> };
>
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + brightness-levels = <
> + 0 1 2 3 4 5 6 7
> + 8 9 10 11 12 13 14 15
> + 16 17 18 19 20 21 22 23
> + 24 25 26 27 28 29 30 31
> + 32 33 34 35 36 37 38 39
> + 40 41 42 43 44 45 46 47
> + 48 49 50 51 52 53 54 55
> + 56 57 58 59 60 61 62 63
> + 64 65 66 67 68 69 70 71
> + 72 73 74 75 76 77 78 79
> + 80 81 82 83 84 85 86 87
> + 88 89 90 91 92 93 94 95
> + 96 97 98 99 100 101 102 103
> + 104 105 106 107 108 109 110 111
> + 112 113 114 115 116 117 118 119
> + 120 121 122 123 124 125 126 127
> + 128 129 130 131 132 133 134 135
> + 136 137 138 139 140 141 142 143
> + 144 145 146 147 148 149 150 151
> + 152 153 154 155 156 157 158 159
> + 160 161 162 163 164 165 166 167
> + 168 169 170 171 172 173 174 175
> + 176 177 178 179 180 181 182 183
> + 184 185 186 187 188 189 190 191
> + 192 193 194 195 196 197 198 199
> + 200 201 202 203 204 205 206 207
> + 208 209 210 211 212 213 214 215
> + 216 217 218 219 220 221 222 223
> + 224 225 226 227 228 229 230 231
> + 232 233 234 235 236 237 238 239
> + 240 241 242 243 244 245 246 247
> + 248 249 250 251 252 253 254 255>;
> + default-brightness-level = <200>;
Could you try if just removing the brightness-level table and
default-brightness-level properties gives you a good backlight
experience?
After commit 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED
linearly to human eye") the pwm_bl driver is able to calculate a default
brightness table. The calculated table for this PWM will have more
granularity and will be adjusted to change the brightness linearly to
the human eye.
If it works maybe we can just get rid of this awful brightness-table.
Best regards,
Enric
> + enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
> + pwms = <&pwm0 0 25000 0>;
> + status = "okay";
> + };
> +
> edp_panel: edp-panel {
> compatible ="lg,lp079qx1-sp0v", "simple-panel";
> backlight = <&backlight>;
> @@ -95,11 +136,6 @@
> };
> };
>
> -&backlight {
> - enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
> - status = "okay";
> -};
> -
> &edp {
> status = "okay";
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> index 2eb6489d4..6ce5a42c9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> @@ -15,45 +15,6 @@
> stdout-path = "serial2:1500000n8";
> };
>
> - backlight: backlight {
> - compatible = "pwm-backlight";
> - brightness-levels = <
> - 0 1 2 3 4 5 6 7
> - 8 9 10 11 12 13 14 15
> - 16 17 18 19 20 21 22 23
> - 24 25 26 27 28 29 30 31
> - 32 33 34 35 36 37 38 39
> - 40 41 42 43 44 45 46 47
> - 48 49 50 51 52 53 54 55
> - 56 57 58 59 60 61 62 63
> - 64 65 66 67 68 69 70 71
> - 72 73 74 75 76 77 78 79
> - 80 81 82 83 84 85 86 87
> - 88 89 90 91 92 93 94 95
> - 96 97 98 99 100 101 102 103
> - 104 105 106 107 108 109 110 111
> - 112 113 114 115 116 117 118 119
> - 120 121 122 123 124 125 126 127
> - 128 129 130 131 132 133 134 135
> - 136 137 138 139 140 141 142 143
> - 144 145 146 147 148 149 150 151
> - 152 153 154 155 156 157 158 159
> - 160 161 162 163 164 165 166 167
> - 168 169 170 171 172 173 174 175
> - 176 177 178 179 180 181 182 183
> - 184 185 186 187 188 189 190 191
> - 192 193 194 195 196 197 198 199
> - 200 201 202 203 204 205 206 207
> - 208 209 210 211 212 213 214 215
> - 216 217 218 219 220 221 222 223
> - 224 225 226 227 228 229 230 231
> - 232 233 234 235 236 237 238 239
> - 240 241 242 243 244 245 246 247
> - 248 249 250 251 252 253 254 255>;
> - default-brightness-level = <200>;
> - pwms = <&pwm0 0 25000 0>;
> - };
> -
> clkin_gmac: external-gmac-clock {
> compatible = "fixed-clock";
> clock-frequency = <125000000>;
> --
> 2.19.1
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: move backlight from sapphire to excavator
[not found] ` <CAFqH_51Bk4RhS5+866XUL_qXTnofg92yT6Yig9gNVytAt+H=bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-10-30 17:19 ` Vicente Bergas
0 siblings, 0 replies; 6+ messages in thread
From: Vicente Bergas @ 2018-10-30 17:19 UTC (permalink / raw)
To: eballetbo-Re5JQEeQqe8AvxtiuMwx3w
Cc: open list:ARM/Rockchip SoC..., Heiko Stübner
On Tue, Oct 30, 2018 at 5:59 PM Enric Balletbo Serra
<eballetbo@gmail.com> wrote:
>
> Hi Vicente,
>
> Missatge de Vicente Bergas <vicencb@gmail.com> del dia dt., 30 d’oct.
> 2018 a les 16:21:
> >
> > The backlight is for the eDP panel and it has the connector on the excavator baseboard.
> >
> > Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> > ---
> > .../rockchip/rk3399-sapphire-excavator.dts | 46 +++++++++++++++++--
> > .../boot/dts/rockchip/rk3399-sapphire.dtsi | 39 ----------------
> > 2 files changed, 41 insertions(+), 44 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts b/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
> > index fef2c0608..0b8f1edbd 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts
> > @@ -42,6 +42,47 @@
> > };
> > };
> >
> > + backlight: backlight {
> > + compatible = "pwm-backlight";
> > + brightness-levels = <
> > + 0 1 2 3 4 5 6 7
...
> > + 248 249 250 251 252 253 254 255>;
> > + default-brightness-level = <200>;
>
> Could you try if just removing the brightness-level table and
> default-brightness-level properties gives you a good backlight
> experience?
>
> After commit 88ba95bedb79 ("backlight: pwm_bl: Compute brightness of LED
> linearly to human eye") the pwm_bl driver is able to calculate a default
> brightness table. The calculated table for this PWM will have more
> granularity and will be adjusted to change the brightness linearly to
> the human eye.
>
> If it works maybe we can just get rid of this awful brightness-table.
I have tested that it does not break the Sapphire daugther-board,
but have no Excavator base-board to test, i have just checked that
the resulting decompiled dtb is equivalent.
Regards,
Vicenç.
> Best regards,
> Enric
>
> > + enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
> > + pwms = <&pwm0 0 25000 0>;
> > + status = "okay";
> > + };
> > +
> > edp_panel: edp-panel {
> > compatible ="lg,lp079qx1-sp0v", "simple-panel";
> > backlight = <&backlight>;
> > @@ -95,11 +136,6 @@
> > };
> > };
> >
> > -&backlight {
> > - enable-gpios = <&gpio1 RK_PB5 GPIO_ACTIVE_HIGH>;
> > - status = "okay";
> > -};
> > -
> > &edp {
> > status = "okay";
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> > index 2eb6489d4..6ce5a42c9 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> > @@ -15,45 +15,6 @@
> > stdout-path = "serial2:1500000n8";
> > };
> >
> > - backlight: backlight {
> > - compatible = "pwm-backlight";
> > - brightness-levels = <
> > - 0 1 2 3 4 5 6 7
...
> > - 248 249 250 251 252 253 254 255>;
> > - default-brightness-level = <200>;
> > - pwms = <&pwm0 0 25000 0>;
> > - };
> > -
> > clkin_gmac: external-gmac-clock {
> > compatible = "fixed-clock";
> > clock-frequency = <125000000>;
> > --
> > 2.19.1
> >
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: move backlight from sapphire to excavator
[not found] ` <20181030150049.16064-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-10-30 16:58 ` Enric Balletbo Serra
@ 2018-11-02 12:12 ` Heiko Stuebner
2018-11-02 12:20 ` Vicente Bergas
1 sibling, 1 reply; 6+ messages in thread
From: Heiko Stuebner @ 2018-11-02 12:12 UTC (permalink / raw)
To: Vicente Bergas, Enric Balletbo Serra
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am Dienstag, 30. Oktober 2018, 16:00:49 CET schrieb Vicente Bergas:
> The backlight is for the eDP panel and it has the connector on the excavator baseboard.
>
> Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
applied for 4.21 (or whatever it will be called)
The patch itself is good, as it as Vicene said only moved the elements
and the resulting dtb stays identical for excavator.
Enric, you can propose a patch on top, that removes the backlight
elements. That way if someone really finds an issue with it, we
have a clean revert path, which still keeps Vicente's move intact.
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: move backlight from sapphire to excavator
2018-11-02 12:12 ` Heiko Stuebner
@ 2018-11-02 12:20 ` Vicente Bergas
[not found] ` <CAAMcf8CuHWWEUF=C4B=ZdyjR=gv5M2N+GBRQ1DjXUs7L704yRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Vicente Bergas @ 2018-11-02 12:20 UTC (permalink / raw)
To: Heiko Stübner; +Cc: Enric Balletbo Serra, open list:ARM/Rockchip SoC...
On Fri, Nov 2, 2018 at 1:12 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> Am Dienstag, 30. Oktober 2018, 16:00:49 CET schrieb Vicente Bergas:
> > The backlight is for the eDP panel and it has the connector on the excavator baseboard.
> >
> > Signed-off-by: Vicente Bergas <vicencb@gmail.com>
>
> applied for 4.21 (or whatever it will be called)
>
> The patch itself is good, as it as Vicene said only moved the elements
> and the resulting dtb stays identical for excavator.
Just a note: the resulting excavator dtb is different, in the decompiled dts
i saw a few phandles and other ids moved around, to the best of my knowledge
it looked equivalent to me.
Regards,
Vicenç.
>
> Enric, you can propose a patch on top, that removes the backlight
> elements. That way if someone really finds an issue with it, we
> have a clean revert path, which still keeps Vicente's move intact.
>
>
> Heiko
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: move backlight from sapphire to excavator
[not found] ` <CAAMcf8CuHWWEUF=C4B=ZdyjR=gv5M2N+GBRQ1DjXUs7L704yRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-11-02 12:22 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2018-11-02 12:22 UTC (permalink / raw)
To: Vicente Bergas; +Cc: Enric Balletbo Serra, open list:ARM/Rockchip SoC...
Am Freitag, 2. November 2018, 13:20:39 CET schrieb Vicente Bergas:
> On Fri, Nov 2, 2018 at 1:12 PM Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> wrote:
> >
> > Am Dienstag, 30. Oktober 2018, 16:00:49 CET schrieb Vicente Bergas:
> > > The backlight is for the eDP panel and it has the connector on the excavator baseboard.
> > >
> > > Signed-off-by: Vicente Bergas <vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >
> > applied for 4.21 (or whatever it will be called)
> >
> > The patch itself is good, as it as Vicene said only moved the elements
> > and the resulting dtb stays identical for excavator.
>
> Just a note: the resulting excavator dtb is different, in the decompiled dts
> i saw a few phandles and other ids moved around, to the best of my knowledge
> it looked equivalent to me.
I think that is to be expected, as the ids generated from phandles of
course are just counting upwards depending on the ordering and as
things moved from one file to another one should expect the ordering
beeing changed :-)
Also the dts-side changes looks equivalent, so we should be good anyway.
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-02 12:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-30 15:00 [PATCH] arm64: dts: rockchip: move backlight from sapphire to excavator Vicente Bergas
[not found] ` <20181030150049.16064-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-10-30 16:58 ` Enric Balletbo Serra
[not found] ` <CAFqH_51Bk4RhS5+866XUL_qXTnofg92yT6Yig9gNVytAt+H=bg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-10-30 17:19 ` Vicente Bergas
2018-11-02 12:12 ` Heiko Stuebner
2018-11-02 12:20 ` Vicente Bergas
[not found] ` <CAAMcf8CuHWWEUF=C4B=ZdyjR=gv5M2N+GBRQ1DjXUs7L704yRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-11-02 12:22 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox