* [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1
@ 2016-08-26 6:22 Xing Zheng
[not found] ` <1472192551-16754-1-git-send-email-zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Xing Zheng @ 2016-08-26 6:22 UTC (permalink / raw)
To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Cc: huangtao-TNX95d0MmH7DzftRWevZcw, Mark Rutland, Elaine Zhang,
Heiko Stuebner, Xing Zheng, devicetree-u79uwXL29TY76Z2rM5mHXA,
Catalin Marinas, Brian Norris, Will Deacon,
dianders-F7+t8E8rja9g9hUCZPvPmw,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Masahiro Yamada, Rob Herring,
David Wu, jay.xu-TNX95d0MmH7DzftRWevZcw,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Caesar Wang
Dues to incorrect description in the TRM, the WDTs base address
should be fixed and swap them like this:
WDT0 - 0xff848000
WDT1 - 0xff840000
And, it is right that only WDT0 can generate global software reset.
We will update the TRM to fix it.
Signed-off-by: Xing Zheng <zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index bc86e8c..f0f52c1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1002,9 +1002,9 @@
};
};
- watchdog@ff840000 {
+ watchdog@ff848000 {
compatible = "snps,dw-wdt";
- reg = <0x0 0xff840000 0x0 0x100>;
+ reg = <0x0 0xff848000 0x0 0x100>;
clocks = <&cru PCLK_WDT>;
interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1472192551-16754-1-git-send-email-zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>]
* Re: [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1 [not found] ` <1472192551-16754-1-git-send-email-zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org> @ 2016-08-26 9:41 ` Shawn Lin [not found] ` <607537bf-1c49-d7e0-ead9-8c1e6164e44e-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Shawn Lin @ 2016-08-26 9:41 UTC (permalink / raw) To: Xing Zheng, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: shawn.lin-TNX95d0MmH7DzftRWevZcw, huangtao-TNX95d0MmH7DzftRWevZcw, Mark Rutland, Elaine Zhang, Heiko Stuebner, devicetree-u79uwXL29TY76Z2rM5mHXA, Catalin Marinas, Brian Norris, Will Deacon, dianders-F7+t8E8rja9g9hUCZPvPmw, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Masahiro Yamada, Rob Herring, David Wu, jay.xu-TNX95d0MmH7DzftRWevZcw, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Caesar Wang On 2016/8/26 14:22, Xing Zheng wrote: > Dues to incorrect description in the TRM, the WDTs base address > should be fixed and swap them like this: > WDT0 - 0xff848000 > WDT1 - 0xff840000 > > And, it is right that only WDT0 can generate global software reset. > We will update the TRM to fix it. > > Signed-off-by: Xing Zheng <zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org> > --- > > arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > index bc86e8c..f0f52c1 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi > @@ -1002,9 +1002,9 @@ > }; > }; > > - watchdog@ff840000 { > + watchdog@ff848000 { Just a nit, should we mark this explicitly as "watchdog0" ? I still need to look up for which wdt you are using.:) > compatible = "snps,dw-wdt"; > - reg = <0x0 0xff840000 0x0 0x100>; > + reg = <0x0 0xff848000 0x0 0x100>; > clocks = <&cru PCLK_WDT>; > interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; > }; > -- Best Regards Shawn Lin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <607537bf-1c49-d7e0-ead9-8c1e6164e44e-TNX95d0MmH7DzftRWevZcw@public.gmane.org>]
* Re: [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1 [not found] ` <607537bf-1c49-d7e0-ead9-8c1e6164e44e-TNX95d0MmH7DzftRWevZcw@public.gmane.org> @ 2016-08-26 10:49 ` Xing Zheng 0 siblings, 0 replies; 3+ messages in thread From: Xing Zheng @ 2016-08-26 10:49 UTC (permalink / raw) To: Shawn Lin Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, huangtao-TNX95d0MmH7DzftRWevZcw, Mark Rutland, Elaine Zhang, Heiko Stuebner, devicetree-u79uwXL29TY76Z2rM5mHXA, Catalin Marinas, Brian Norris, Will Deacon, dianders-F7+t8E8rja9g9hUCZPvPmw, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Masahiro Yamada, Rob Herring, David Wu, jay.xu-TNX95d0MmH7DzftRWevZcw, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Caesar Wang Hi Shawn, On 2016年08月26日 17:41, Shawn Lin wrote: > On 2016/8/26 14:22, Xing Zheng wrote: >> Dues to incorrect description in the TRM, the WDTs base address >> should be fixed and swap them like this: >> WDT0 - 0xff848000 >> WDT1 - 0xff840000 >> >> And, it is right that only WDT0 can generate global software reset. >> We will update the TRM to fix it. >> >> Signed-off-by: Xing Zheng <zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org> >> --- >> >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> index bc86e8c..f0f52c1 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -1002,9 +1002,9 @@ >> }; >> }; >> >> - watchdog@ff840000 { >> + watchdog@ff848000 { > > Just a nit, should we mark this explicitly as "watchdog0" ? > I still need to look up for which wdt you are using.:) Done. Thanks. > >> compatible = "snps,dw-wdt"; >> - reg = <0x0 0xff840000 0x0 0x100>; >> + reg = <0x0 0xff848000 0x0 0x100>; >> clocks = <&cru PCLK_WDT>; >> interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>; >> }; >> > > -- - Xing Zheng -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-26 10:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-26 6:22 [PATCH] arm64: dts: rockchip: fix the address map for WDT0 and WDT1 Xing Zheng
[not found] ` <1472192551-16754-1-git-send-email-zhengxing-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-26 9:41 ` Shawn Lin
[not found] ` <607537bf-1c49-d7e0-ead9-8c1e6164e44e-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-26 10:49 ` Xing Zheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox