* [PATCH 0/2] pinctrl: trivial: remove unneeded (void *) casts in of_match_table @ 2017-04-25 21:34 Masahiro Yamada 2017-04-25 21:34 ` [PATCH 1/2] pinctrl: rockchip: " Masahiro Yamada 0 siblings, 1 reply; 3+ messages in thread From: Masahiro Yamada @ 2017-04-25 21:34 UTC (permalink / raw) To: linux-gpio Cc: linux-samsung-soc, Heiko Stuebner, linux-rockchip, Linus Walleij, linux-kernel, Krzysztof Kozlowski, Tomasz Figa, Masahiro Yamada, Sylwester Nawrocki, linux-arm-kernel Masahiro Yamada (2): pinctrl: rockchip: remove unneeded (void *) casts in of_match_table pinctrl: samsung: remove unneeded (void *) casts in of_match_table drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++---------- drivers/pinctrl/samsung/pinctrl-samsung.c | 20 ++++++++++---------- 2 files changed, 20 insertions(+), 20 deletions(-) -- 2.7.4 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] pinctrl: rockchip: remove unneeded (void *) casts in of_match_table 2017-04-25 21:34 [PATCH 0/2] pinctrl: trivial: remove unneeded (void *) casts in of_match_table Masahiro Yamada @ 2017-04-25 21:34 ` Masahiro Yamada 2017-04-25 22:11 ` Heiko Stübner 0 siblings, 1 reply; 3+ messages in thread From: Masahiro Yamada @ 2017-04-25 21:34 UTC (permalink / raw) To: linux-gpio Cc: Masahiro Yamada, Heiko Stuebner, linux-rockchip, Linus Walleij, linux-kernel, linux-arm-kernel of_device_id::data is an opaque pointer. No explicit cast is needed. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 7813599..da1a38f 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -2769,25 +2769,25 @@ static struct rockchip_pin_ctrl rk3399_pin_ctrl = { static const struct of_device_id rockchip_pinctrl_dt_match[] = { { .compatible = "rockchip,rk1108-pinctrl", - .data = (void *)&rk1108_pin_ctrl }, + .data = &rk1108_pin_ctrl }, { .compatible = "rockchip,rk2928-pinctrl", - .data = (void *)&rk2928_pin_ctrl }, + .data = &rk2928_pin_ctrl }, { .compatible = "rockchip,rk3036-pinctrl", - .data = (void *)&rk3036_pin_ctrl }, + .data = &rk3036_pin_ctrl }, { .compatible = "rockchip,rk3066a-pinctrl", - .data = (void *)&rk3066a_pin_ctrl }, + .data = &rk3066a_pin_ctrl }, { .compatible = "rockchip,rk3066b-pinctrl", - .data = (void *)&rk3066b_pin_ctrl }, + .data = &rk3066b_pin_ctrl }, { .compatible = "rockchip,rk3188-pinctrl", - .data = (void *)&rk3188_pin_ctrl }, + .data = &rk3188_pin_ctrl }, { .compatible = "rockchip,rk3228-pinctrl", - .data = (void *)&rk3228_pin_ctrl }, + .data = &rk3228_pin_ctrl }, { .compatible = "rockchip,rk3288-pinctrl", - .data = (void *)&rk3288_pin_ctrl }, + .data = &rk3288_pin_ctrl }, { .compatible = "rockchip,rk3368-pinctrl", - .data = (void *)&rk3368_pin_ctrl }, + .data = &rk3368_pin_ctrl }, { .compatible = "rockchip,rk3399-pinctrl", - .data = (void *)&rk3399_pin_ctrl }, + .data = &rk3399_pin_ctrl }, {}, }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] pinctrl: rockchip: remove unneeded (void *) casts in of_match_table 2017-04-25 21:34 ` [PATCH 1/2] pinctrl: rockchip: " Masahiro Yamada @ 2017-04-25 22:11 ` Heiko Stübner 0 siblings, 0 replies; 3+ messages in thread From: Heiko Stübner @ 2017-04-25 22:11 UTC (permalink / raw) To: Masahiro Yamada Cc: linux-gpio, linux-rockchip, Linus Walleij, linux-kernel, linux-arm-kernel Hi, Am Mittwoch, 26. April 2017, 06:34:22 CEST schrieb Masahiro Yamada: > of_device_id::data is an opaque pointer. No explicit cast is needed. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > drivers/pinctrl/pinctrl-rockchip.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-rockchip.c > b/drivers/pinctrl/pinctrl-rockchip.c index 7813599..da1a38f 100644 > --- a/drivers/pinctrl/pinctrl-rockchip.c > +++ b/drivers/pinctrl/pinctrl-rockchip.c > @@ -2769,25 +2769,25 @@ static struct rockchip_pin_ctrl rk3399_pin_ctrl = { > > static const struct of_device_id rockchip_pinctrl_dt_match[] = { > { .compatible = "rockchip,rk1108-pinctrl", > - .data = (void *)&rk1108_pin_ctrl }, > + .data = &rk1108_pin_ctrl }, You should base your pinctrl-patches on top of Linus' branch, especially as the rk1108->rv1108 is in there: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/drivers/pinctrl/pinctrl-rockchip.c?h=for-next&id=b9c6dcab265e93c47bdcd99ab7c6acda90ed669b With the above fixed: Reviewed-by: Heiko Stuebner <heiko@sntech.de> Heiko ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-25 22:11 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-04-25 21:34 [PATCH 0/2] pinctrl: trivial: remove unneeded (void *) casts in of_match_table Masahiro Yamada 2017-04-25 21:34 ` [PATCH 1/2] pinctrl: rockchip: " Masahiro Yamada 2017-04-25 22:11 ` Heiko Stübner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox