[PATCH 1/2] MAINTAINERS: add entry for Rockchip drm drivers

[PATCH 1/2] MAINTAINERS: add entry for Rockchip drm drivers

[Heiko Stübner]

Mark Yao looks after the Rockchip drm drivers and should thus also get
patches touching these.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7687fc6..7e4d386 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3410,6 +3410,13 @@ F:	drivers/gpu/drm/rcar-du/
 F:	drivers/gpu/drm/shmobile/
 F:	include/linux/platform_data/shmob_drm.h
 
+DRM DRIVERS FOR ROCKCHIP
+M:	Mark Yao <mark.yao@rock-chips.com>
+L:	dri-devel@lists.freedesktop.org
+S:	Maintained
+F:	drivers/gpu/drm/rockchip/
+F:	Documentation/devicetree/bindings/video/rockchip*
+
 DSBR100 USB FM RADIO DRIVER
 M:	Alexey Klimov <klimov.linux@gmail.com>
 L:	linux-media@vger.kernel.org
-- 
2.1.4


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/2] drm/rockchip: make irq variable signed

[Heiko Stübner]

platform_get_irq() can return negative error values and we already test for
these. Therefore the variable holding this value should be signed to not
loose error values.

Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index ccb0ce0..bde1c1e 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -104,7 +104,7 @@ struct vop {
 	/* lock vop irq reg */
 	spinlock_t irq_lock;
 
-	unsigned int irq;
+	int irq;
 
 	/* vop AHP clk */
 	struct clk *hclk;
-- 
2.1.4


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] drm/rockchip: make irq variable signed

[Daniel Kurtz]

[-- Attachment #1.1: Type: text/plain, Size: 1343 bytes --]

Hi Heiko,

On Sun, Apr 19, 2015 at 12:30 AM, Heiko Stübner <heiko@sntech.de> wrote:

> platform_get_irq() can return negative error values and we already test for
> these. Therefore the variable holding this value should be signed to not
> loose error values.
>
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index ccb0ce0..bde1c1e 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -104,7 +104,7 @@ struct vop {
>         /* lock vop irq reg */
>         spinlock_t irq_lock;
>
> -       unsigned int irq;
> +       int irq;
>

Hmm.  Both enable_irq() and disable_irq(), etc) want irq as an unsigned int.
The thing we want here is to detect a negative return value from
platform_get_irq().
So, I'd slightly prefer changing to vop_bind() to something like this:

 int irq;
...
 irq = platform_get_irq()
 If (irq < 0)
   return irq;
 vop->irq = (unsigned int)irq;


-Dan



>
>         /* vop AHP clk */
>         struct clk *hclk;
> --
> 2.1.4
>
>
>

[-- Attachment #1.2: Type: text/html, Size: 2267 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] drm/rockchip: make irq variable signed

[Daniel Kurtz]

Hi Heiko,

On Sun, Apr 19, 2015 at 12:30 AM, Heiko Stübner <heiko@sntech.de> wrote:
> platform_get_irq() can return negative error values and we already test for
> these. Therefore the variable holding this value should be signed to not
> loose error values.
>
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
>  drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index ccb0ce0..bde1c1e 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -104,7 +104,7 @@ struct vop {
>         /* lock vop irq reg */
>         spinlock_t irq_lock;
>
> -       unsigned int irq;
> +       int irq;


Hmm.  Both enable_irq() and disable_irq(), etc) want irq as an unsigned int.
The thing we want here is to detect a negative return value from
platform_get_irq().
So, I'd slightly prefer changing to vop_bind() to something like this:

 int irq;
...
 irq = platform_get_irq()
 If (irq < 0)
   return irq;
 vop->irq = (unsigned int)irq;

But, either way, this patch is:

Reviewed-By: Daniel Kurtz <djkurtz@chromium.org>

Thanks for the fix.

>
>         /* vop AHP clk */
>         struct clk *hclk;
> --
> 2.1.4
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel