Re: [PATCH] arm64: dts: rockchip: fix rk3328-roc-cc gmac2io stability issues

[Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>]

Hi,

Am Donnerstag, 28. Februar 2019, 16:01:29 CET schrieb Leonidas P. Papadakos:
> The rk3328-roc-cc board exhibits tx stability issues with large packets,
> as does the rock64 board, which was fixed with this patch
> https://patchwork.kernel.org/patch/10178969/
> 
> A similar patch was made for the rk3328-roc-cc here
> https://patchwork.kernel.org/patch/10804863/
> but it doesn't include the tx/rx fixes, and I fins that they
> help with an issue where large transfers would bring the ethernet
> link down, causing a reset.

as you can see in the reference patchwork entry, I already applied
that patch and it will be part of kernel 5.1.

So please base you works on top of that state (like the linux-next
for convenience) - i.e. your patch should not again try to add the
thres_dma_mode property, as it is now already present in the
devicetree.

Thanks
Heiko


> Signed-off-by: Leonidas P. Papadakos <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> index 99d0d9912950..0e34354b2092 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> @@ -104,11 +104,12 @@
>  	phy-mode = "rgmii";
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&rgmiim1_pins>;
> +	snps,force_thresh_dma_mode;
>  	snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>;
>  	snps,reset-active-low;
>  	snps,reset-delays-us = <0 10000 50000>;
> -	tx_delay = <0x25>;
> -	rx_delay = <0x11>;
> +	tx_delay = <0x24>;
> +	rx_delay = <0x18>;
>  	status = "okay";
>  };
>  
>