* [PATCH 0/2] Add mphy reset signal to Rockchip ufshc node
@ 2026-03-11 1:40 Shawn Lin
2026-03-11 1:40 ` [PATCH 1/2] scsi: ufs: drockchip,rk3576-ufshc: dt-bindings: Add new mphy reset item Shawn Lin
2026-03-11 1:40 ` [PATCH 2/2] arm64: dts: rockchip: Add mphy reset to ufshc node Shawn Lin
0 siblings, 2 replies; 8+ messages in thread
From: Shawn Lin @ 2026-03-11 1:40 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-scsi, linux-rockchip, Shawn Lin
This series adds mphy reset signal to ufshc node of RK3576.dtsi
and update the dt-bingding file.
Shawn Lin (2):
scsi: ufs: drockchip,rk3576-ufshc: dt-bindings: Add new mphy reset
item
arm64: dts: rockchip: Add mphy reset to ufshc node
Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml | 7 ++++---
arch/arm64/boot/dts/rockchip/rk3576.dtsi | 5 +++--
2 files changed, 7 insertions(+), 5 deletions(-)
--
2.7.4
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/2] scsi: ufs: drockchip,rk3576-ufshc: dt-bindings: Add new mphy reset item 2026-03-11 1:40 [PATCH 0/2] Add mphy reset signal to Rockchip ufshc node Shawn Lin @ 2026-03-11 1:40 ` Shawn Lin 2026-03-11 13:10 ` Krzysztof Kozlowski 2026-03-11 1:40 ` [PATCH 2/2] arm64: dts: rockchip: Add mphy reset to ufshc node Shawn Lin 1 sibling, 1 reply; 8+ messages in thread From: Shawn Lin @ 2026-03-11 1:40 UTC (permalink / raw) To: James E . J . Bottomley, Martin K . Petersen, Heiko Stuebner Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree, linux-scsi, linux-rockchip, Shawn Lin Add the mphy reset property to the devicetree bindings for the Rockchip RK3576 UFS host controller. The mphy reset signal is used to reset the physical adapter. Resetting other components while leaving the mphy unreset may occasionally prevent the UFS controller from successfully linking up with the device. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml b/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml index c7d17cf4..e738153 100644 --- a/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml +++ b/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml @@ -41,7 +41,7 @@ properties: maxItems: 1 resets: - maxItems: 4 + maxItems: 5 reset-names: items: @@ -49,6 +49,7 @@ properties: - const: sys - const: ufs - const: grf + - const: mphy reset-gpios: maxItems: 1 @@ -98,8 +99,8 @@ examples: interrupts = <GIC_SPI 361 IRQ_TYPE_LEVEL_HIGH>; power-domains = <&power RK3576_PD_USB>; resets = <&cru SRST_A_UFS_BIU>, <&cru SRST_A_UFS_SYS>, <&cru SRST_A_UFS>, - <&cru SRST_P_UFS_GRF>; - reset-names = "biu", "sys", "ufs", "grf"; + <&cru SRST_P_UFS_GRF>, <&cru SRST_MPHY_INIT>; + reset-names = "biu", "sys", "ufs", "grf", "mphy"; reset-gpios = <&gpio4 RK_PD0 GPIO_ACTIVE_LOW>; }; }; -- 2.7.4 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] scsi: ufs: drockchip,rk3576-ufshc: dt-bindings: Add new mphy reset item 2026-03-11 1:40 ` [PATCH 1/2] scsi: ufs: drockchip,rk3576-ufshc: dt-bindings: Add new mphy reset item Shawn Lin @ 2026-03-11 13:10 ` Krzysztof Kozlowski 2026-03-11 13:29 ` Shawn Lin 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2026-03-11 13:10 UTC (permalink / raw) To: Shawn Lin Cc: James E . J . Bottomley, Martin K . Petersen, Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree, linux-scsi, linux-rockchip On Wed, Mar 11, 2026 at 09:40:17AM +0800, Shawn Lin wrote: > Add the mphy reset property to the devicetree bindings for the Rockchip > RK3576 UFS host controller. The mphy reset signal is used to reset the > physical adapter. Resetting other components while leaving the mphy > unreset may occasionally prevent the UFS controller from successfully > linking up with the device. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > > Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml b/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml > index c7d17cf4..e738153 100644 > --- a/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml > +++ b/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml > @@ -41,7 +41,7 @@ properties: > maxItems: 1 > > resets: > - maxItems: 4 > + maxItems: 5 > > reset-names: > items: > @@ -49,6 +49,7 @@ properties: > - const: sys > - const: ufs > - const: grf > + - const: mphy ABI break here and in the driver. Considering this was merged year ago, so for sure it was tested and was working. Otherwise commit msg would explain the actual bug affecting users. Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] scsi: ufs: drockchip,rk3576-ufshc: dt-bindings: Add new mphy reset item 2026-03-11 13:10 ` Krzysztof Kozlowski @ 2026-03-11 13:29 ` Shawn Lin 2026-03-11 13:38 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Shawn Lin @ 2026-03-11 13:29 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: shawn.lin, James E . J . Bottomley, Martin K . Petersen, Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree, linux-scsi, linux-rockchip Hi Krzysztof 在 2026/03/11 星期三 21:10, Krzysztof Kozlowski 写道: > On Wed, Mar 11, 2026 at 09:40:17AM +0800, Shawn Lin wrote: >> Add the mphy reset property to the devicetree bindings for the Rockchip >> RK3576 UFS host controller. The mphy reset signal is used to reset the >> physical adapter. Resetting other components while leaving the mphy >> unreset may occasionally prevent the UFS controller from successfully >> linking up with the device. >> >> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> >> --- >> >> Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml b/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml >> index c7d17cf4..e738153 100644 >> --- a/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml >> +++ b/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml >> @@ -41,7 +41,7 @@ properties: >> maxItems: 1 >> >> resets: >> - maxItems: 4 >> + maxItems: 5 >> >> reset-names: >> items: >> @@ -49,6 +49,7 @@ properties: >> - const: sys >> - const: ufs >> - const: grf >> + - const: mphy > > ABI break here and in the driver. Considering this was merged year ago, > so for sure it was tested and was working. Otherwise commit msg would > explain the actual bug affecting users. > Thanks for your review. You are absolutely right that this change technically breaks the ABI in the device tree bindings by increasing maxItems and adding a new entry. Although the driver is using devm_reset_control_array_get_exclusive(), so the old DTB and new DTB should both work. The issue this series fixes (UFS link-up failure when mphy is not explicitly reset) is an intermittent hardware bug that is difficult to reproduce. It only occurs under specific timing conditions with certain chips. We recently encountered this issue consistently in our downstream testing and identified the root cause. We are syncing this critical fix to upstream immediately to prevent stability issues for users. I will update the commit message to explicitly describe this hard-to-reproduce bug and the specific failure mode, and probably add a fixes tag. Does the above sound the right approach to you? > Best regards, > Krzysztof > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] scsi: ufs: drockchip,rk3576-ufshc: dt-bindings: Add new mphy reset item 2026-03-11 13:29 ` Shawn Lin @ 2026-03-11 13:38 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2026-03-11 13:38 UTC (permalink / raw) To: Shawn Lin Cc: James E . J . Bottomley, Martin K . Petersen, Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree, linux-scsi, linux-rockchip On 11/03/2026 14:29, Shawn Lin wrote: > Hi Krzysztof > > 在 2026/03/11 星期三 21:10, Krzysztof Kozlowski 写道: >> On Wed, Mar 11, 2026 at 09:40:17AM +0800, Shawn Lin wrote: >>> Add the mphy reset property to the devicetree bindings for the Rockchip >>> RK3576 UFS host controller. The mphy reset signal is used to reset the >>> physical adapter. Resetting other components while leaving the mphy >>> unreset may occasionally prevent the UFS controller from successfully >>> linking up with the device. >>> >>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> >>> --- >>> >>> Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml b/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml >>> index c7d17cf4..e738153 100644 >>> --- a/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml >>> +++ b/Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml >>> @@ -41,7 +41,7 @@ properties: >>> maxItems: 1 >>> >>> resets: >>> - maxItems: 4 >>> + maxItems: 5 >>> >>> reset-names: >>> items: >>> @@ -49,6 +49,7 @@ properties: >>> - const: sys >>> - const: ufs >>> - const: grf >>> + - const: mphy >> >> ABI break here and in the driver. Considering this was merged year ago, >> so for sure it was tested and was working. Otherwise commit msg would >> explain the actual bug affecting users. >> > > Thanks for your review. > > You are absolutely right that this change technically breaks the ABI in > the device tree bindings by increasing maxItems and adding a new entry. > Although the driver is using devm_reset_control_array_get_exclusive(), > so the old DTB and new DTB should both work. Ah, I missed that. Please mention it briefly in commit msg to indicate that Linux is not affected. > > The issue this series fixes (UFS link-up failure when mphy is not > explicitly reset) is an intermittent hardware bug that is difficult to > reproduce. It only occurs under specific timing conditions with certain > chips. We recently encountered this issue consistently in our downstream > testing and identified the root cause. We are syncing this critical fix > to upstream immediately to prevent stability issues for users. I will > update the commit message to explicitly describe this hard-to-reproduce > bug and the specific failure mode, and probably add a fixes tag. > > Does the above sound the right approach to you? Yes, please include parts of above, that it is hard to reproduce but it does happen, in the commit msg. Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm64: dts: rockchip: Add mphy reset to ufshc node 2026-03-11 1:40 [PATCH 0/2] Add mphy reset signal to Rockchip ufshc node Shawn Lin 2026-03-11 1:40 ` [PATCH 1/2] scsi: ufs: drockchip,rk3576-ufshc: dt-bindings: Add new mphy reset item Shawn Lin @ 2026-03-11 1:40 ` Shawn Lin 2026-03-11 13:11 ` Krzysztof Kozlowski 1 sibling, 1 reply; 8+ messages in thread From: Shawn Lin @ 2026-03-11 1:40 UTC (permalink / raw) To: James E . J . Bottomley, Martin K . Petersen, Heiko Stuebner Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree, linux-scsi, linux-rockchip, Shawn Lin Add mphy reset to ufshc node to fully reset the whole UFS blocks if needed. Otherwise, it may occasionally prevent the UFS controller from successfully linking up with the device. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3576.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi index 9c28769..9fa99be 100644 --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi @@ -2035,8 +2035,9 @@ pinctrl-0 = <&ufs_refclk &ufs_rstgpio>; pinctrl-names = "default"; resets = <&cru SRST_A_UFS_BIU>, <&cru SRST_A_UFS_SYS>, - <&cru SRST_A_UFS>, <&cru SRST_P_UFS_GRF>; - reset-names = "biu", "sys", "ufs", "grf"; + <&cru SRST_A_UFS>, <&cru SRST_P_UFS_GRF>, + <&cru SRST_MPHY_INIT>; + reset-names = "biu", "sys", "ufs", "grf", "mphy"; reset-gpios = <&gpio4 RK_PD0 GPIO_ACTIVE_LOW>; status = "disabled"; }; -- 2.7.4 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: Add mphy reset to ufshc node 2026-03-11 1:40 ` [PATCH 2/2] arm64: dts: rockchip: Add mphy reset to ufshc node Shawn Lin @ 2026-03-11 13:11 ` Krzysztof Kozlowski 2026-03-11 13:36 ` Shawn Lin 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2026-03-11 13:11 UTC (permalink / raw) To: Shawn Lin Cc: James E . J . Bottomley, Martin K . Petersen, Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree, linux-scsi, linux-rockchip On Wed, Mar 11, 2026 at 09:40:18AM +0800, Shawn Lin wrote: > Add mphy reset to ufshc node to fully reset the whole UFS blocks > if needed. Otherwise, it may occasionally prevent the UFS controller > from successfully linking up with the device. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > You must not combine DTS changes with patchset targetting SCSI/UFS, because they apply entire set and this DTS CANNOT go there. NAK Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: rockchip: Add mphy reset to ufshc node 2026-03-11 13:11 ` Krzysztof Kozlowski @ 2026-03-11 13:36 ` Shawn Lin 0 siblings, 0 replies; 8+ messages in thread From: Shawn Lin @ 2026-03-11 13:36 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: shawn.lin, James E . J . Bottomley, Martin K . Petersen, Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree, linux-scsi, linux-rockchip 在 2026/03/11 星期三 21:11, Krzysztof Kozlowski 写道: > On Wed, Mar 11, 2026 at 09:40:18AM +0800, Shawn Lin wrote: >> Add mphy reset to ufshc node to fully reset the whole UFS blocks >> if needed. Otherwise, it may occasionally prevent the UFS controller >> from successfully linking up with the device. >> >> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> >> --- >> > > You must not combine DTS changes with patchset targetting SCSI/UFS, > because they apply entire set and this DTS CANNOT go there. > Well, I was thinking that dt-bingdings will go via UFS tree but DTS is picked up via rockchip tree. Combine them together is easy for folks to reviewed. Will send them separately. > NAK > > Best regards, > Krzysztof > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-03-11 13:38 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-03-11 1:40 [PATCH 0/2] Add mphy reset signal to Rockchip ufshc node Shawn Lin 2026-03-11 1:40 ` [PATCH 1/2] scsi: ufs: drockchip,rk3576-ufshc: dt-bindings: Add new mphy reset item Shawn Lin 2026-03-11 13:10 ` Krzysztof Kozlowski 2026-03-11 13:29 ` Shawn Lin 2026-03-11 13:38 ` Krzysztof Kozlowski 2026-03-11 1:40 ` [PATCH 2/2] arm64: dts: rockchip: Add mphy reset to ufshc node Shawn Lin 2026-03-11 13:11 ` Krzysztof Kozlowski 2026-03-11 13:36 ` Shawn Lin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox