Re: [PATCH] mmc: android-goldfish: fix potential panic due to null pointer

[Peter Korsgaard <peter-+2lRwdCCLRT2eFz/2MeuCQ@public.gmane.org>]

>>>>> "Shawn" == Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org> writes:

 > We should never compare virt_base with zero to indicate whether
 > we get the right buffer or not from dma_alloc_coherent. It's quite
 > architecture related. If failing to get the address from CMA or swoitlb
 > cases, the sub architecture code should decide the return value for it.
 > So we should never presume that zero always means the failure.

 > Signed-off-by: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
 > ---

 >  drivers/mmc/host/android-goldfish.c | 2 +-
 >  1 file changed, 1 insertion(+), 1 deletion(-)

 > diff --git a/drivers/mmc/host/android-goldfish.c b/drivers/mmc/host/android-goldfish.c
 > index dca5518..6d8bd03 100644
 > --- a/drivers/mmc/host/android-goldfish.c
 > +++ b/drivers/mmc/host/android-goldfish.c
 > @@ -484,7 +484,7 @@ static int goldfish_mmc_probe(struct platform_device *pdev)
 host-> virt_base = dma_alloc_coherent(&pdev->dev, BUFFER_SIZE,
 >  					     &buf_addr, GFP_KERNEL);
 
 > -	if (host->virt_base == 0) {
 > +	if (!host->virt_base) {

Huh, these are equivalent?

-- 
Bye, Peter Korsgaard