* [PATCH] mmc: android-goldfish: fix potential panic due to null pointer
@ 2016-08-21 3:34 Shawn Lin
[not found] ` <1471750476-335-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Shawn Lin @ 2016-08-21 3:34 UTC (permalink / raw)
To: =Ulf Hansson; +Cc: linux-mmc, linux-rockchip, Shawn Lin
We should never compare virt_base with zero to indicate whether
we get the right buffer or not from dma_alloc_coherent. It's quite
architecture related. If failing to get the address from CMA or swoitlb
cases, the sub architecture code should decide the return value for it.
So we should never presume that zero always means the failure.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/android-goldfish.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/android-goldfish.c b/drivers/mmc/host/android-goldfish.c
index dca5518..6d8bd03 100644
--- a/drivers/mmc/host/android-goldfish.c
+++ b/drivers/mmc/host/android-goldfish.c
@@ -484,7 +484,7 @@ static int goldfish_mmc_probe(struct platform_device *pdev)
host->virt_base = dma_alloc_coherent(&pdev->dev, BUFFER_SIZE,
&buf_addr, GFP_KERNEL);
- if (host->virt_base == 0) {
+ if (!host->virt_base) {
ret = -ENOMEM;
goto dma_alloc_failed;
}
--
2.3.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: android-goldfish: fix potential panic due to null pointer
[not found] ` <1471750476-335-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
@ 2016-08-22 12:33 ` Peter Korsgaard
0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2016-08-22 12:33 UTC (permalink / raw)
To: Shawn Lin
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, =Ulf Hansson,
linux-mmc-u79uwXL29TY76Z2rM5mHXA
>>>>> "Shawn" == Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org> writes:
> We should never compare virt_base with zero to indicate whether
> we get the right buffer or not from dma_alloc_coherent. It's quite
> architecture related. If failing to get the address from CMA or swoitlb
> cases, the sub architecture code should decide the return value for it.
> So we should never presume that zero always means the failure.
> Signed-off-by: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
> drivers/mmc/host/android-goldfish.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/mmc/host/android-goldfish.c b/drivers/mmc/host/android-goldfish.c
> index dca5518..6d8bd03 100644
> --- a/drivers/mmc/host/android-goldfish.c
> +++ b/drivers/mmc/host/android-goldfish.c
> @@ -484,7 +484,7 @@ static int goldfish_mmc_probe(struct platform_device *pdev)
host-> virt_base = dma_alloc_coherent(&pdev->dev, BUFFER_SIZE,
> &buf_addr, GFP_KERNEL);
> - if (host->virt_base == 0) {
> + if (!host->virt_base) {
Huh, these are equivalent?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-22 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-21 3:34 [PATCH] mmc: android-goldfish: fix potential panic due to null pointer Shawn Lin
[not found] ` <1471750476-335-1-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-22 12:33 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox