* [PATCH] arm64: dts: rockchip: radxa-e25: fix typo in vcc3v3-pi6c-05-regulator
@ 2023-04-20 10:15 FUKAUMI Naoki
2023-04-21 11:48 ` Heiko Stuebner
0 siblings, 1 reply; 3+ messages in thread
From: FUKAUMI Naoki @ 2023-04-20 10:15 UTC (permalink / raw)
To: heiko; +Cc: linux-rockchip, FUKAUMI Naoki
"gpios" should be "gpio"
Fixes: 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
index 63c4bd873188..bde43c4a5bb1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
@@ -89,7 +89,7 @@ vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
compatible = "regulator-fixed";
enable-active-high;
- gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
+ gpio = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&pcie_enable_h>;
regulator-name = "vcc3v3_pcie";
--
2.39.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: radxa-e25: fix typo in vcc3v3-pi6c-05-regulator
2023-04-20 10:15 [PATCH] arm64: dts: rockchip: radxa-e25: fix typo in vcc3v3-pi6c-05-regulator FUKAUMI Naoki
@ 2023-04-21 11:48 ` Heiko Stuebner
2023-04-21 23:14 ` FUKAUMI Naoki
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2023-04-21 11:48 UTC (permalink / raw)
To: FUKAUMI Naoki; +Cc: linux-rockchip, FUKAUMI Naoki
Hi,
Am Donnerstag, 20. April 2023, 12:15:55 CEST schrieb FUKAUMI Naoki:
> "gpios" should be "gpio"
I don't see this.
The fixed-regulator binding does specify both "gpios" and "gpio" as valid.
And the code also tries both [0].
So this change really isn't necessary.
Heiko
[0] https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.h#L86
> Fixes: 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> index 63c4bd873188..bde43c4a5bb1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
> @@ -89,7 +89,7 @@ vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
> vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
> compatible = "regulator-fixed";
> enable-active-high;
> - gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
> + gpio = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
> pinctrl-names = "default";
> pinctrl-0 = <&pcie_enable_h>;
> regulator-name = "vcc3v3_pcie";
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: radxa-e25: fix typo in vcc3v3-pi6c-05-regulator
2023-04-21 11:48 ` Heiko Stuebner
@ 2023-04-21 23:14 ` FUKAUMI Naoki
0 siblings, 0 replies; 3+ messages in thread
From: FUKAUMI Naoki @ 2023-04-21 23:14 UTC (permalink / raw)
To: Heiko Stuebner; +Cc: linux-rockchip
hi,
On 4/21/23 20:48, Heiko Stuebner wrote:
> Hi,
>
> Am Donnerstag, 20. April 2023, 12:15:55 CEST schrieb FUKAUMI Naoki:
>> "gpios" should be "gpio"
>
> I don't see this.
>
> The fixed-regulator binding does specify both "gpios" and "gpio" as valid.
> And the code also tries both [0].
>
> So this change really isn't necessary.
I see. it seems I referred old document... sorry for bothering you.
--
FUKAUMI Naoki
> Heiko
>
> [0] https://elixir.bootlin.com/linux/latest/source/drivers/gpio/gpiolib.h#L86
>
>> Fixes: 2bf2f4d9f673 ("arm64: dts: rockchip: Add Radxa CM3I E25")
>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
>> ---
>> arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
>> index 63c4bd873188..bde43c4a5bb1 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-radxa-e25.dts
>> @@ -89,7 +89,7 @@ vcc3v3_pcie30x1: vcc3v3-pcie30x1-regulator {
>> vcc3v3_pi6c_05: vcc3v3-pi6c-05-regulator {
>> compatible = "regulator-fixed";
>> enable-active-high;
>> - gpios = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
>> + gpio = <&gpio0 RK_PC7 GPIO_ACTIVE_HIGH>;
>> pinctrl-names = "default";
>> pinctrl-0 = <&pcie_enable_h>;
>> regulator-name = "vcc3v3_pcie";
>>
>
>
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-21 23:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-20 10:15 [PATCH] arm64: dts: rockchip: radxa-e25: fix typo in vcc3v3-pi6c-05-regulator FUKAUMI Naoki
2023-04-21 11:48 ` Heiko Stuebner
2023-04-21 23:14 ` FUKAUMI Naoki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox