* [PATCH AUTOSEL 5.15 15/82] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro [not found] <20211109221641.1233217-1-sashal@kernel.org> @ 2021-11-09 22:15 ` Sasha Levin 2021-11-09 22:15 ` [PATCH AUTOSEL 5.15 17/82] arm64: dts: rockchip: add Coresight debug range for RK3399 Sasha Levin 1 sibling, 0 replies; 5+ messages in thread From: Sasha Levin @ 2021-11-09 22:15 UTC (permalink / raw) To: linux-kernel, stable Cc: Matthias Brugger, Guillaume Gardet, Heiko Stuebner, Sasha Levin, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, catalin.marinas, will.deacon, devicetree, linux-arm-kernel, linux-rockchip From: Matthias Brugger <mbrugger@suse.com> [ Upstream commit 2513fa5c25d42f55ca5f0f0ab247af7c9fbfa3b1 ] The CDN DP needs a PHY and a extcon to work correctly. But no extcon is provided by the device-tree, which leads to an error: cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy cdn-dp: probe of fec00000.dp failed with error -22 Disable the CDN DP to make graphic work on the Pinebook Pro. Reported-by: Guillaume Gardet <guillaume.gardet@arm.com> Signed-off-by: Matthias Brugger <mbrugger@suse.com> Link: https://lore.kernel.org/r/20210715164101.11486-1-matthias.bgg@kernel.org Signed-off-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Sasha Levin <sashal@kernel.org> --- arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts index 2b5f001ff4a61..9e5d07f5712e6 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts @@ -385,10 +385,6 @@ }; }; -&cdn_dp { - status = "okay"; -}; - &cpu_b0 { cpu-supply = <&vdd_cpu_b>; }; -- 2.33.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH AUTOSEL 5.15 17/82] arm64: dts: rockchip: add Coresight debug range for RK3399 [not found] <20211109221641.1233217-1-sashal@kernel.org> 2021-11-09 22:15 ` [PATCH AUTOSEL 5.15 15/82] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro Sasha Levin @ 2021-11-09 22:15 ` Sasha Levin 2021-11-09 23:25 ` Brian Norris 1 sibling, 1 reply; 5+ messages in thread From: Sasha Levin @ 2021-11-09 22:15 UTC (permalink / raw) To: linux-kernel, stable Cc: Brian Norris, Leo Yan, Chen-Yu Tsai, Douglas Anderson, Heiko Stuebner, Sasha Levin, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, catalin.marinas, will.deacon, devicetree, linux-arm-kernel, linux-rockchip From: Brian Norris <briannorris@chromium.org> [ Upstream commit 75dccea503b8e176ad044175e891d7bb291b6ba0 ] Per Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt. This IP block can be used for sampling the PC of any given CPU, which is useful in certain panic scenarios where you can't get the CPU to stop cleanly (e.g., hard lockup). Reviewed-by: Leo Yan <leo.yan@linaro.org> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Brian Norris <briannorris@chromium.org> Link: https://lore.kernel.org/r/20210908111337.v2.3.Ibc87b4785709543c998cc852c1edaeb7a08edf5c@changeid Signed-off-by: Heiko Stuebner <heiko@sntech.de> Signed-off-by: Sasha Levin <sashal@kernel.org> --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 48 ++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index 3871c7fd83b00..c5fe2d4401149 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -361,6 +361,54 @@ status = "disabled"; }; + debug@fe430000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe430000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l0>; + }; + + debug@fe432000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe432000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l1>; + }; + + debug@fe434000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe434000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l2>; + }; + + debug@fe436000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe436000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_L>; + clock-names = "apb_pclk"; + cpu = <&cpu_l3>; + }; + + debug@fe610000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe610000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_B>; + clock-names = "apb_pclk"; + cpu = <&cpu_b0>; + }; + + debug@fe710000 { + compatible = "arm,coresight-cpu-debug", "arm,primecell"; + reg = <0 0xfe710000 0 0x1000>; + clocks = <&cru PCLK_COREDBG_B>; + clock-names = "apb_pclk"; + cpu = <&cpu_b1>; + }; + usbdrd3_0: usb@fe800000 { compatible = "rockchip,rk3399-dwc3"; #address-cells = <2>; -- 2.33.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH AUTOSEL 5.15 17/82] arm64: dts: rockchip: add Coresight debug range for RK3399 2021-11-09 22:15 ` [PATCH AUTOSEL 5.15 17/82] arm64: dts: rockchip: add Coresight debug range for RK3399 Sasha Levin @ 2021-11-09 23:25 ` Brian Norris 2021-11-10 0:44 ` Sasha Levin 0 siblings, 1 reply; 5+ messages in thread From: Brian Norris @ 2021-11-09 23:25 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Leo Yan, Chen-Yu Tsai, Douglas Anderson, Heiko Stuebner, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, catalin.marinas, will.deacon, devicetree, linux-arm-kernel, linux-rockchip On Tue, Nov 9, 2021 at 2:17 PM Sasha Levin <sashal@kernel.org> wrote: > > From: Brian Norris <briannorris@chromium.org> > > [ Upstream commit 75dccea503b8e176ad044175e891d7bb291b6ba0 ] > > Per Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt. > > This IP block can be used for sampling the PC of any given CPU, which is > useful in certain panic scenarios where you can't get the CPU to stop > cleanly (e.g., hard lockup). I don't understand why this is being backported to -stable. First of all, it won't work because it's missing dependencies (specifically, around the RK3399 clock driver). But even if it did, I don't see how this is a candidate for -stable. Methinks the AI has gone too far again. Brian _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH AUTOSEL 5.15 17/82] arm64: dts: rockchip: add Coresight debug range for RK3399 2021-11-09 23:25 ` Brian Norris @ 2021-11-10 0:44 ` Sasha Levin 2021-11-10 0:49 ` Brian Norris 0 siblings, 1 reply; 5+ messages in thread From: Sasha Levin @ 2021-11-10 0:44 UTC (permalink / raw) To: Brian Norris Cc: linux-kernel, stable, Leo Yan, Chen-Yu Tsai, Douglas Anderson, Heiko Stuebner, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, catalin.marinas, will.deacon, devicetree, linux-arm-kernel, linux-rockchip On Tue, Nov 09, 2021 at 03:25:39PM -0800, Brian Norris wrote: >On Tue, Nov 9, 2021 at 2:17 PM Sasha Levin <sashal@kernel.org> wrote: >> >> From: Brian Norris <briannorris@chromium.org> >> >> [ Upstream commit 75dccea503b8e176ad044175e891d7bb291b6ba0 ] >> >> Per Documentation/devicetree/bindings/arm/coresight-cpu-debug.txt. >> >> This IP block can be used for sampling the PC of any given CPU, which is >> useful in certain panic scenarios where you can't get the CPU to stop >> cleanly (e.g., hard lockup). > >I don't understand why this is being backported to -stable. First of >all, it won't work because it's missing dependencies (specifically, >around the RK3399 clock driver). But even if it did, I don't see how >this is a candidate for -stable. > >Methinks the AI has gone too far again. Possibly. We try to take patches that enable existing hardware (or hardware features) where the logic is already in the kernel but it's missing something like adding a new PCI ID or a quirk. This also seems to happen with devicetree files which is why this patch got pulled in. I'll drop it if it depends on patches that didn't make it in. Thanks! -- Thanks, Sasha _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH AUTOSEL 5.15 17/82] arm64: dts: rockchip: add Coresight debug range for RK3399 2021-11-10 0:44 ` Sasha Levin @ 2021-11-10 0:49 ` Brian Norris 0 siblings, 0 replies; 5+ messages in thread From: Brian Norris @ 2021-11-10 0:49 UTC (permalink / raw) To: Sasha Levin Cc: linux-kernel, stable, Leo Yan, Chen-Yu Tsai, Douglas Anderson, Heiko Stuebner, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, catalin.marinas, will.deacon, devicetree, linux-arm-kernel, linux-rockchip On Tue, Nov 9, 2021 at 4:44 PM Sasha Levin <sashal@kernel.org> wrote: > I'll drop it if it depends on patches that didn't make it in. Thanks! Well, it won't harm anything as-is I suppose (maybe some logspam from probe failure? not sure), but it would be extra bad if you managed to pick up only _some_ of the dependencies. (There were 2 patches, but I won't tell you which they were.) If you only got one of them, you'd turn pretty much any RK3399 system into a brick, at least until they revert their kernel/DTB upgrade. Brian _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-11-10 0:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211109221641.1233217-1-sashal@kernel.org>
2021-11-09 22:15 ` [PATCH AUTOSEL 5.15 15/82] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro Sasha Levin
2021-11-09 22:15 ` [PATCH AUTOSEL 5.15 17/82] arm64: dts: rockchip: add Coresight debug range for RK3399 Sasha Levin
2021-11-09 23:25 ` Brian Norris
2021-11-10 0:44 ` Sasha Levin
2021-11-10 0:49 ` Brian Norris
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox