* [PATCH 00/22] drm: Review of mode copies @ 2022-02-18 10:03 Ville Syrjala 2022-02-18 10:03 ` [PATCH 14/22] drm/rockchip: Use drm_mode_copy() Ville Syrjala 2022-03-14 22:11 ` [PATCH 00/22] drm: Review of mode copies Ville Syrjälä 0 siblings, 2 replies; 8+ messages in thread From: Ville Syrjala @ 2022-02-18 10:03 UTC (permalink / raw) To: dri-devel Cc: intel-gfx, Abhinav Kumar, Alain Volmat, Alex Deucher, amd-gfx, Andrzej Hajda, Aurabindo Pillai, Chen Feng, Chun-Kuang Hu, Emma Anholt, freedreno, Harry Wentland, Heiko Stübner, Jernej Skrabec, John Stultz, Jonas Karlman, Jyri Sarha, Laurent Pinchart, Leo Li, linux-arm-kernel, linux-arm-msm, linux-rockchip, Maxime Ripard, Neil Armstrong, Nikola Cornij, Patrik Jakobsson, Philipp Zabel, Rob Clark, Robert Foss, Rodrigo Siqueira, Sam Ravnborg, Sandy Huang, Sean Paul, Thierry Reding, Tian Tao, Tomi Valkeinen, Xinliang Liu, Xinwei Kong From: Ville Syrjälä <ville.syrjala@linux.intel.com> I might be taking this a bit too far, but the lack of consistency in our methods to copy drm_display_mode structs around is bugging me. The main worry is the embedded list head, which if clobbered could lead to list corruption. I'd also prefer to make sure even the valid list heads don't propagate between copies since that makes no sense. While going through some of the code I also spotted some very weird on stack copies being made for no reason at all. I elimininated a few of them here, but there could certainly be more lurking in the shadows. Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Alain Volmat <alain.volmat@foss.st.com> Cc: Alex Deucher <alexander.deucher@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: Andrzej Hajda <andrzej.hajda@intel.com> Cc: Aurabindo Pillai <aurabindo.pillai@amd.com> Cc: Chen Feng <puck.chen@hisilicon.com> Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org> Cc: Emma Anholt <emma@anholt.net> Cc: freedreno@lists.freedesktop.org Cc: Harry Wentland <harry.wentland@amd.com> Cc: "Heiko Stübner" <heiko@sntech.de> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> Cc: John Stultz <john.stultz@linaro.org> Cc: Jonas Karlman <jonas@kwiboo.se> Cc: Jyri Sarha <jyri.sarha@iki.fi> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com> Cc: Leo Li <sunpeng.li@amd.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-rockchip@lists.infradead.org Cc: Maxime Ripard <mripard@kernel.org> Cc: Neil Armstrong <narmstrong@baylibre.com> Cc: Nikola Cornij <nikola.cornij@amd.com> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com> Cc: Philipp Zabel <p.zabel@pengutronix.de> Cc: Rob Clark <robdclark@gmail.com> Cc: Robert Foss <robert.foss@linaro.org> Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Sandy Huang <hjc@rock-chips.com> Cc: Sean Paul <sean@poorly.run> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Tian Tao <tiantao6@hisilicon.com> Cc: Tomi Valkeinen <tomba@kernel.org> Cc: Xinliang Liu <xinliang.liu@linaro.org> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com> Ville Syrjälä (22): drm: Add drm_mode_init() drm/amdgpu: Remove pointless on stack mode copies drm/amdgpu: Use drm_mode_init() for on-stack modes drm/amdgpu: Use drm_mode_copy() drm/radeon: Use drm_mode_copy() drm/bridge: Use drm_mode_copy() drm/gma500: Use drm_mode_copy() drm/hisilicon: Use drm_mode_init() for on-stack modes drm/imx: Use drm_mode_duplicate() drm/msm: Nuke weird on stack mode copy drm/msm: Use drm_mode_init() for on-stack modes drm/msm: Use drm_mode_copy() drm/mtk: Use drm_mode_init() for on-stack modes drm/rockchip: Use drm_mode_copy() drm/sti: Use drm_mode_copy() drm/tilcdc: Use drm_mode_copy() drm/vc4: Use drm_mode_copy() drm/i915: Use drm_mode_init() for on-stack modes drm/i915: Use drm_mode_copy() drm/panel: Use drm_mode_duplicate() drm: Use drm_mode_init() for on-stack modes drm: Use drm_mode_copy() .../gpu/drm/amd/amdgpu/amdgpu_connectors.c | 4 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 41 ++++++++++--------- drivers/gpu/drm/bridge/nwl-dsi.c | 2 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 +- drivers/gpu/drm/bridge/tc358767.c | 2 +- drivers/gpu/drm/drm_crtc_helper.c | 12 +++--- drivers/gpu/drm/drm_edid.c | 8 +++- drivers/gpu/drm/drm_modes.c | 21 +++++++++- drivers/gpu/drm/drm_vblank.c | 2 +- drivers/gpu/drm/gma500/oaktrail_crtc.c | 8 +--- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 2 +- drivers/gpu/drm/i915/display/intel_display.c | 20 +++++---- drivers/gpu/drm/imx/imx-ldb.c | 3 +- drivers/gpu/drm/mediatek/mtk_hdmi.c | 2 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 +- .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 9 ++-- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- drivers/gpu/drm/msm/dp/dp_drm.c | 10 ++--- drivers/gpu/drm/panel/panel-truly-nt35597.c | 3 +- .../gpu/drm/panel/panel-visionox-rm69299.c | 4 +- drivers/gpu/drm/radeon/radeon_connectors.c | 4 +- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 2 +- drivers/gpu/drm/sti/sti_dvo.c | 2 +- drivers/gpu/drm/sti/sti_hda.c | 2 +- drivers/gpu/drm/sti/sti_hdmi.c | 2 +- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- drivers/gpu/drm/vc4/vc4_hdmi.c | 5 +-- include/drm/drm_modes.h | 2 + 30 files changed, 105 insertions(+), 79 deletions(-) -- 2.34.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 14/22] drm/rockchip: Use drm_mode_copy() 2022-02-18 10:03 [PATCH 00/22] drm: Review of mode copies Ville Syrjala @ 2022-02-18 10:03 ` Ville Syrjala 2022-03-14 22:11 ` [PATCH 00/22] drm: Review of mode copies Ville Syrjälä 1 sibling, 0 replies; 8+ messages in thread From: Ville Syrjala @ 2022-02-18 10:03 UTC (permalink / raw) To: dri-devel Cc: intel-gfx, Sandy Huang, Heiko Stübner, linux-arm-kernel, linux-rockchip From: Ville Syrjälä <ville.syrjala@linux.intel.com> struct drm_display_mode embeds a list head, so overwriting the full struct with another one will corrupt the list (if the destination mode is on a list). Use drm_mode_copy() instead which explicitly preserves the list head of the destination mode. Even if we know the destination mode is not on any list using drm_mode_copy() seems decent as it sets a good example. Bad examples of not using it might eventually get copied into code where preserving the list head actually matters. Obviously one case not covered here is when the mode itself is embedded in a larger structure and the whole structure is copied. But if we are careful when copying into modes embedded in structures I think we can be a little more reassured that bogus list heads haven't been propagated in. @is_mode_copy@ @@ drm_mode_copy(...) { ... } @depends on !is_mode_copy@ struct drm_display_mode *mode; expression E, S; @@ ( - *mode = E + drm_mode_copy(mode, &E) | - memcpy(mode, E, S) + drm_mode_copy(mode, E) ) @depends on !is_mode_copy@ struct drm_display_mode mode; expression E; @@ ( - mode = E + drm_mode_copy(&mode, &E) | - memcpy(&mode, E, S) + drm_mode_copy(&mode, E) ) @@ struct drm_display_mode *mode; @@ - &*mode + mode Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Cc: Sandy Huang <hjc@rock-chips.com> Cc: "Heiko Stübner" <heiko@sntech.de> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org --- drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +- drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c index 4740cc14beb8..adf1027a3f20 100644 --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c @@ -564,7 +564,7 @@ static void cdn_dp_encoder_mode_set(struct drm_encoder *encoder, video->v_sync_polarity = !!(mode->flags & DRM_MODE_FLAG_NVSYNC); video->h_sync_polarity = !!(mode->flags & DRM_MODE_FLAG_NHSYNC); - memcpy(&dp->mode, adjusted, sizeof(*mode)); + drm_mode_copy(&dp->mode, adjusted); } static bool cdn_dp_check_link_status(struct cdn_dp_device *dp) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 046e8ec2a71c..740196d30fba 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -488,7 +488,7 @@ static void inno_hdmi_encoder_mode_set(struct drm_encoder *encoder, inno_hdmi_setup(hdmi, adj_mode); /* Store the display mode for plugin/DPMS poweron events */ - memcpy(&hdmi->previous_mode, adj_mode, sizeof(hdmi->previous_mode)); + drm_mode_copy(&hdmi->previous_mode, adj_mode); } static void inno_hdmi_encoder_enable(struct drm_encoder *encoder) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c index 1c546c3a8998..17e7c40a9e7b 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -383,7 +383,7 @@ rk3066_hdmi_encoder_mode_set(struct drm_encoder *encoder, struct rk3066_hdmi *hdmi = to_rk3066_hdmi(encoder); /* Store the display mode for plugin/DPMS poweron events. */ - memcpy(&hdmi->previous_mode, adj_mode, sizeof(hdmi->previous_mode)); + drm_mode_copy(&hdmi->previous_mode, adj_mode); } static void rk3066_hdmi_encoder_enable(struct drm_encoder *encoder) -- 2.34.1 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 00/22] drm: Review of mode copies 2022-02-18 10:03 [PATCH 00/22] drm: Review of mode copies Ville Syrjala 2022-02-18 10:03 ` [PATCH 14/22] drm/rockchip: Use drm_mode_copy() Ville Syrjala @ 2022-03-14 22:11 ` Ville Syrjälä 2022-03-15 18:52 ` Alex Deucher 1 sibling, 1 reply; 8+ messages in thread From: Ville Syrjälä @ 2022-03-14 22:11 UTC (permalink / raw) To: dri-devel Cc: intel-gfx, Abhinav Kumar, Alain Volmat, Alex Deucher, amd-gfx, Andrzej Hajda, Aurabindo Pillai, Chen Feng, Chun-Kuang Hu, Emma Anholt, freedreno, Harry Wentland, Heiko Stübner, Jernej Skrabec, John Stultz, Jonas Karlman, Jyri Sarha, Laurent Pinchart, Leo Li, linux-arm-kernel, linux-arm-msm, linux-rockchip, Maxime Ripard, Neil Armstrong, Nikola Cornij, Patrik Jakobsson, Philipp Zabel, Rob Clark, Robert Foss, Rodrigo Siqueira, Sam Ravnborg, Sandy Huang, Sean Paul, Thierry Reding, Tian Tao, Tomi Valkeinen, Xinliang Liu, Xinwei Kong On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > drm: Add drm_mode_init() > drm/bridge: Use drm_mode_copy() > drm/imx: Use drm_mode_duplicate() > drm/panel: Use drm_mode_duplicate() > drm/vc4: Use drm_mode_copy() These have been pushed to drm-misc-next. > drm/amdgpu: Remove pointless on stack mode copies > drm/amdgpu: Use drm_mode_init() for on-stack modes > drm/amdgpu: Use drm_mode_copy() amdgpu ones are reviewed, but I'll leave them for the AMD folks to push to whichever tree they prefer. The rest are still in need of review: > drm/radeon: Use drm_mode_copy() > drm/gma500: Use drm_mode_copy() > drm/hisilicon: Use drm_mode_init() for on-stack modes > drm/msm: Nuke weird on stack mode copy > drm/msm: Use drm_mode_init() for on-stack modes > drm/msm: Use drm_mode_copy() > drm/mtk: Use drm_mode_init() for on-stack modes > drm/rockchip: Use drm_mode_copy() > drm/sti: Use drm_mode_copy() > drm/tilcdc: Use drm_mode_copy() > drm/i915: Use drm_mode_init() for on-stack modes > drm/i915: Use drm_mode_copy() > drm: Use drm_mode_init() for on-stack modes > drm: Use drm_mode_copy() -- Ville Syrjälä Intel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/22] drm: Review of mode copies 2022-03-14 22:11 ` [PATCH 00/22] drm: Review of mode copies Ville Syrjälä @ 2022-03-15 18:52 ` Alex Deucher 2022-03-21 22:37 ` Ville Syrjälä 0 siblings, 1 reply; 8+ messages in thread From: Alex Deucher @ 2022-03-15 18:52 UTC (permalink / raw) To: Ville Syrjälä Cc: Maling list - DRI developers, Heiko Stübner, Emma Anholt, Neil Armstrong, Xinliang Liu, Thierry Reding, Jernej Skrabec, Andrzej Hajda, Sam Ravnborg, Rodrigo Siqueira, amd-gfx list, linux-rockchip, Xinwei Kong, Aurabindo Pillai, Chen Feng, Alain Volmat, Harry Wentland, Chun-Kuang Hu, Jonas Karlman, Leo Li, linux-arm-msm, Intel Graphics Development, Abhinav Kumar, Maxime Ripard, Nikola Cornij, John Stultz, Sean Paul, linux-arm-kernel, Tomi Valkeinen, Jyri Sarha, Sandy Huang, Robert Foss, Patrik Jakobsson, Rob Clark, Philipp Zabel, Alex Deucher, Tian Tao, freedreno, Laurent Pinchart On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > > drm: Add drm_mode_init() > > drm/bridge: Use drm_mode_copy() > > drm/imx: Use drm_mode_duplicate() > > drm/panel: Use drm_mode_duplicate() > > drm/vc4: Use drm_mode_copy() > These have been pushed to drm-misc-next. > > > drm/amdgpu: Remove pointless on stack mode copies > > drm/amdgpu: Use drm_mode_init() for on-stack modes > > drm/amdgpu: Use drm_mode_copy() > amdgpu ones are reviewed, but I'll leave them for the > AMD folks to push to whichever tree they prefer. I pulled patches 2, 4, 5 into my tree. For 3, I'm happy to have it land via drm-misc with the rest of the mode_init changes if you'd prefer. Alex Alex > > > The rest are still in need of review: > > drm/radeon: Use drm_mode_copy() > > drm/gma500: Use drm_mode_copy() > > drm/hisilicon: Use drm_mode_init() for on-stack modes > > drm/msm: Nuke weird on stack mode copy > > drm/msm: Use drm_mode_init() for on-stack modes > > drm/msm: Use drm_mode_copy() > > drm/mtk: Use drm_mode_init() for on-stack modes > > drm/rockchip: Use drm_mode_copy() > > drm/sti: Use drm_mode_copy() > > drm/tilcdc: Use drm_mode_copy() > > drm/i915: Use drm_mode_init() for on-stack modes > > drm/i915: Use drm_mode_copy() > > drm: Use drm_mode_init() for on-stack modes > > drm: Use drm_mode_copy() > > -- > Ville Syrjälä > Intel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/22] drm: Review of mode copies 2022-03-15 18:52 ` Alex Deucher @ 2022-03-21 22:37 ` Ville Syrjälä 2022-03-23 10:39 ` Dmitry Baryshkov 0 siblings, 1 reply; 8+ messages in thread From: Ville Syrjälä @ 2022-03-21 22:37 UTC (permalink / raw) To: Alex Deucher Cc: Maling list - DRI developers, Heiko Stübner, Emma Anholt, Neil Armstrong, Xinliang Liu, Thierry Reding, Jernej Skrabec, Andrzej Hajda, Sam Ravnborg, Rodrigo Siqueira, amd-gfx list, linux-rockchip, Xinwei Kong, Aurabindo Pillai, Chen Feng, Alain Volmat, Harry Wentland, Chun-Kuang Hu, Jonas Karlman, Leo Li, linux-arm-msm, Intel Graphics Development, Abhinav Kumar, Maxime Ripard, Nikola Cornij, John Stultz, Sean Paul, linux-arm-kernel, Tomi Valkeinen, Jyri Sarha, Sandy Huang, Robert Foss, Patrik Jakobsson, Rob Clark, Philipp Zabel, Alex Deucher, Tian Tao, freedreno, Laurent Pinchart On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: > On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä > <ville.syrjala@linux.intel.com> wrote: > > > > On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > > > drm: Add drm_mode_init() > > > drm/bridge: Use drm_mode_copy() > > > drm/imx: Use drm_mode_duplicate() > > > drm/panel: Use drm_mode_duplicate() > > > drm/vc4: Use drm_mode_copy() > > These have been pushed to drm-misc-next. > > > > > drm/amdgpu: Remove pointless on stack mode copies > > > drm/amdgpu: Use drm_mode_init() for on-stack modes > > > drm/amdgpu: Use drm_mode_copy() > > amdgpu ones are reviewed, but I'll leave them for the > > AMD folks to push to whichever tree they prefer. > > I pulled patches 2, 4, 5 into my tree. Thanks. > For 3, I'm happy to have it > land via drm-misc with the rest of the mode_init changes if you'd > prefer. Either way works for me. I don't yet have reviews yet for the other drivers, so I'll proably hold off for a bit more at least. And the i915 patch I'll be merging via drm-intel. > > > drm/radeon: Use drm_mode_copy() > > > drm/gma500: Use drm_mode_copy() > > > drm/tilcdc: Use drm_mode_copy() > > > drm/i915: Use drm_mode_copy() Those are now all in. Which leaves us with these stragglers: > > > drm/hisilicon: Use drm_mode_init() for on-stack modes > > > drm/msm: Nuke weird on stack mode copy > > > drm/msm: Use drm_mode_init() for on-stack modes > > > drm/msm: Use drm_mode_copy() > > > drm/mtk: Use drm_mode_init() for on-stack modes > > > drm/rockchip: Use drm_mode_copy() > > > drm/sti: Use drm_mode_copy() > > > drm: Use drm_mode_init() for on-stack modes > > > drm: Use drm_mode_copy() -- Ville Syrjälä Intel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/22] drm: Review of mode copies 2022-03-21 22:37 ` Ville Syrjälä @ 2022-03-23 10:39 ` Dmitry Baryshkov 2022-03-23 15:10 ` Ville Syrjälä 2022-03-23 20:50 ` Abhinav Kumar 0 siblings, 2 replies; 8+ messages in thread From: Dmitry Baryshkov @ 2022-03-23 10:39 UTC (permalink / raw) To: Ville Syrjälä, Alex Deucher Cc: Maling list - DRI developers, Heiko Stübner, Emma Anholt, Neil Armstrong, Xinliang Liu, Thierry Reding, Jernej Skrabec, Andrzej Hajda, Sam Ravnborg, Rodrigo Siqueira, amd-gfx list, linux-rockchip, Xinwei Kong, Aurabindo Pillai, Chen Feng, Alain Volmat, Harry Wentland, Chun-Kuang Hu, Jonas Karlman, Leo Li, linux-arm-msm, Intel Graphics Development, Abhinav Kumar, Maxime Ripard, Nikola Cornij, John Stultz, Sean Paul, linux-arm-kernel, Tomi Valkeinen, Jyri Sarha, Sandy Huang, Robert Foss, Patrik Jakobsson, Rob Clark, Philipp Zabel, Alex Deucher, Tian Tao, freedreno, Laurent Pinchart On 22/03/2022 01:37, Ville Syrjälä wrote: > On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >> <ville.syrjala@linux.intel.com> wrote: >>> >>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>> drm: Add drm_mode_init() >>>> drm/bridge: Use drm_mode_copy() >>>> drm/imx: Use drm_mode_duplicate() >>>> drm/panel: Use drm_mode_duplicate() >>>> drm/vc4: Use drm_mode_copy() >>> These have been pushed to drm-misc-next. >>> >>>> drm/amdgpu: Remove pointless on stack mode copies >>>> drm/amdgpu: Use drm_mode_init() for on-stack modes >>>> drm/amdgpu: Use drm_mode_copy() >>> amdgpu ones are reviewed, but I'll leave them for the >>> AMD folks to push to whichever tree they prefer. >> >> I pulled patches 2, 4, 5 into my tree. > > Thanks. > >> For 3, I'm happy to have it >> land via drm-misc with the rest of the mode_init changes if you'd >> prefer. > > Either way works for me. I don't yet have reviews yet for > the other drivers, so I'll proably hold off for a bit more > at least. And the i915 patch I'll be merging via drm-intel. > >>>> drm/radeon: Use drm_mode_copy() >>>> drm/gma500: Use drm_mode_copy() >>>> drm/tilcdc: Use drm_mode_copy() >>>> drm/i915: Use drm_mode_copy() > > Those are now all in. > > Which leaves us with these stragglers: >>>> drm/hisilicon: Use drm_mode_init() for on-stack modes >>>> drm/msm: Nuke weird on stack mode copy >>>> drm/msm: Use drm_mode_init() for on-stack modes >>>> drm/msm: Use drm_mode_copy() These three patches went beneath my radar for some reason. I have just sent a replacement for the first patch ([1]). Other two patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next development cycle if that works for you. [1] https://patchwork.freedesktop.org/series/101682/ >>>> drm/mtk: Use drm_mode_init() for on-stack modes >>>> drm/rockchip: Use drm_mode_copy() >>>> drm/sti: Use drm_mode_copy() >>>> drm: Use drm_mode_init() for on-stack modes >>>> drm: Use drm_mode_copy() > -- With best wishes Dmitry _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/22] drm: Review of mode copies 2022-03-23 10:39 ` Dmitry Baryshkov @ 2022-03-23 15:10 ` Ville Syrjälä 2022-03-23 20:50 ` Abhinav Kumar 1 sibling, 0 replies; 8+ messages in thread From: Ville Syrjälä @ 2022-03-23 15:10 UTC (permalink / raw) To: Dmitry Baryshkov Cc: Alex Deucher, Maling list - DRI developers, Heiko Stübner, Emma Anholt, Neil Armstrong, Xinliang Liu, Thierry Reding, Jernej Skrabec, Andrzej Hajda, Sam Ravnborg, Rodrigo Siqueira, amd-gfx list, linux-rockchip, Xinwei Kong, Aurabindo Pillai, Chen Feng, Alain Volmat, Harry Wentland, Chun-Kuang Hu, Jonas Karlman, Leo Li, linux-arm-msm, Intel Graphics Development, Abhinav Kumar, Maxime Ripard, Nikola Cornij, John Stultz, Sean Paul, linux-arm-kernel, Tomi Valkeinen, Jyri Sarha, Sandy Huang, Robert Foss, Patrik Jakobsson, Rob Clark, Philipp Zabel, Alex Deucher, Tian Tao, freedreno, Laurent Pinchart On Wed, Mar 23, 2022 at 01:39:44PM +0300, Dmitry Baryshkov wrote: > On 22/03/2022 01:37, Ville Syrjälä wrote: > > On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: > >> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä > >> <ville.syrjala@linux.intel.com> wrote: > >>> > >>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: > >>>> drm: Add drm_mode_init() > >>>> drm/bridge: Use drm_mode_copy() > >>>> drm/imx: Use drm_mode_duplicate() > >>>> drm/panel: Use drm_mode_duplicate() > >>>> drm/vc4: Use drm_mode_copy() > >>> These have been pushed to drm-misc-next. > >>> > >>>> drm/amdgpu: Remove pointless on stack mode copies > >>>> drm/amdgpu: Use drm_mode_init() for on-stack modes > >>>> drm/amdgpu: Use drm_mode_copy() > >>> amdgpu ones are reviewed, but I'll leave them for the > >>> AMD folks to push to whichever tree they prefer. > >> > >> I pulled patches 2, 4, 5 into my tree. > > > > Thanks. > > > >> For 3, I'm happy to have it > >> land via drm-misc with the rest of the mode_init changes if you'd > >> prefer. > > > > Either way works for me. I don't yet have reviews yet for > > the other drivers, so I'll proably hold off for a bit more > > at least. And the i915 patch I'll be merging via drm-intel. > > > >>>> drm/radeon: Use drm_mode_copy() > >>>> drm/gma500: Use drm_mode_copy() > >>>> drm/tilcdc: Use drm_mode_copy() > >>>> drm/i915: Use drm_mode_copy() > > > > Those are now all in. > > > > Which leaves us with these stragglers: > >>>> drm/hisilicon: Use drm_mode_init() for on-stack modes > > >>>> drm/msm: Nuke weird on stack mode copy > >>>> drm/msm: Use drm_mode_init() for on-stack modes > >>>> drm/msm: Use drm_mode_copy() > > These three patches went beneath my radar for some reason. > > I have just sent a replacement for the first patch ([1]). Other two > patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next > development cycle if that works for you. That'll do fine for me. Thanks. > > [1] https://patchwork.freedesktop.org/series/101682/ > > >>>> drm/mtk: Use drm_mode_init() for on-stack modes > >>>> drm/rockchip: Use drm_mode_copy() > >>>> drm/sti: Use drm_mode_copy() > >>>> drm: Use drm_mode_init() for on-stack modes > >>>> drm: Use drm_mode_copy() > > > > > -- > With best wishes > Dmitry -- Ville Syrjälä Intel _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 00/22] drm: Review of mode copies 2022-03-23 10:39 ` Dmitry Baryshkov 2022-03-23 15:10 ` Ville Syrjälä @ 2022-03-23 20:50 ` Abhinav Kumar 1 sibling, 0 replies; 8+ messages in thread From: Abhinav Kumar @ 2022-03-23 20:50 UTC (permalink / raw) To: Dmitry Baryshkov, Ville Syrjälä, Alex Deucher Cc: Emma Anholt, Neil Armstrong, Xinliang Liu, Maling list - DRI developers, Thierry Reding, Jernej Skrabec, Andrzej Hajda, Sam Ravnborg, Rodrigo Siqueira, amd-gfx list, linux-rockchip, Xinwei Kong, Aurabindo Pillai, linux-arm-msm, Alain Volmat, Chun-Kuang Hu, Jonas Karlman, Leo Li, Chen Feng, Intel Graphics Development, Nikola Cornij, Sean Paul, linux-arm-kernel, Tomi Valkeinen, freedreno, Sandy Huang, Robert Foss, Alex Deucher, Tian Tao, Jyri Sarha, Laurent Pinchart On 3/23/2022 3:39 AM, Dmitry Baryshkov wrote: > On 22/03/2022 01:37, Ville Syrjälä wrote: >> On Tue, Mar 15, 2022 at 02:52:38PM -0400, Alex Deucher wrote: >>> On Mon, Mar 14, 2022 at 6:12 PM Ville Syrjälä >>> <ville.syrjala@linux.intel.com> wrote: >>>> >>>> On Fri, Feb 18, 2022 at 12:03:41PM +0200, Ville Syrjala wrote: >>>>> drm: Add drm_mode_init() >>>>> drm/bridge: Use drm_mode_copy() >>>>> drm/imx: Use drm_mode_duplicate() >>>>> drm/panel: Use drm_mode_duplicate() >>>>> drm/vc4: Use drm_mode_copy() >>>> These have been pushed to drm-misc-next. >>>> >>>>> drm/amdgpu: Remove pointless on stack mode copies >>>>> drm/amdgpu: Use drm_mode_init() for on-stack modes >>>>> drm/amdgpu: Use drm_mode_copy() >>>> amdgpu ones are reviewed, but I'll leave them for the >>>> AMD folks to push to whichever tree they prefer. >>> >>> I pulled patches 2, 4, 5 into my tree. >> >> Thanks. >> >>> For 3, I'm happy to have it >>> land via drm-misc with the rest of the mode_init changes if you'd >>> prefer. >> >> Either way works for me. I don't yet have reviews yet for >> the other drivers, so I'll proably hold off for a bit more >> at least. And the i915 patch I'll be merging via drm-intel. >> >>>>> drm/radeon: Use drm_mode_copy() >>>>> drm/gma500: Use drm_mode_copy() >>>>> drm/tilcdc: Use drm_mode_copy() >>>>> drm/i915: Use drm_mode_copy() >> >> Those are now all in. >> >> Which leaves us with these stragglers: >>>>> drm/hisilicon: Use drm_mode_init() for on-stack modes > >>>>> drm/msm: Nuke weird on stack mode copy >>>>> drm/msm: Use drm_mode_init() for on-stack modes >>>>> drm/msm: Use drm_mode_copy() > > These three patches went beneath my radar for some reason. > > I have just sent a replacement for the first patch ([1]). Other two > patches can be pulled in msm/msm-next (or msm/msm-fixes) during the next > development cycle if that works for you. > > [1] https://patchwork.freedesktop.org/series/101682/ Agree with this approach. We can replace the first patch with https://patchwork.freedesktop.org/series/101682/. Thanks Abhinav > >>>>> drm/mtk: Use drm_mode_init() for on-stack modes >>>>> drm/rockchip: Use drm_mode_copy() >>>>> drm/sti: Use drm_mode_copy() >>>>> drm: Use drm_mode_init() for on-stack modes >>>>> drm: Use drm_mode_copy() >> > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-03-23 20:50 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-02-18 10:03 [PATCH 00/22] drm: Review of mode copies Ville Syrjala 2022-02-18 10:03 ` [PATCH 14/22] drm/rockchip: Use drm_mode_copy() Ville Syrjala 2022-03-14 22:11 ` [PATCH 00/22] drm: Review of mode copies Ville Syrjälä 2022-03-15 18:52 ` Alex Deucher 2022-03-21 22:37 ` Ville Syrjälä 2022-03-23 10:39 ` Dmitry Baryshkov 2022-03-23 15:10 ` Ville Syrjälä 2022-03-23 20:50 ` Abhinav Kumar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox