From: Zenghui Yu <yuzenghui@huawei.com>
To: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Cc: "Joerg Roedel" <joro@8bytes.org>, "Will Deacon" <will@kernel.org>,
"Robin Murphy" <robin.murphy@arm.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Tomeu Vizoso" <tomeu.vizoso@tomeuvizoso.net>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH 6/9] accel/rocket: Add a new driver for Rockchip's NPU
Date: Tue, 9 Jul 2024 15:29:53 +0800 [thread overview]
Message-ID: <ad2628b2-aab2-2c7a-d4df-5356c55fae39@huawei.com> (raw)
In-Reply-To: <20240612-6-10-rocket-v1-6-060e48eea250@tomeuvizoso.net>
On 2024/6/12 21:52, Tomeu Vizoso wrote:
> This initial version supports the NPU as shipped in the RK3588 SoC and
> described in the first part of its TRM, in Chapter 36.
>
> This NPU contains 3 independent cores that the driver can submit jobs
> to.
>
> This commit adds just hardware initialization and power management.
>
> Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
[...]
> +void rocket_core_reset(struct rocket_core *core)
> +{
> + reset_control_assert(core->a_reset);
> + reset_control_assert(core->h_reset);
> +
> + udelay(10);
> +
> + reset_control_deassert(core->a_reset);
> + reset_control_deassert(core->h_reset);
> +}
Seems unused.
> +void rocket_core_reset(struct rocket_core *core);
> +void rocket_device_reset(struct rocket_device *rdev);
Ditto.
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-07-09 7:30 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 13:52 [PATCH 0/9] New DRM accel driver for Rockchip's RKNN NPU Tomeu Vizoso
2024-06-12 13:52 ` [PATCH 1/9] iommu/rockchip: Add compatible for rockchip,rk3588-iommu Tomeu Vizoso
2024-06-12 23:37 ` Sebastian Reichel
2024-06-12 13:52 ` [PATCH 2/9] iommu/rockchip: Attach multiple power domains Tomeu Vizoso
2024-06-13 0:05 ` Sebastian Reichel
2024-06-13 9:24 ` Tomeu Vizoso
2024-06-13 9:34 ` Tomeu Vizoso
2024-06-13 21:38 ` Sebastian Reichel
2024-06-14 12:07 ` Robin Murphy
2024-09-11 11:07 ` Tomeu Vizoso
2024-09-11 11:03 ` Tomeu Vizoso
2024-06-12 13:52 ` [PATCH 3/9] dt-bindings: mailbox: rockchip,rknn: Add bindings Tomeu Vizoso
2024-06-12 16:33 ` Conor Dooley
2024-06-13 19:15 ` Rob Herring
2024-06-12 13:52 ` [PATCH 4/9] arm64: dts: rockchip: Add nodes for NPU and its MMU to rk3588s Tomeu Vizoso
2024-06-12 14:24 ` Diederik de Haas
2024-06-13 22:16 ` Sebastian Reichel
2024-06-15 3:32 ` kernel test robot
2024-06-12 13:52 ` [PATCH 5/9] arm64: dts: rockchip: Enable the NPU on quartzpro64 Tomeu Vizoso
2024-06-13 21:48 ` Sebastian Reichel
2024-06-12 13:52 ` [PATCH 6/9] accel/rocket: Add a new driver for Rockchip's NPU Tomeu Vizoso
2024-06-13 2:05 ` kernel test robot
2024-06-13 2:27 ` kernel test robot
2024-06-13 10:55 ` kernel test robot
2024-06-14 16:16 ` Jeffrey Hugo
2024-06-14 20:30 ` Nicolas Dufresne
2024-07-09 7:29 ` Zenghui Yu [this message]
2024-06-12 13:53 ` [PATCH 7/9] accel/rocket: Add IOCTL for BO creation Tomeu Vizoso
2024-06-14 16:21 ` Jeffrey Hugo
2024-06-12 13:53 ` [PATCH 8/9] accel/rocket: Add job submission IOCTL Tomeu Vizoso
2024-06-13 9:08 ` kernel test robot
2024-06-14 16:33 ` Jeffrey Hugo
2024-09-11 11:27 ` Markus Elfring
2024-09-11 12:02 ` Markus Elfring
2024-06-12 13:53 ` [PATCH 9/9] accel/rocket: Add IOCTLs for synchronizing memory accesses Tomeu Vizoso
2024-06-12 19:44 ` Friedrich Vock
2024-06-14 16:39 ` Jeffrey Hugo
2024-06-13 17:27 ` [PATCH 0/9] New DRM accel driver for Rockchip's RKNN NPU Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad2628b2-aab2-2c7a-d4df-5356c55fae39@huawei.com \
--to=yuzenghui@huawei.com \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzk+dt@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=ogabbay@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
--cc=tomeu.vizoso@tomeuvizoso.net \
--cc=tomeu@tomeuvizoso.net \
--cc=tzimmermann@suse.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox