From: Thomas Gleixner <tglx@linutronix.de>
To: Douglas Anderson <dianders@chromium.org>
Cc: John Stultz <john.stultz@linaro.org>,
Andreas Mohr <andi@lisas.de>,
briannorris@chromium.org, huangtao@rock-chips.com,
tony.xie@rock-chips.com, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] timers: Fix usleep_range() in the context of wake_up_process()
Date: Tue, 11 Oct 2016 09:14:38 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610110908240.7794@nanos> (raw)
In-Reply-To: <1476133442-17757-1-git-send-email-dianders@chromium.org>
On Mon, 10 Oct 2016, Douglas Anderson wrote:
> Users of usleep_range() expect that it will _never_ return in less time
> than the minimum passed parameter. However, nothing in any of the code
> ensures this. Specifically:
There is no such guarantee for that interface and never has been, so how
did you make sure that none of the existing users is relying on this?
You can't just can't just declare that all all of the users expect that and
be done with it.
Thanks,
tglx
next prev parent reply other threads:[~2016-10-11 7:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 21:04 [PATCH v2] timers: Fix usleep_range() in the context of wake_up_process() Douglas Anderson
2016-10-10 22:39 ` Doug Anderson
2016-10-11 7:14 ` Thomas Gleixner [this message]
2016-10-11 16:33 ` Doug Anderson
[not found] ` <CAD=FV=VTc-RFNiUqkKDr=NFWhphV7r2J+EudSbqt4X3TX62mQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-12 8:56 ` Mark Brown
2016-10-11 18:25 ` Andreas Mohr
[not found] ` <20161011182541.GA32165-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2016-10-12 13:11 ` Thomas Gleixner
2016-10-12 17:39 ` Doug Anderson
2016-10-11 20:34 ` Heiko Stuebner
[not found] ` <1476133442-17757-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-10-11 18:54 ` Brian Norris
2016-10-11 19:30 ` Andreas Mohr
[not found] ` <20161011193034.GA10646-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2016-10-11 20:02 ` Doug Anderson
[not found] ` <CAD=FV=Ua8c18SGr54ThmVe1oR3bqfCyHxfhL=6z8vJXkMiUedA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-11 20:40 ` Andreas Mohr
2016-10-12 16:03 ` [v2] " Guenter Roeck
[not found] ` <20161012160309.GA19146-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-10-12 16:27 ` Doug Anderson
[not found] ` <CAD=FV=Ug9P1XDvF-Z_gPeU4CtFzoXQZuy7rmdg4FNGFdT77ENQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-12 16:53 ` Guenter Roeck
2016-10-18 13:44 ` [PATCH v2] " Daniel Kurtz
2016-10-18 20:29 ` Doug Anderson
2016-10-20 8:57 ` Daniel Kurtz
2016-10-20 9:51 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610110908240.7794@nanos \
--to=tglx@linutronix.de \
--cc=andi@lisas.de \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=huangtao@rock-chips.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tony.xie@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox