From: Thomas Gleixner <tglx@linutronix.de>
To: Daniel Kurtz <djkurtz@chromium.org>
Cc: Doug Anderson <dianders@chromium.org>,
John Stultz <john.stultz@linaro.org>,
Tao Huang <huangtao@rock-chips.com>,
Brian Norris <briannorris@chromium.org>,
Andreas Mohr <andi@lisas.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Tony Xie <tony.xie@rock-chips.com>,
Akihiro Tsukada <tskd08@gmail.com>
Subject: Re: [PATCH v2] timers: Fix usleep_range() in the context of wake_up_process()
Date: Thu, 20 Oct 2016 11:51:12 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1610201150510.5073@nanos> (raw)
In-Reply-To: <CAGS+omB3197rGzwvNM66Ok4JtP=fUCRS349jmttk2NYXvd0KHA@mail.gmail.com>
On Thu, 20 Oct 2016, Daniel Kurtz wrote:
> On Wed, Oct 19, 2016 at 4:29 AM, Doug Anderson <dianders@chromium.org> wrote:
> > ...but I'm not sure I agree with you about what to do here.
> > Specifically I think that whatever we do we need to try to keep
> > schedule_hrtimeout_range() and schedule_timeout() parallel. For
> > schedule_timeout() we have the same comments but it's my understanding
> > that you'd expect that wake_up_process() would wake it up. In any
> > case, if wake_up_process() doesn't wake it up then it seems like
> > msleep() and schedule_timeout_uninterruptible() are the same function
> > with two names, when in fact one is implemented in terms o the other.
>
> Sounds reasonable.
> It would be nice to add a note to all of those function comments
> though to make them sound less absolute -
> "at least @timeout time is guaranteed to pass before the routine
> returns unless the current task is explicitly woken up, (e.g. by
> wake_up_process())"
Agreed.
prev parent reply other threads:[~2016-10-20 9:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 21:04 [PATCH v2] timers: Fix usleep_range() in the context of wake_up_process() Douglas Anderson
2016-10-10 22:39 ` Doug Anderson
2016-10-11 7:14 ` Thomas Gleixner
2016-10-11 16:33 ` Doug Anderson
[not found] ` <CAD=FV=VTc-RFNiUqkKDr=NFWhphV7r2J+EudSbqt4X3TX62mQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-12 8:56 ` Mark Brown
2016-10-11 18:25 ` Andreas Mohr
[not found] ` <20161011182541.GA32165-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2016-10-12 13:11 ` Thomas Gleixner
2016-10-12 17:39 ` Doug Anderson
2016-10-11 20:34 ` Heiko Stuebner
[not found] ` <1476133442-17757-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2016-10-11 18:54 ` Brian Norris
2016-10-11 19:30 ` Andreas Mohr
[not found] ` <20161011193034.GA10646-p/qQFhXj4MHA4IYVXhSI5GHfThorsUsI@public.gmane.org>
2016-10-11 20:02 ` Doug Anderson
[not found] ` <CAD=FV=Ua8c18SGr54ThmVe1oR3bqfCyHxfhL=6z8vJXkMiUedA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-11 20:40 ` Andreas Mohr
2016-10-12 16:03 ` [v2] " Guenter Roeck
[not found] ` <20161012160309.GA19146-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-10-12 16:27 ` Doug Anderson
[not found] ` <CAD=FV=Ug9P1XDvF-Z_gPeU4CtFzoXQZuy7rmdg4FNGFdT77ENQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-12 16:53 ` Guenter Roeck
2016-10-18 13:44 ` [PATCH v2] " Daniel Kurtz
2016-10-18 20:29 ` Doug Anderson
2016-10-20 8:57 ` Daniel Kurtz
2016-10-20 9:51 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610201150510.5073@nanos \
--to=tglx@linutronix.de \
--cc=andi@lisas.de \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=djkurtz@chromium.org \
--cc=huangtao@rock-chips.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tony.xie@rock-chips.com \
--cc=tskd08@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox