From: Manivannan Sadhasivam <mani@kernel.org>
To: Thomas Gleixner <tglx@kernel.org>, Shawn Lin <shawn.lin@rock-chips.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-rockchip@lists.infradead.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: dw-rockchip: Enable INTx affinity support
Date: Sun, 18 Oct 2026 10:05:39 +0530 [thread overview]
Message-ID: <atRLsp1qUA_sGS-0@debian> (raw)
In-Reply-To: <1790664898-207928-1-git-send-email-shawn.lin@rock-chips.com>
+ Thomas
On Tue, Sep 29, 2026 at 02:54:58PM +0800, Shawn Lin wrote:
> Leverage the interrupt redirection infrastructure to enable CPU
> affinity support for the legacy INTx interrupts. The INTx virqs are
> demultiplexed by the chained handler of the "legacy" interrupt, whose
> affinity cannot be changed, so affinity control for the INTx virqs is
> achieved by redirecting the handler to run in IRQ work context on the
> target CPU.
>
> Mask the INTx source in .irq_pre_redirect() before the handler is
> redirected: the legacy interrupt is level triggered, so an unmasked
> line would keep re-firing the chained interrupt until the redirected
> handler runs.
>
> Same approach as the DesignWare core, commit eaf290c404f7c39f2 ("PCI:
> dwc: Enable MSI affinity support").
>
> Test was done on RK3588 EVB1 board with an NVMe with pci=nomsi
> parameter. The /proc/interrupts columns are trimmed for brevity.
>
> # cat /proc/interrupts | grep INTx
> 51: 137 0 0 0 0 0 0 0 INTx 0 Edge PCIe PME, nvme0q0, nvme0q1
> # echo 10 > /proc/irq/51/smp_affinity
> # dd if=/dev/nvme0n1p1 of=/dev/null bs=1M count=200
> 200+0 records in
> 200+0 records out
> 209715200 bytes (210 MB, 200 MiB) copied, 0.182021 s, 1.2 GB/s
> # cat /proc/interrupts | grep INTx
> 51: 137 0 0 0 946 0 0 0 INTx 0 Edge PCIe PME, nvme0q0, nvme0q1
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
I'd like to get an Ack from Thomas for this patch since I'm not an irqchip
expert to decipher whether this patch is valid or not.
If this patch is valid and INTx affinity can be enabled like this, I'd like to
extend this to other RC drivers exposing INTx irqchip.
- Mani
--
மணிவண்ணன் சதாசிவம்
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2026-10-18 4:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 6:54 [PATCH] PCI: dw-rockchip: Enable INTx affinity support Shawn Lin
2026-10-18 4:35 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atRLsp1qUA_sGS-0@debian \
--to=mani@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox