public inbox for linux-rockchip@lists.infradead.org
 help / color / mirror / Atom feed
From: "Paweł Jarosz" <paweljarosz3691-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/3] ARM: dts: rockchip: Enable build of rk3066 MK808 dts
Date: Thu, 6 Oct 2016 19:05:15 +0200	[thread overview]
Message-ID: <c6d58e9b-8d36-61c5-5af1-59b1c293d969@gmail.com> (raw)
In-Reply-To: <46121446.zsYkG9qnut@phil>

Hi Heiko



> This patch breaks bisectability, as it adds a dtb to the makefile that you only
> add in patch3 which makes builds fail. Please fold your patches 1 and 3 into
> one patch and also add and entry to Documentation/devicetree/bindings/arm/
> rockchip.txt for the board.
>
>
> Heiko

Should i squash all patches in one?

I saw now in logs that it's common practise.


Paweł


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2016-10-06 17:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06 16:22 [PATCH 0/3] Add MK808 RK3066 device =?UTF-8?q?Pawe=C5=82=20Jarosz?=
     [not found] ` <cover.1475764778.git.paweljarosz3691-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-06 16:22   ` [PATCH 1/3] ARM: dts: rockchip: Enable build of rk3066 MK808 dts =?UTF-8?q?Pawe=C5=82=20Jarosz?=
     [not found]     ` <84d4bc0b733cb9776f03ad54bb946fd1c4be4049.1475764778.git.paweljarosz3691-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-06 16:33       ` Heiko Stuebner
2016-10-06 17:05         ` Paweł Jarosz [this message]
2016-10-06 17:05           ` Heiko Stuebner
2016-10-06 16:23   ` [PATCH 2/3] devicetree: Add vendor prefix for Rikomagic =?UTF-8?q?Pawe=C5=82=20Jarosz?=
2016-10-06 16:23   ` [PATCH 3/3] ARM: dts: rockchip: Add rk3066 MK808 board devicetree description file =?UTF-8?q?Pawe=C5=82=20Jarosz?=

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6d58e9b-8d36-61c5-5af1-59b1c293d969@gmail.com \
    --to=paweljarosz3691-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
    --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox