From: Heiko Stuebner <heiko@sntech.de>
To: "Paweł Jarosz" <paweljarosz3691@gmail.com>
Cc: mark.rutland@arm.com, linux-rockchip@lists.infradead.org,
robh+dt@kernel.org, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: rockchip: Enable build of rk3066 MK808 dts
Date: Thu, 06 Oct 2016 19:05:26 +0200 [thread overview]
Message-ID: <2552415.D3JWyKI0Mg@phil> (raw)
In-Reply-To: <c6d58e9b-8d36-61c5-5af1-59b1c293d969@gmail.com>
Am Donnerstag, 6. Oktober 2016, 19:05:15 CEST schrieb Paweł Jarosz:
> Hi Heiko
>
> > This patch breaks bisectability, as it adds a dtb to the makefile that you
> > only add in patch3 which makes builds fail. Please fold your patches 1
> > and 3 into one patch and also add and entry to
> > Documentation/devicetree/bindings/arm/ rockchip.txt for the board.
> >
> >
> > Heiko
>
> Should i squash all patches in one?
>
> I saw now in logs that it's common practise.
Nope ... vendor-prefix should stay separate, everything else can be in one
patch.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-10-06 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 16:22 [PATCH 0/3] Add MK808 RK3066 device =?UTF-8?q?Pawe=C5=82=20Jarosz?=
[not found] ` <cover.1475764778.git.paweljarosz3691-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-06 16:22 ` [PATCH 1/3] ARM: dts: rockchip: Enable build of rk3066 MK808 dts =?UTF-8?q?Pawe=C5=82=20Jarosz?=
[not found] ` <84d4bc0b733cb9776f03ad54bb946fd1c4be4049.1475764778.git.paweljarosz3691-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-10-06 16:33 ` Heiko Stuebner
2016-10-06 17:05 ` Paweł Jarosz
2016-10-06 17:05 ` Heiko Stuebner [this message]
2016-10-06 16:23 ` [PATCH 2/3] devicetree: Add vendor prefix for Rikomagic =?UTF-8?q?Pawe=C5=82=20Jarosz?=
2016-10-06 16:23 ` [PATCH 3/3] ARM: dts: rockchip: Add rk3066 MK808 board devicetree description file =?UTF-8?q?Pawe=C5=82=20Jarosz?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2552415.D3JWyKI0Mg@phil \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=paweljarosz3691@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox