From: Andrew Lunn <andrew@lunn.ch>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: Heiko Stuebner <heiko@sntech.de>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yao Zi <ziyao@disroot.org>,
linux-rockchip@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: rockchip: Enable Ethernet controller on Radxa E20C
Date: Fri, 7 Mar 2025 14:25:58 +0100 [thread overview]
Message-ID: <c7fe0371-76bc-4cb4-ade8-e22112c1475d@lunn.ch> (raw)
In-Reply-To: <cbd6d3ee-8ad1-443f-9506-e28240ffb09e@kwiboo.se>
On Fri, Mar 07, 2025 at 10:16:08AM +0100, Jonas Karlman wrote:
> Hi Andrew,
>
> On 2025-03-06 23:49, Andrew Lunn wrote:
> >> +&mdio1 {
> >> + rgmii_phy: ethernet-phy@1 {
> >> + compatible = "ethernet-phy-ieee802.3-c22";
> >
> > The compatible is not needed. That is the default.
>
> Interesting, however I rather be explicit to not cause any issue for
> U-Boot or any other user of the device trees beside Linux kernel.
O.K. But any system using Linux .dts files should be happy with no
compatible, since that is how the majority are. Because PHYs have ID
registers, generally there is no need for a compatible. The only time
you do need a compatible is:
* The ID registers are wrong
* The ID registers cannot be read, chicken/egg problems the driver needs to solve
* The Clause 22 address space is not implemented and you need to indicate C45
should be used to get the ID registers.
None of this is specific to Linux.
Andrew
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2025-03-07 13:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 22:13 [PATCH 0/4] rockchip: Enable Ethernet controller on Radxa E20C Jonas Karlman
2025-03-06 22:13 ` [PATCH 1/4] dt-bindings: net: rockchip-dwmac: Add compatible string for RK3528 Jonas Karlman
2025-03-07 15:42 ` Conor Dooley
2025-03-07 16:01 ` Jonas Karlman
2025-03-06 22:13 ` [PATCH 2/4] ethernet: stmmac: dwmac-rk: Add GMAC support " Jonas Karlman
2025-03-06 22:13 ` [PATCH 3/4] arm64: dts: rockchip: Add GMAC nodes " Jonas Karlman
2025-03-06 22:46 ` Andrew Lunn
2025-03-07 0:05 ` Jonas Karlman
2025-03-07 14:02 ` Andrew Lunn
2025-03-06 22:13 ` [PATCH 4/4] arm64: dts: rockchip: Enable Ethernet controller on Radxa E20C Jonas Karlman
2025-03-06 22:49 ` Andrew Lunn
2025-03-07 9:16 ` Jonas Karlman
2025-03-07 13:25 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7fe0371-76bc-4cb4-ade8-e22112c1475d@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox