From: Robin Murphy <robin.murphy@arm.com>
To: Vicente Bergas <vicencb@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Johan Jonker <jbx6244@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
Douglas Anderson <dianders@chromium.org>,
Carlos de Paula <me@carlosedp.com>,
Sugar Zhang <sugar.zhang@rock-chips.com>,
Shunqian Zheng <zhengsq@rock-chips.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
linux-rockchip@lists.infradead.org
Cc: nd@arm.com
Subject: Re: [PATCH] arm64: dts: rockchip: Fix iomux for PCIe on rk3399
Date: Fri, 4 Dec 2020 12:01:10 +0000 [thread overview]
Message-ID: <deaf148f-f8a1-0411-db40-192c4913d945@arm.com> (raw)
In-Reply-To: <20201201150522.923-1-vicencb@gmail.com>
On 2020-12-01 15:05, Vicente Bergas wrote:
> Fix PCIe pins according to the documentation
> http://opensource.rock-chips.com/images/e/ee/Rockchip_RK3399TRM_V1.4_Part1-20170408.pdf
> in page 301:
> GRF_GPIO2D_IOMUX[5:4] gpio2d2_sel
> 0: gpio
> 1: sdio_detectn
> 2: pcie_clkreqn
> and page 313:
> GRF_GPIO4D_IOMUX[1:0] gpio4d0_sel
> 0: gpio
> 1: pcie_clkreqnb
What exactly is this fixing? Commit 461a00bb9d53 explicitly removed pin
configurations for these functions on the grounds that they apparently
don't work. FWIW it looks like they might also be related to some magic
in GRF_SOC_CON7 which nobody's touching either.
Robin.
> Signed-off-by: Vicente Bergas <vicencb@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index ada724b12..b37dac094 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -2666,13 +2666,11 @@ hdmi_cec: hdmi-cec {
>
> pcie {
> pcie_clkreqn_cpm: pci-clkreqn-cpm {
> - rockchip,pins =
> - <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;
> + rockchip,pins = <2 RK_PD2 2 &pcfg_pull_none>;
> };
>
> pcie_clkreqnb_cpm: pci-clkreqnb-cpm {
> - rockchip,pins =
> - <4 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>;
> + rockchip,pins = <4 RK_PD0 1 &pcfg_pull_none>;
> };
> };
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2020-12-04 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 15:05 [PATCH] arm64: dts: rockchip: Fix iomux for PCIe on rk3399 Vicente Bergas
2020-12-04 12:01 ` Robin Murphy [this message]
2020-12-04 12:33 ` Vicente Bergas
2020-12-04 12:36 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deaf148f-f8a1-0411-db40-192c4913d945@arm.com \
--to=robin.murphy@arm.com \
--cc=boris.brezillon@collabora.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=me@carlosedp.com \
--cc=nd@arm.com \
--cc=robh+dt@kernel.org \
--cc=sugar.zhang@rock-chips.com \
--cc=vicencb@gmail.com \
--cc=wens@csie.org \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox