From: "Heiko Stübner" <heiko@sntech.de>
To: Robin Murphy <robin.murphy@arm.com>, Vicente Bergas <vicencb@gmail.com>
Cc: Carlos de Paula <me@carlosedp.com>,
Douglas Anderson <dianders@chromium.org>,
Sugar Zhang <sugar.zhang@rock-chips.com>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Boris Brezillon <boris.brezillon@collabora.com>,
Johan Jonker <jbx6244@gmail.com>,
nd@arm.com, Shunqian Zheng <zhengsq@rock-chips.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix iomux for PCIe on rk3399
Date: Fri, 04 Dec 2020 13:36:35 +0100 [thread overview]
Message-ID: <20873050.EfDdHjke4D@diego> (raw)
In-Reply-To: <CAAMcf8DyPzErWCJvBi9y4-6vtkYp9nG5=DJLytNuz8bcbqX=ig@mail.gmail.com>
Am Freitag, 4. Dezember 2020, 13:33:16 CET schrieb Vicente Bergas:
> On Fri, Dec 4, 2020 at 1:01 PM Robin Murphy <robin.murphy@arm.com> wrote:
> >
> > On 2020-12-01 15:05, Vicente Bergas wrote:
> > > Fix PCIe pins according to the documentation
> > > http://opensource.rock-chips.com/images/e/ee/Rockchip_RK3399TRM_V1.4_Part1-20170408.pdf
> > > in page 301:
> > > GRF_GPIO2D_IOMUX[5:4] gpio2d2_sel
> > > 0: gpio
> > > 1: sdio_detectn
> > > 2: pcie_clkreqn
> > > and page 313:
> > > GRF_GPIO4D_IOMUX[1:0] gpio4d0_sel
> > > 0: gpio
> > > 1: pcie_clkreqnb
> >
> > What exactly is this fixing? Commit 461a00bb9d53 explicitly removed pin
> > configurations for these functions on the grounds that they apparently
> > don't work. FWIW it looks like they might also be related to some magic
> > in GRF_SOC_CON7 which nobody's touching either.
> >
> > Robin.
>
> This fixes nothing.
> I've got a non-working NVMe and while debugging the issue found this
> mismatch between the DTS and documentation.
> So i fixed it by changing the DTS.
> Regarding 461a00bb9d53 it looks like the issue is in the documentation
> instead, but there are no (public) errata documents.
> The issue with the NVMe i've got was unrelated: controller chip not
> correctly soldered.
> Now i've tested that NVMe again without this change and it still
> works, so, ignore this patch.
> Thanks for reviewing.
thanks for letting us know ;-)
And also thanks Robin for digging up the history of this.
I was about to ask something similar but hadn't found the time yet
to dig through past pcie changes.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
prev parent reply other threads:[~2020-12-04 12:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 15:05 [PATCH] arm64: dts: rockchip: Fix iomux for PCIe on rk3399 Vicente Bergas
2020-12-04 12:01 ` Robin Murphy
2020-12-04 12:33 ` Vicente Bergas
2020-12-04 12:36 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20873050.EfDdHjke4D@diego \
--to=heiko@sntech.de \
--cc=boris.brezillon@collabora.com \
--cc=dianders@chromium.org \
--cc=jbx6244@gmail.com \
--cc=linux-rockchip@lists.infradead.org \
--cc=me@carlosedp.com \
--cc=nd@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sugar.zhang@rock-chips.com \
--cc=vicencb@gmail.com \
--cc=wens@csie.org \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox